From: Joe Perches <joe@perches.com>
To: Andrei Maresu <andreimaresu@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Dma: at_hdmac_regs fixed a space coding style issue
Date: Mon, 23 Mar 2015 13:52:14 -0700 [thread overview]
Message-ID: <1427143934.16851.46.camel@perches.com> (raw)
In-Reply-To: <1427143021-5140-1-git-send-email-andreimaresu@gmail.com>
On Mon, 2015-03-23 at 22:37 +0200, Andrei Maresu wrote:
> The following chaeckpatch error was fixed:
> ERROR: space prohibited after that open parenthesis '('
[]
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
[]
> @@ -53,7 +53,7 @@
>
> #define AT_DMA_CHER 0x28 /* Channel Handler Enable Register */
> #define AT_DMA_ENA(x) (0x1 << (x))
> -#define AT_DMA_SUSP(x) (0x1 << ( 8 + (x)))
> +#define AT_DMA_SUSP(x) (0x1 << (8 + (x)))
> #define AT_DMA_KEEP(x) (0x1 << (24 + (x)))
Meh.
I think this isn't much of an improvement.
This was likely done to align these AT_ defines.
Another option might be to use the BIT macro.
#define AT_DMA_SUSP(x) BIT((x) + 8)
#define AT_DMA_KEEP(x) BIT((x) + 24)
prev parent reply other threads:[~2015-03-23 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 20:37 Andrei Maresu
2015-03-23 20:52 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427143934.16851.46.camel@perches.com \
--to=joe@perches.com \
--cc=andreimaresu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®