* [PATCH 1/2] Dma: at_hdmac_regs fixed a space coding style issue
@ 2015-03-23 20:37 Andrei Maresu
2015-03-23 20:52 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Maresu @ 2015-03-23 20:37 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrei Maresu
The following chaeckpatch error was fixed:
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Andrei Maresu <andreimaresu@gmail.com>
---
drivers/dma/at_hdmac_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
index 2727ca5..76611a3 100644
--- a/drivers/dma/at_hdmac_regs.h
+++ b/drivers/dma/at_hdmac_regs.h
@@ -53,7 +53,7 @@
#define AT_DMA_CHER 0x28 /* Channel Handler Enable Register */
#define AT_DMA_ENA(x) (0x1 << (x))
-#define AT_DMA_SUSP(x) (0x1 << ( 8 + (x)))
+#define AT_DMA_SUSP(x) (0x1 << (8 + (x)))
#define AT_DMA_KEEP(x) (0x1 << (24 + (x)))
#define AT_DMA_CHDR 0x2C /* Channel Handler Disable Register */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] Dma: at_hdmac_regs fixed a space coding style issue
2015-03-23 20:37 [PATCH 1/2] Dma: at_hdmac_regs fixed a space coding style issue Andrei Maresu
@ 2015-03-23 20:52 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2015-03-23 20:52 UTC (permalink / raw)
To: Andrei Maresu; +Cc: linux-kernel
On Mon, 2015-03-23 at 22:37 +0200, Andrei Maresu wrote:
> The following chaeckpatch error was fixed:
> ERROR: space prohibited after that open parenthesis '('
[]
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
[]
> @@ -53,7 +53,7 @@
>
> #define AT_DMA_CHER 0x28 /* Channel Handler Enable Register */
> #define AT_DMA_ENA(x) (0x1 << (x))
> -#define AT_DMA_SUSP(x) (0x1 << ( 8 + (x)))
> +#define AT_DMA_SUSP(x) (0x1 << (8 + (x)))
> #define AT_DMA_KEEP(x) (0x1 << (24 + (x)))
Meh.
I think this isn't much of an improvement.
This was likely done to align these AT_ defines.
Another option might be to use the BIT macro.
#define AT_DMA_SUSP(x) BIT((x) + 8)
#define AT_DMA_KEEP(x) BIT((x) + 24)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 20:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-23 20:37 [PATCH 1/2] Dma: at_hdmac_regs fixed a space coding style issue Andrei Maresu
2015-03-23 20:52 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®