mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Salter <msalter@redhat.com>
To: Chen Gang <xili_gchen_5257@hotmail.com>
Cc: a-jacquiot@ti.com, linux-c6x-dev@linux-c6x.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] c6x: include: asm: dma-mapping: Add dummy dma_sync_single_range_for_device
Date: Thu, 26 Mar 2015 10:57:22 -0400	[thread overview]
Message-ID: <1427381842.9430.46.camel@deneb.redhat.com> (raw)
In-Reply-To: <BLU436-SMTP76C5ED5BCD8DC9EA10BA32B91E0@phx.gbl>

On Wed, 2015-03-04 at 11:09 +0800, Chen Gang wrote:
> c6x does not implement get_dma_ops() for dma-mapping-common.h. And in
> dma-mapping-common.h, dma_sync_single_range_for_device() may be dummy.
> So c6x can just define a dummy function for allmodconfig building.
> 
>     CC [M]  drivers/net/ethernet/micrel/ks8851.o
>   drivers/net/ethernet/micrel/ks8842.c: In function 'ks8842_tx_frame_dma':
>   drivers/net/ethernet/micrel/ks8842.c:453:2: error: implicit declaration of function 'dma_sync_single_range_for_device' [-Werror=implicit-function-declaration]
>     dma_sync_single_range_for_device(adapter->dev,
>     ^
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---

Thanks! I added this to the c6x tree for next merge window.

>  arch/c6x/include/asm/dma-mapping.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/c6x/include/asm/dma-mapping.h b/arch/c6x/include/asm/dma-mapping.h
> index 88bd0d8..bbd7774 100644
> --- a/arch/c6x/include/asm/dma-mapping.h
> +++ b/arch/c6x/include/asm/dma-mapping.h
> @@ -17,6 +17,14 @@
>  
>  #define dma_supported(d, m)	1
>  
> +static inline void dma_sync_single_range_for_device(struct device *dev,
> +						    dma_addr_t addr,
> +						    unsigned long offset,
> +						    size_t size,
> +						    enum dma_data_direction dir)
> +{
> +}
> +
>  static inline int dma_set_mask(struct device *dev, u64 dma_mask)
>  {
>  	if (!dev->dma_mask || !dma_supported(dev, dma_mask))



      reply	other threads:[~2015-03-26 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04  3:09 Chen Gang
2015-03-26 14:57 ` Mark Salter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427381842.9430.46.camel@deneb.redhat.com \
    --to=msalter@redhat.com \
    --cc=a-jacquiot@ti.com \
    --cc=linux-c6x-dev@linux-c6x.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xili_gchen_5257@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®