From: Mark Salter <msalter@redhat.com>
To: Chen Gang <xili_gchen_5257@hotmail.com>
Cc: a-jacquiot@ti.com, linux-c6x-dev@linux-c6x.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] c6x: kernel: setup: Add screen_info global variable
Date: Thu, 26 Mar 2015 10:57:56 -0400 [thread overview]
Message-ID: <1427381876.9430.48.camel@deneb.redhat.com> (raw)
In-Reply-To: <BLU436-SMTP246AEBA8CA0F91927D48F0DB91E0@phx.gbl>
On Wed, 2015-03-04 at 14:12 +0800, Chen Gang wrote:
> Or can not pass building with allmodconfig:
>
> LD init/built-in.o
> drivers/built-in.o: In function `vgacon_switch':
> vgacon.c:(.text+0x47f8): undefined reference to `screen_info'
> vgacon.c:(.text+0x4810): undefined reference to `screen_info'
> drivers/built-in.o: In function `vgacon_resize':
> vgacon.c:(.text+0x4ac8): undefined reference to `screen_info'
> vgacon.c:(.text+0x4acc): undefined reference to `screen_info'
> drivers/built-in.o: In function `vgacon_save_screen':
> vgacon.c:(.text+0x4cc8): undefined reference to `screen_info'
> drivers/built-in.o:vgacon.c:(.text+0x4cd0): more undefined references to `screen_info' follow
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
Thanks! I added this to the c6x tree for next merge window.
> arch/c6x/kernel/setup.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/c6x/kernel/setup.c b/arch/c6x/kernel/setup.c
> index 1d9f399..165bbd9 100644
> --- a/arch/c6x/kernel/setup.c
> +++ b/arch/c6x/kernel/setup.c
> @@ -27,6 +27,7 @@
> #include <linux/fs.h>
> #include <linux/of.h>
> #include <linux/console.h>
> +#include <linux/screen_info.h>
>
> #include <asm/sections.h>
> #include <asm/div64.h>
> @@ -38,6 +39,8 @@
>
> static const char *c6x_soc_name;
>
> +struct screen_info screen_info;
> +
> int c6x_num_cores;
> EXPORT_SYMBOL_GPL(c6x_num_cores);
>
prev parent reply other threads:[~2015-03-26 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 6:12 Chen Gang
2015-03-26 14:57 ` Mark Salter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427381876.9430.48.camel@deneb.redhat.com \
--to=msalter@redhat.com \
--cc=a-jacquiot@ti.com \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xili_gchen_5257@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®