From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vinod.koul@intel.com>, <linux@arm.linux.org.uk>
Cc: <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 0/5] dmaengine: Fix memory leak amongs virt-dma users
Date: Fri, 27 Mar 2015 13:35:50 +0200 [thread overview]
Message-ID: <1427456155-28990-1-git-send-email-peter.ujfalusi@ti.com> (raw)
Hi,
Due to the implementation of some of the drivers using virt-dma they leak memory
by design.
All it takes is to stop a transfer which is not yet completed, this includes
cyclic (audio) channels also.
These drivers tend to remove the vdesc->node from the virt-dma lists when they
start the transfer. In terminate all vchan_get_all_descriptors() will not find
the transfer which is still running (not in any of the lists) so the free_desc
callback will not be called on them leaving us with memory leak.
There are other drivers leaking memory IMHO, but I was not sure how to fix them:
sun6i-dma,
sa11x0-dma,
k3dma
Others are already doing something to prevent the leak by either directly
freeing the desc or by adding back the vdesc->node to a list.
Regards,
Peter
---
Peter Ujfalusi (4):
dmaengine: omap-dma: Fix memory leak when terminating running transfer
dmaengine: bcm2835-dma: Fix memory leak when stopping a running
transfer
dmaengine: hsu: Fix memory leak when stopping a running transfer
dmaengine: moxart-dma: Fix memory leak when stopping a running
transfer
Petr Kulhavy (1):
dmaengine: edma: fix memory leak when terminating running transfers
drivers/dma/bcm2835-dma.c | 1 +
drivers/dma/edma.c | 7 +++++++
drivers/dma/hsu/hsu.c | 5 ++++-
drivers/dma/moxart-dma.c | 4 +++-
drivers/dma/omap-dma.c | 1 +
5 files changed, 16 insertions(+), 2 deletions(-)
--
2.3.3
next reply other threads:[~2015-03-27 11:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 11:35 Peter Ujfalusi [this message]
2015-03-27 11:35 ` [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a " Peter Ujfalusi
2015-03-28 3:57 ` Stephen Warren
2015-03-28 21:50 ` Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 4/5] dmaengine: hsu: " Peter Ujfalusi
2015-03-27 12:01 ` Andy Shevchenko
2015-03-30 17:37 ` Vinod Koul
2015-04-28 11:17 ` 'Greg Kroah-Hartman'
2015-05-04 11:04 ` Vinod Koul
2015-05-07 16:26 ` Andy Shevchenko
2015-03-27 11:35 ` [PATCH 5/5] dmaengine: moxart-dma: " Peter Ujfalusi
2015-03-30 17:49 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427456155-28990-1-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®