From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vinod.koul@intel.com>, <linux@arm.linux.org.uk>
Cc: <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH 4/5] dmaengine: hsu: Fix memory leak when stopping a running transfer
Date: Fri, 27 Mar 2015 13:35:54 +0200 [thread overview]
Message-ID: <1427456155-28990-5-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1427456155-28990-1-git-send-email-peter.ujfalusi@ti.com>
The vd->node is removed from the lists when the transfer started so the
vchan_get_all_descriptors() will not find it. This results memory leak.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/hsu/hsu.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/hsu/hsu.c b/drivers/dma/hsu/hsu.c
index 683ba9b62795..d1864bda008f 100644
--- a/drivers/dma/hsu/hsu.c
+++ b/drivers/dma/hsu/hsu.c
@@ -387,7 +387,10 @@ static int hsu_dma_terminate_all(struct dma_chan *chan)
spin_lock_irqsave(&hsuc->vchan.lock, flags);
hsu_dma_stop_channel(hsuc);
- hsuc->desc = NULL;
+ if (hsuc->desc) {
+ hsu_dma_desc_free(&hsuc->desc->vchan);
+ hsuc->desc = NULL;
+ }
vchan_get_all_descriptors(&hsuc->vchan, &head);
spin_unlock_irqrestore(&hsuc->vchan.lock, flags);
--
2.3.3
next prev parent reply other threads:[~2015-03-27 11:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 11:35 [PATCH 0/5] dmaengine: Fix memory leak amongs virt-dma users Peter Ujfalusi
2015-03-27 11:35 ` [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a " Peter Ujfalusi
2015-03-28 3:57 ` Stephen Warren
2015-03-28 21:50 ` Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` Peter Ujfalusi [this message]
2015-03-27 12:01 ` [PATCH 4/5] dmaengine: hsu: " Andy Shevchenko
2015-03-30 17:37 ` Vinod Koul
2015-04-28 11:17 ` 'Greg Kroah-Hartman'
2015-05-04 11:04 ` Vinod Koul
2015-05-07 16:26 ` Andy Shevchenko
2015-03-27 11:35 ` [PATCH 5/5] dmaengine: moxart-dma: " Peter Ujfalusi
2015-03-30 17:49 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427456155-28990-5-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®