From: Paul Bolle <pebolle@tiscali.nl>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Steven Honeyman" <stevenhoneyman@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jean Delvare" <jdelvare@suse.de>,
"Valdis Kletnieks" <Valdis.Kletnieks@vt.edu>,
"Jochen Eisinger" <jochen@penguin-breeder.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k
Date: Sat, 28 Mar 2015 23:44:00 +0100 [thread overview]
Message-ID: <1427582640.3377.0.camel@tiscali.nl> (raw)
In-Reply-To: <55172939.4070100@roeck-us.net>
Guenter Roeck schreef op za 28-03-2015 om 15:20 [-0700]:
> Maybe that is the plan, but it is not what is happening.
> I8K selects SENSORS_DELL_SMM, so a boolean I8K forces SENSORS_DELL_SMM
> to be built into the kernel.
>
> What you suggest would work if I8K would depend on SENSORS_DELL_SMM,
> but then the symbols would not be backward-compatible.
I haven't actually looked into this part of the patch, since as far as
I'm concerned this patch is broken.
Having said that, if using a second Kconfig symbol is worth the effort,
perhaps there's also enough reason to break Kconfig backward
compatibility. People shouldn't alter Kconfig symbols just because they
can, but as far as I'm aware we're on the record to not guarantee
backward compatibility for Kconfig symbols.
Paul Bolle
next prev parent reply other threads:[~2015-03-28 22:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 10:24 [PATCH 0/2] i8k.c => dell-smm-hwmon.c Pali Rohár
2015-03-28 10:24 ` [PATCH 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Pali Rohár
2015-03-28 14:31 ` Guenter Roeck
2015-03-28 10:24 ` [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-03-28 11:04 ` Paul Bolle
2015-03-28 12:54 ` Steven Honeyman
2015-03-28 14:13 ` Guenter Roeck
2015-03-28 22:00 ` Pali Rohár
2015-03-28 22:20 ` Guenter Roeck
2015-03-28 22:44 ` Paul Bolle [this message]
2015-03-29 0:55 ` Guenter Roeck
2015-03-30 8:01 ` Paul Bolle
2015-03-28 21:55 ` Pali Rohár
2015-03-28 22:06 ` Paul Bolle
2015-03-28 22:19 ` Steven Honeyman
2015-03-28 22:33 ` Pali Rohár
2015-03-30 7:44 ` Jean Delvare
2015-03-28 14:23 ` Guenter Roeck
2015-03-28 22:04 ` Pali Rohár
2015-03-29 12:57 ` [PATCH v2 0/2] i8k.c => dell-smm-hwmon.c Pali Rohár
2015-03-29 12:57 ` [PATCH v2 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Pali Rohár
2015-03-29 12:57 ` [PATCH v2 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-04-28 12:38 ` Greg Kroah-Hartman
2015-04-29 11:41 ` [PATCH v3 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Pali Rohár
2015-04-29 11:41 ` [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-06-27 11:34 ` Gabriele Mazzotta
2015-06-27 12:47 ` Pali Rohár
2015-06-27 12:55 ` Gabriele Mazzotta
2015-06-27 13:01 ` Pali Rohár
2015-06-27 13:21 ` Gabriele Mazzotta
2015-04-29 12:07 ` [PATCH v3 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Greg Kroah-Hartman
2015-03-31 3:32 ` [PATCH v2 0/2] i8k.c => dell-smm-hwmon.c Guenter Roeck
2015-03-31 13:56 ` Greg Kroah-Hartman
2015-04-09 14:02 ` Pali Rohár
2015-04-21 13:30 ` Pali Rohár
2015-04-21 13:40 ` Guenter Roeck
2015-04-21 13:52 ` Greg Kroah-Hartman
2015-04-21 15:24 ` Guenter Roeck
2015-04-21 15:30 ` Greg Kroah-Hartman
2015-04-27 18:39 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427582640.3377.0.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=Valdis.Kletnieks@vt.edu \
--cc=arnd@arndb.de \
--cc=gabriele.mzt@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=jochen@penguin-breeder.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=pali.rohar@gmail.com \
--cc=stevenhoneyman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®