mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "M. Vefa Bicakci" <m.v.b@runbox.com>
To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Cc: joe@perches.com, gregkh@linuxfoundation.org,
	Jes.Sorensen@redhat.com, Larry.Finger@lwfinger.net,
	mail@beyermatthias.de, m.v.b@runbox.com
Subject: [PATCH v5 12/15] staging: rtl8723au: suspect code indent for conditional statements
Date: Sat, 28 Mar 2015 21:07:55 -0400	[thread overview]
Message-ID: <1427591278-982-13-git-send-email-m.v.b@runbox.com> (raw)
In-Reply-To: <1427591278-982-1-git-send-email-m.v.b@runbox.com>

Correct a number of indentation-with-spaces-and-tabs issues in
rtl8723au's rtw_security.c, according to checkpatch.pl:
	WARNING: suspect code indent for conditional statements

Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>

---

v3: Make sure that all edited lines are at most 80 characters wide.
---
 drivers/staging/rtl8723au/core/rtw_security.c | 34 +++++++++++++--------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
index 8e0e9fa0efdc..bcb5ea68acbe 100644
--- a/drivers/staging/rtl8723au/core/rtw_security.c
+++ b/drivers/staging/rtl8723au/core/rtw_security.c
@@ -929,9 +929,9 @@ static void mix_column(u8 *in, u8 *out)
 
 	for (i = 0; i < 4; i++) {
 		if ((in[i] & 0x80) == 0x80)
-		    add1b[i] = 0x1b;
+			add1b[i] = 0x1b;
 		else
-		    add1b[i] = 0x00;
+			add1b[i] = 0x00;
 	}
 
 	swap_halfs[0] = in[2]; /* Swap halfs */
@@ -986,21 +986,21 @@ static void aes128k128d(u8 *key, u8 *data, u8 *ciphertext)
 
 	for (round = 0; round < 11; round++) {
 		if (round == 0) {
-		    xor_128(round_key, data, ciphertext);
-		    next_key(round_key, round);
+			xor_128(round_key, data, ciphertext);
+			next_key(round_key, round);
 		} else if (round == 10) {
-		    byte_sub(ciphertext, intermediatea);
-		    shift_row(intermediatea, intermediateb);
-		    xor_128(intermediateb, round_key, ciphertext);
+			byte_sub(ciphertext, intermediatea);
+			shift_row(intermediatea, intermediateb);
+			xor_128(intermediateb, round_key, ciphertext);
 		} else { /* 1 - 9 */
-		    byte_sub(ciphertext, intermediatea);
-		    shift_row(intermediatea, intermediateb);
-		    mix_column(&intermediateb[0], &intermediatea[0]);
-		    mix_column(&intermediateb[4], &intermediatea[4]);
-		    mix_column(&intermediateb[8], &intermediatea[8]);
-		    mix_column(&intermediateb[12], &intermediatea[12]);
-		    xor_128(intermediatea, round_key, ciphertext);
-		    next_key(round_key, round);
+			byte_sub(ciphertext, intermediatea);
+			shift_row(intermediatea, intermediateb);
+			mix_column(&intermediateb[0], &intermediatea[0]);
+			mix_column(&intermediateb[4], &intermediatea[4]);
+			mix_column(&intermediateb[8], &intermediatea[8]);
+			mix_column(&intermediateb[12], &intermediatea[12]);
+			xor_128(intermediatea, round_key, ciphertext);
+			next_key(round_key, round);
 		}
 	}
 
@@ -1501,7 +1501,7 @@ static int aes_decipher(u8 *key, uint hdrlen, u8 *pframe, uint plen)
 		for (j = 0; j < 16; j++)
 			padded_buffer[j] = 0x00;
 		for (j = 0; j < payload_remainder; j++)
-		    padded_buffer[j] = message[payload_index++];
+			padded_buffer[j] = message[payload_index++];
 		bitwise_xor(aes_out, padded_buffer, chain_buffer);
 		aes128k128d(key, chain_buffer, aes_out);
 	}
@@ -1531,7 +1531,7 @@ static int aes_decipher(u8 *key, uint hdrlen, u8 *pframe, uint plen)
 				      message, pn_vector, num_blocks + 1);
 
 		for (j = 0; j < 16; j++)
-			 padded_buffer[j] = 0x00;
+			padded_buffer[j] = 0x00;
 		for (j = 0; j < payload_remainder; j++)
 			padded_buffer[j] = message[payload_index + j];
 		aes128k128d(key, ctr_preload, aes_out);
-- 
2.1.4


  parent reply	other threads:[~2015-03-29  1:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-29  1:07 [PATCH v5 00/15] checkpatch clean-up of rtl8723au's rtw_security.c M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 01/15] staging: rtl8723au: Reformat whitespace to increase readability M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 03/15] staging: rtl8723au: else should follow close brace M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 04/15] staging: rtl8723au: Fix the indentation of two lines M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 06/15] staging: rtl8723au: else is not generally useful after a return M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 07/15] staging: rtl8723au: Remove unneeded curly braces M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 08/15] staging: rtl8723au: trailing statements should be on next line M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 09/15] staging: rtl8723au: that open brace should be on the previous line M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 10/15] staging: rtl8723au: No spaces at the start of a line M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 11/15] staging: rtl8723au: Adjust whitespace in and around comments M. Vefa Bicakci
2015-03-29  1:07 ` M. Vefa Bicakci [this message]
2015-03-29  1:07 ` [PATCH v5 13/15] staging: rtl8723au: Rework two byte array comparisons M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 14/15] staging: rtl8723au: Use __func__ in trace logs M. Vefa Bicakci
2015-03-29  1:07 ` [PATCH v5 15/15] staging: rtl8723au: Remove unneeded comments M. Vefa Bicakci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427591278-982-13-git-send-email-m.v.b@runbox.com \
    --to=m.v.b@runbox.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mail@beyermatthias.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®