From: "M. Vefa Bicakci" <m.v.b@runbox.com>
To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Cc: joe@perches.com, gregkh@linuxfoundation.org,
Jes.Sorensen@redhat.com, Larry.Finger@lwfinger.net,
mail@beyermatthias.de, m.v.b@runbox.com
Subject: [PATCH v5 03/15] staging: rtl8723au: else should follow close brace
Date: Sat, 28 Mar 2015 21:07:46 -0400 [thread overview]
Message-ID: <1427591278-982-4-git-send-email-m.v.b@runbox.com> (raw)
In-Reply-To: <1427591278-982-1-git-send-email-m.v.b@runbox.com>
Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating
that an else statement should follow the closing brace of the previous
if/else if code block:
ERROR: else should follow close brace '}'
Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
---
drivers/staging/rtl8723au/core/rtw_security.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
index 572fcf3f936d..9faf78bf23d8 100644
--- a/drivers/staging/rtl8723au/core/rtw_security.c
+++ b/drivers/staging/rtl8723au/core/rtw_security.c
@@ -376,8 +376,7 @@ void rtw_seccalctkipmic23a(u8 *key, u8 *header, u8 *data, u32 data_len,
rtw_secmicappend23a(&micdata, &header[24], 6);
else
rtw_secmicappend23a(&micdata, &header[10], 6);
- }
- else{ /* ToDS == 0 */
+ } else { /* ToDS == 0 */
rtw_secmicappend23a(&micdata, &header[4], 6); /* DA */
if (header[1]&2) /* From Ds == 1 */
rtw_secmicappend23a(&micdata, &header[16], 6);
@@ -678,8 +677,7 @@ int rtw_tkip_encrypt23a(struct rtw_adapter *padapter,
arcfour_encrypt(&mycontext, payload, payload, length);
arcfour_encrypt(&mycontext, payload + length, crc, 4);
- }
- else {
+ } else {
length = (pxmitpriv->frag_len -
pattrib->hdrlen -
pattrib->iv_len -
@@ -695,8 +693,7 @@ int rtw_tkip_encrypt23a(struct rtw_adapter *padapter,
}
}
- }
- else {
+ } else {
RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
"rtw_tkip_encrypt23a: stainfo == NULL!!!\n");
DBG_8723A("%s, psta == NUL\n", __func__);
--
2.1.4
next prev parent reply other threads:[~2015-03-29 1:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-29 1:07 [PATCH v5 00/15] checkpatch clean-up of rtl8723au's rtw_security.c M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 01/15] staging: rtl8723au: Reformat whitespace to increase readability M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues M. Vefa Bicakci
2015-03-29 1:07 ` M. Vefa Bicakci [this message]
2015-03-29 1:07 ` [PATCH v5 04/15] staging: rtl8723au: Fix the indentation of two lines M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 06/15] staging: rtl8723au: else is not generally useful after a return M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 07/15] staging: rtl8723au: Remove unneeded curly braces M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 08/15] staging: rtl8723au: trailing statements should be on next line M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 09/15] staging: rtl8723au: that open brace should be on the previous line M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 10/15] staging: rtl8723au: No spaces at the start of a line M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 11/15] staging: rtl8723au: Adjust whitespace in and around comments M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 12/15] staging: rtl8723au: suspect code indent for conditional statements M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 13/15] staging: rtl8723au: Rework two byte array comparisons M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 14/15] staging: rtl8723au: Use __func__ in trace logs M. Vefa Bicakci
2015-03-29 1:07 ` [PATCH v5 15/15] staging: rtl8723au: Remove unneeded comments M. Vefa Bicakci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427591278-982-4-git-send-email-m.v.b@runbox.com \
--to=m.v.b@runbox.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mail@beyermatthias.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®