From: Davidlohr Bueso <dave@stgolabs.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Darren Hart <dvhart@linux.intel.com>,
"Carlos O'Donell" <carlos@redhat.com>,
Ingo Molnar <mingo@elte.hu>, Jakub Jelinek <jakub@redhat.com>,
"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Steven Rostedt <rostedt@goodmis.org>,
Linux API <linux-api@vger.kernel.org>,
Torvald Riegel <triegel@redhat.com>,
Roland McGrath <roland@hack.frob.com>,
Darren Hart <dvhart@infradead.org>,
Anton Blanchard <anton@samba.org>,
Eric Dumazet <edumazet@google.com>,
bill o gallmeister <bgallmeister@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Daniel Wagner <wagi@monom.org>, Rich Felker <dalias@libc.org>,
Andy Lutomirski <luto@amacapital.net>,
bert hubert <bert.hubert@netherlabs.nl>,
Rusty Russell <rusty@rustcorp.com.au>,
Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: Re: Revised futex(2) man page for review
Date: Tue, 31 Mar 2015 13:36:45 -0700 [thread overview]
Message-ID: <1427834205.20009.19.camel@stgolabs.net> (raw)
In-Reply-To: <20150328120337.GB32047@worktop.ger.corp.intel.com>
On Sat, 2015-03-28 at 13:03 +0100, Peter Zijlstra wrote:
> > If the timeout argument is non-NULL, its contents specify a rel‐
> > ative timeout for the wait, measured according to the
> > CLOCK_MONOTONIC clock. (This interval will be rounded up to the
> > system clock granularity, and kernel scheduling delays mean that
> > the blocking interval may overrun by a small amount.) If time‐
> > out is NULL, the call blocks indefinitely.
>
> Would it not be better to only state that the wait will not return
> before the timeout -- unless woken -- and not bother with clock
> granularity and scheduling delays?
Yeah, similarly we also have this:
FUTEX_PRIVATE_FLAG (since Linux 2.6.22)
This option bit can be employed with all futex operations. It
tells the kernel that the futex is process-private and not
shared with another process (i.e., it is only being used for
synchronization between threads of the same process). This
allows the kernel to choose the fast path for validating the
user-space address and avoids expensive VMA lookups, taking ref‐
erence counts on file backing store, and so on.
This to me reads a bit too much into the kernel (fastpath, refcnt,
vmas). Why not just mention that it avoids overhead in the kernel or
something? I don't recall any manpage mentioning such details, but I
could be wrong. In any case its a nit, the whole doc is pretty good and
I hope you can merge it soon and then just increment ;)
Thanks,
Davidlohr
next prev parent reply other threads:[~2015-03-31 20:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 8:53 Michael Kerrisk (man-pages)
2015-03-28 8:56 ` Michael Kerrisk (man-pages)
2015-03-28 11:47 ` Peter Zijlstra
2015-03-28 12:03 ` Peter Zijlstra
2015-03-31 20:36 ` Davidlohr Bueso [this message]
2015-07-27 11:00 ` Michael Kerrisk (man-pages)
2015-07-27 11:10 ` Michael Kerrisk (man-pages)
2015-03-31 14:45 ` Davidlohr Bueso
2015-07-27 11:10 ` Michael Kerrisk (man-pages)
2015-07-28 3:16 ` Davidlohr Bueso
2015-07-28 7:44 ` Michael Kerrisk (man-pages)
2015-07-28 17:52 ` Davidlohr Bueso
2015-07-28 18:09 ` Michael Kerrisk (man-pages)
2015-04-14 21:40 ` Thomas Gleixner
2015-04-15 10:28 ` Torvald Riegel
2015-07-27 11:10 ` Michael Kerrisk (man-pages)
2015-04-27 20:37 ` Pavel Machek
2015-07-27 11:10 ` Michael Kerrisk (man-pages)
2015-07-28 2:52 ` Davidlohr Bueso
2015-07-28 6:39 ` Michael Kerrisk (man-pages)
2015-03-31 1:48 ` Rusty Russell
2015-07-27 11:03 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427834205.20009.19.camel@stgolabs.net \
--to=dave@stgolabs.net \
--cc=anton@samba.org \
--cc=arnd@arndb.de \
--cc=bert.hubert@netherlabs.nl \
--cc=bgallmeister@gmail.com \
--cc=carlos@redhat.com \
--cc=dalias@libc.org \
--cc=dvhart@infradead.org \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=jakub@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@elte.hu \
--cc=mtk.manpages@gmail.com \
--cc=peterz@infradead.org \
--cc=roland@hack.frob.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=triegel@redhat.com \
--cc=wagi@monom.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome