* Re: [PATCH 1/2] drivers/tty/serial/sh-sci.h: remove dead reference on ARCH_SH7372
2015-04-11 10:26 [PATCH 1/2] drivers/tty/serial/sh-sci.h: remove dead reference on ARCH_SH7372 Valentin Rothberg
@ 2015-04-24 8:54 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-04-24 8:54 UTC (permalink / raw)
To: Valentin Rothberg
Cc: Greg KH, Jiri Slaby, linux-serial, linux-kernel, Paul Bolle,
Magnus Damm, Linux-sh list
Hi Valentin,
On Sat, Apr 11, 2015 at 12:26 PM, Valentin Rothberg
<valentinrothberg@gmail.com> wrote:
> The Kconfig option ARCH_SH7372 has been removed by commit 59b89af1d555
> ("ARM: shmobile: sh7372: Remove Legacy C SoC code"). This patch removes
> the last reference on this Kconfig option.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
Thanks for your patch!
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> I found this issue with ./scripts/checkkconfigsymbols.py
> ---
> drivers/tty/serial/sh-sci.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.h b/drivers/tty/serial/sh-sci.h
> index d5db81a0a430..350717404507 100644
> --- a/drivers/tty/serial/sh-sci.h
> +++ b/drivers/tty/serial/sh-sci.h
> @@ -15,7 +15,6 @@
> defined(CONFIG_CPU_SUBTYPE_SH7720) || \
> defined(CONFIG_CPU_SUBTYPE_SH7721) || \
> defined(CONFIG_ARCH_SH73A0) || \
> - defined(CONFIG_ARCH_SH7372) || \
> defined(CONFIG_ARCH_R8A7740)
> # define SCxSR_RDxF_CLEAR(port) (serial_port_in(port, SCxSR) & 0xfffc)
There are more things wrong with the above:
1. It's not multi-platform safe: any ARM kernel with sh73a0 or r8a7740
support will treat all SCIFs and HSCIFs as SCIFA/Bs.
2. It wasn't updated for newer SoCs, e.g.
- r8a73a4 has SCIFA/B, too,
- R-Car Gen2 has all of SCIF, HSCIF, SCIFA, SCIFB, which isn't
supported by the current logic at all.
Looking into it...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread