From: Joe Perches <joe@perches.com>
To: Chase Metzger <chasemetzger15@gmail.com>
Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
balbi@ti.com, dan.j.williams@intel.com,
antoine.tenart@free-electrons.com, pmladek@suse.cz,
sojka@merica.cz, xerofoify@gmail.com,
sergei.shtylyov@cogentembedded.com, rafael.j.wysocki@intel.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/usb/core: hcd.c: Removed all space warnings from checkpatch.pl
Date: Sat, 11 Apr 2015 09:19:56 -0700 [thread overview]
Message-ID: <1428769196.5413.55.camel@perches.com> (raw)
In-Reply-To: <1428746673-12352-1-git-send-email-chasemetzger15@gmail.com>
On Sat, 2015-04-11 at 03:04 -0700, Chase Metzger wrote:
> Removed all(except false positives, from calculations) space prohibited warnings generated by
> checkpatch.pl.
False positives? Please describe them.
The only thing I believe you elided was the
use of a BitTime macro which in my opinion
should be used as a function.
drivers/usb/core/hcd.c: tmp = (67667L * (31L + 10L * BitTime (bytecount))) / 1000L;
as it is in the include file:
include/linux/usb/hcd.h: + (2083UL * (3 + BitTime(bytes))))/1000 \
prev parent reply other threads:[~2015-04-11 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-11 10:04 Chase Metzger
2015-04-11 16:19 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428769196.5413.55.camel@perches.com \
--to=joe@perches.com \
--cc=antoine.tenart@free-electrons.com \
--cc=balbi@ti.com \
--cc=chasemetzger15@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmladek@suse.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sojka@merica.cz \
--cc=stern@rowland.harvard.edu \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®