* [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly
@ 2015-04-27 9:51 Sudeep Holla
2015-04-27 9:51 ` [PATCH 2/2] cpufreq: arm_big_little: remove unused cpu-cluster.<n> clock name Sudeep Holla
2015-04-27 10:26 ` [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly Viresh Kumar
0 siblings, 2 replies; 4+ messages in thread
From: Sudeep Holla @ 2015-04-27 9:51 UTC (permalink / raw)
To: linux-kernel, linux-pm; +Cc: Sudeep Holla, Viresh Kumar, Rafael J. Wysocki
The actual frequency is set through "clk_change_rate" which is void
function. If the underlying hardware fails and returns error, the error
is lost in the clk layer. In order to track such failures, we need to
read back the frequency(just the cached value as clk_recalc called after
clk->ops->set_rate gets the frequency)
This patch adds check to see if the frequency is set correctly or if
they were any hardware failures and sends the appropriate errors to the
cpufreq core.
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Michael Turquette <mike.turquette@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/cpufreq/arm_big_little.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
index e1a6ba66a7f5..f65e19f340d0 100644
--- a/drivers/cpufreq/arm_big_little.c
+++ b/drivers/cpufreq/arm_big_little.c
@@ -186,6 +186,15 @@ bL_cpufreq_set_rate(u32 cpu, u32 old_cluster, u32 new_cluster, u32 rate)
mutex_unlock(&cluster_lock[old_cluster]);
}
+ /*
+ * FIXME: clk_set_rate has to handle the case where clk_change_rate
+ * can fail due to hardware or firmware issues. Until the clk core
+ * layer is fixed, we can check here. In most of the cases we will
+ * be reading only the cached value anyway. This needs to be removed
+ * once clk core is fixed.
+ */
+ if (bL_cpufreq_get_rate(cpu) != new_rate)
+ return -EIO;
return 0;
}
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] cpufreq: arm_big_little: remove unused cpu-cluster.<n> clock name
2015-04-27 9:51 [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly Sudeep Holla
@ 2015-04-27 9:51 ` Sudeep Holla
2015-04-27 10:26 ` [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly Viresh Kumar
1 sibling, 0 replies; 4+ messages in thread
From: Sudeep Holla @ 2015-04-27 9:51 UTC (permalink / raw)
To: linux-kernel, linux-pm; +Cc: Sudeep Holla, Viresh Kumar, Rafael J. Wysocki
The "cpu-cluster.<n>" used to get the cluster clock is not used by any
platform. Moreover __of_clk_get_by_name used in clk_get return error if
the "clock-names" in the DT doesn't match this string. When using DT,
it's not compulsory to specify the clock name unless there are multiple
clock input entries in the consumer.
This patch removes the unused clock string from the driver.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/cpufreq/arm_big_little.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
index f65e19f340d0..e4d75ca9f3b0 100644
--- a/drivers/cpufreq/arm_big_little.c
+++ b/drivers/cpufreq/arm_big_little.c
@@ -331,7 +331,6 @@ static void put_cluster_clk_and_freq_table(struct device *cpu_dev)
static int _get_cluster_clk_and_freq_table(struct device *cpu_dev)
{
u32 cluster = raw_cpu_to_cluster(cpu_dev->id);
- char name[14] = "cpu-cluster.";
int ret;
if (freq_table[cluster])
@@ -351,8 +350,7 @@ static int _get_cluster_clk_and_freq_table(struct device *cpu_dev)
goto free_opp_table;
}
- name[12] = cluster + '0';
- clk[cluster] = clk_get(cpu_dev, name);
+ clk[cluster] = clk_get(cpu_dev, NULL);
if (!IS_ERR(clk[cluster])) {
dev_dbg(cpu_dev, "%s: clk: %p & freq table: %p, cluster: %d\n",
__func__, clk[cluster], freq_table[cluster],
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly
2015-04-27 9:51 [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly Sudeep Holla
2015-04-27 9:51 ` [PATCH 2/2] cpufreq: arm_big_little: remove unused cpu-cluster.<n> clock name Sudeep Holla
@ 2015-04-27 10:26 ` Viresh Kumar
2015-05-15 0:20 ` Rafael J. Wysocki
1 sibling, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2015-04-27 10:26 UTC (permalink / raw)
To: Sudeep Holla; +Cc: Linux Kernel Mailing List, linux-pm, Rafael J. Wysocki
On 27 April 2015 at 15:21, Sudeep Holla <sudeep.holla@arm.com> wrote:
> The actual frequency is set through "clk_change_rate" which is void
> function. If the underlying hardware fails and returns error, the error
> is lost in the clk layer. In order to track such failures, we need to
> read back the frequency(just the cached value as clk_recalc called after
> clk->ops->set_rate gets the frequency)
>
> This patch adds check to see if the frequency is set correctly or if
> they were any hardware failures and sends the appropriate errors to the
> cpufreq core.
>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Reviewed-by: Michael Turquette <mike.turquette@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/cpufreq/arm_big_little.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
> index e1a6ba66a7f5..f65e19f340d0 100644
> --- a/drivers/cpufreq/arm_big_little.c
> +++ b/drivers/cpufreq/arm_big_little.c
> @@ -186,6 +186,15 @@ bL_cpufreq_set_rate(u32 cpu, u32 old_cluster, u32 new_cluster, u32 rate)
> mutex_unlock(&cluster_lock[old_cluster]);
> }
>
> + /*
> + * FIXME: clk_set_rate has to handle the case where clk_change_rate
> + * can fail due to hardware or firmware issues. Until the clk core
> + * layer is fixed, we can check here. In most of the cases we will
> + * be reading only the cached value anyway. This needs to be removed
> + * once clk core is fixed.
> + */
> + if (bL_cpufreq_get_rate(cpu) != new_rate)
> + return -EIO;
> return 0;
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly
2015-04-27 10:26 ` [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly Viresh Kumar
@ 2015-05-15 0:20 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2015-05-15 0:20 UTC (permalink / raw)
To: Viresh Kumar; +Cc: Sudeep Holla, Linux Kernel Mailing List, linux-pm
On Monday, April 27, 2015 03:56:18 PM Viresh Kumar wrote:
> On 27 April 2015 at 15:21, Sudeep Holla <sudeep.holla@arm.com> wrote:
> > The actual frequency is set through "clk_change_rate" which is void
> > function. If the underlying hardware fails and returns error, the error
> > is lost in the clk layer. In order to track such failures, we need to
> > read back the frequency(just the cached value as clk_recalc called after
> > clk->ops->set_rate gets the frequency)
> >
> > This patch adds check to see if the frequency is set correctly or if
> > they were any hardware failures and sends the appropriate errors to the
> > cpufreq core.
> >
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Reviewed-by: Michael Turquette <mike.turquette@linaro.org>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > drivers/cpufreq/arm_big_little.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
> > index e1a6ba66a7f5..f65e19f340d0 100644
> > --- a/drivers/cpufreq/arm_big_little.c
> > +++ b/drivers/cpufreq/arm_big_little.c
> > @@ -186,6 +186,15 @@ bL_cpufreq_set_rate(u32 cpu, u32 old_cluster, u32 new_cluster, u32 rate)
> > mutex_unlock(&cluster_lock[old_cluster]);
> > }
> >
> > + /*
> > + * FIXME: clk_set_rate has to handle the case where clk_change_rate
> > + * can fail due to hardware or firmware issues. Until the clk core
> > + * layer is fixed, we can check here. In most of the cases we will
> > + * be reading only the cached value anyway. This needs to be removed
> > + * once clk core is fixed.
> > + */
> > + if (bL_cpufreq_get_rate(cpu) != new_rate)
> > + return -EIO;
> > return 0;
> > }
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Both queued up for 4.2, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-14 23:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-27 9:51 [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly Sudeep Holla
2015-04-27 9:51 ` [PATCH 2/2] cpufreq: arm_big_little: remove unused cpu-cluster.<n> clock name Sudeep Holla
2015-04-27 10:26 ` [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly Viresh Kumar
2015-05-15 0:20 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®