[PATCH] ACPICA: remove duplicate u8 typedef

[PATCH] ACPICA: remove duplicate u8 typedef

[Olaf Hering]

During commit e252652fb2664d42de19f933aa3688bbc470de3f ("ACPICA:
acpidump: Remove integer types translation protection.") two 'unsigned
char' types got converted to 'u8'.

The result does not compile with gcc-4.5, it can not cope with duplicate
typedefs.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 include/acpi/actypes.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h
index f5ca0e9..1c3002e 100644
--- a/include/acpi/actypes.h
+++ b/include/acpi/actypes.h
@@ -124,7 +124,6 @@
 #ifndef ACPI_USE_SYSTEM_INTTYPES
 
 typedef unsigned char u8;
-typedef unsigned char u8;
 typedef unsigned short u16;
 typedef short s16;
 typedef COMPILER_DEPENDENT_UINT64 u64;

RE: [PATCH] ACPICA: remove duplicate u8 typedef

[Zheng, Lv]

Hi,

> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Tuesday, April 28, 2015 10:54 PM
> Subject: [PATCH] ACPICA: remove duplicate u8 typedef
> 
> During commit e252652fb2664d42de19f933aa3688bbc470de3f ("ACPICA:
> acpidump: Remove integer types translation protection.") two 'unsigned
> char' types got converted to 'u8'.
> 
> The result does not compile with gcc-4.5, it can not cope with duplicate
> typedefs.

The 2 u8 typedefs actually are different types in ACPICA.
If this really causes problem, I'm OK with deleting it from Linux side.
We'll take care of introducing a new type to eliminate such "divergence".

Thanks
-Lv

> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  include/acpi/actypes.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h
> index f5ca0e9..1c3002e 100644
> --- a/include/acpi/actypes.h
> +++ b/include/acpi/actypes.h
> @@ -124,7 +124,6 @@
>  #ifndef ACPI_USE_SYSTEM_INTTYPES
> 
>  typedef unsigned char u8;
> -typedef unsigned char u8;
>  typedef unsigned short u16;
>  typedef short s16;
>  typedef COMPILER_DEPENDENT_UINT64 u64;

RE: [PATCH] ACPICA: remove duplicate u8 typedef

[Zheng, Lv]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1743 bytes --]

Hi,

> From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net]
> Sent: Wednesday, April 29, 2015 8:44 AM
> Subject: Re: [PATCH] ACPICA: remove duplicate u8 typedef
> 
> On Tuesday, April 28, 2015 04:54:04 PM Olaf Hering wrote:
> > During commit e252652fb2664d42de19f933aa3688bbc470de3f ("ACPICA:
> > acpidump: Remove integer types translation protection.") two 'unsigned
> > char' types got converted to 'u8'.
> >
> > The result does not compile with gcc-4.5, it can not cope with duplicate
> > typedefs.
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> Applied, thanks!
> 
> Lv, can you please see if that's an upstream issue too?

In ACPICA, one u8 is UINT8 and the other is for BOOLEAN.
Pleas merge this first.
I'll think about a solution to reduce this divergence.

Thanks and best regards
-Lv

> 
> > ---
> >  include/acpi/actypes.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h
> > index f5ca0e9..1c3002e 100644
> > --- a/include/acpi/actypes.h
> > +++ b/include/acpi/actypes.h
> > @@ -124,7 +124,6 @@
> >  #ifndef ACPI_USE_SYSTEM_INTTYPES
> >
> >  typedef unsigned char u8;
> > -typedef unsigned char u8;
> >  typedef unsigned short u16;
> >  typedef short s16;
> >  typedef COMPILER_DEPENDENT_UINT64 u64;
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] ACPICA: remove duplicate u8 typedef

[Rafael J. Wysocki]

On Tuesday, April 28, 2015 04:54:04 PM Olaf Hering wrote:
> During commit e252652fb2664d42de19f933aa3688bbc470de3f ("ACPICA:
> acpidump: Remove integer types translation protection.") two 'unsigned
> char' types got converted to 'u8'.
> 
> The result does not compile with gcc-4.5, it can not cope with duplicate
> typedefs.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Applied, thanks!

Lv, can you please see if that's an upstream issue too?

> ---
>  include/acpi/actypes.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h
> index f5ca0e9..1c3002e 100644
> --- a/include/acpi/actypes.h
> +++ b/include/acpi/actypes.h
> @@ -124,7 +124,6 @@
>  #ifndef ACPI_USE_SYSTEM_INTTYPES
>  
>  typedef unsigned char u8;
> -typedef unsigned char u8;
>  typedef unsigned short u16;
>  typedef short s16;
>  typedef COMPILER_DEPENDENT_UINT64 u64;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.