mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arno Tiemersma <arno.tiemersma@gmail.com>
To: gregkh@linuxfoundation.org, mateusz.kulikowski@gmail.com,
	behanw@converseincode.com, mdcasey@chabloom.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Arno Tiemersma <arno.tiemersma@gmail.com>
Subject: [PATCH v2] staging: rtl8192e: Change cpu_to_le16 to le16_to_cpu
Date: Sat,  9 May 2015 22:27:16 +0200	[thread overview]
Message-ID: <1431203236-5895-1-git-send-email-arno.tiemersma@gmail.com> (raw)

Since the function auth_parse returns a u16, and
struct rtllib_authentication.status is defined as an __le16, it seems
that

	return cpu_to_le16(a->status);

should be

	return le16_to_cpu(a->status);

This change silences the following sparse warnings:
drivers/staging/rtl8192e/rtllib_softmac.c:1817:16:
 warning: cast from restricted __le16
drivers/staging/rtl8192e/rtllib_softmac.c:1817:16:
 warning: incorrect type in return expression (different base types)
drivers/staging/rtl8192e/rtllib_softmac.c:1817:16:
    expected unsigned short
drivers/staging/rtl8192e/rtllib_softmac.c:1817:16:
    got restricted __le16 [usertype] <noident>

Signed-off-by: Arno Tiemersma <arno.tiemersma@gmail.com>
---
v2 since I did not have the right e-mail address for Mateusz Kulikowski

 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 8f5e88b..98afd3b 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1814,7 +1814,7 @@ static inline u16 auth_parse(struct sk_buff *skb, u8 **challenge, int *chlen)
 				return -ENOMEM;
 		}
 	}
-	return cpu_to_le16(a->status);
+	return le16_to_cpu(a->status);
 }
 
 static int auth_rq_parse(struct sk_buff *skb, u8 *dest)
-- 
2.1.4


             reply	other threads:[~2015-05-09 20:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 20:27 Arno Tiemersma [this message]
2015-05-09 22:13 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431203236-5895-1-git-send-email-arno.tiemersma@gmail.com \
    --to=arno.tiemersma@gmail.com \
    --cc=behanw@converseincode.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mateusz.kulikowski@gmail.com \
    --cc=mdcasey@chabloom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®