mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
	dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 13/33] staging: rtl8192e: Remove RTLLIB_DEBUG_QOS()
Date: Sat,  9 May 2015 23:19:01 +0200	[thread overview]
Message-ID: <1431206361-13736-14-git-send-email-mateusz.kulikowski@gmail.com> (raw)
In-Reply-To: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com>

- Pass extra argument (rtllib_device) to rtllib_parse_qos_info_param_IE()
  and update_network()
- Replace RTLLIB_DEBUG_QOS() with netdev_dbg()
- Remove RTLLIB_DEBUG_QOS()

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
 drivers/staging/rtl8192e/rtllib.h    |  1 -
 drivers/staging/rtl8192e/rtllib_rx.c | 26 ++++++++++++++------------
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 12a4b1f..a9b9cb9 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -704,7 +704,6 @@ do {								\
 #define RTLLIB_DEBUG_INFO(f, a...)   RTLLIB_DEBUG(RTLLIB_DL_INFO, f, ## a)
 
 #define RTLLIB_DEBUG_MGMT(f, a...)  RTLLIB_DEBUG(RTLLIB_DL_MGMT, f, ## a)
-#define RTLLIB_DEBUG_QOS(f, a...)  RTLLIB_DEBUG(RTLLIB_DL_QOS, f, ## a)
 
 #ifndef ETH_P_PAE
 #define ETH_P_PAE 0x888E /* Port Access Entity (IEEE 802.1X) */
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index edd0a86..1efdace 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -1661,9 +1661,10 @@ static int rtllib_qos_convert_ac_to_parameters(struct rtllib_qos_parameter_info
  * parameters element. check the information element length to decide
  * which type to read
  */
-static int rtllib_parse_qos_info_param_IE(struct rtllib_info_element
+static int rtllib_parse_qos_info_param_IE(struct rtllib_device *ieee,
+					  struct rtllib_info_element
 					     *info_element,
-					     struct rtllib_network *network)
+					  struct rtllib_network *network)
 {
 	int rc = 0;
 	struct rtllib_qos_information_element qos_info_element;
@@ -1688,7 +1689,7 @@ static int rtllib_parse_qos_info_param_IE(struct rtllib_info_element
 	}
 
 	if (rc == 0) {
-		RTLLIB_DEBUG_QOS("QoS is supported\n");
+		netdev_dbg(ieee->dev, "QoS is supported\n");
 		network->qos_data.supported = 1;
 	}
 	return rc;
@@ -1765,7 +1766,7 @@ static void rtllib_parse_mife_generic(struct rtllib_device *ieee,
 	u16 ht_realtek_agg_len = 0;
 	u8  ht_realtek_agg_buf[MAX_IE_LEN];
 
-	if (!rtllib_parse_qos_info_param_IE(info_element, network))
+	if (!rtllib_parse_qos_info_param_IE(ieee, info_element, network))
 		return;
 
 	if (info_element->len >= 4 &&
@@ -2325,7 +2326,8 @@ static inline int is_same_network(struct rtllib_network *src,
 }
 
 
-static inline void update_network(struct rtllib_network *dst,
+static inline void update_network(struct rtllib_device *ieee,
+				  struct rtllib_network *dst,
 				  struct rtllib_network *src)
 {
 	int qos_active;
@@ -2399,12 +2401,12 @@ static inline void update_network(struct rtllib_network *dst,
 		       sizeof(struct rtllib_qos_data));
 	if (dst->qos_data.supported == 1) {
 		if (dst->ssid_len)
-			RTLLIB_DEBUG_QOS
-				("QoS the network %s is QoS supported\n",
-				dst->ssid);
+			netdev_dbg(ieee->dev,
+				   "QoS the network %s is QoS supported\n",
+				   dst->ssid);
 		else
-			RTLLIB_DEBUG_QOS
-				("QoS the network is QoS supported\n");
+			netdev_dbg(ieee->dev,
+				   "QoS the network is QoS supported\n");
 	}
 	dst->qos_data.active = qos_active;
 	dst->qos_data.old_param_count = old_param;
@@ -2540,7 +2542,7 @@ static inline void rtllib_process_probe_response(
 	spin_lock_irqsave(&ieee->lock, flags);
 	if (is_same_network(&ieee->current_network, network,
 	   (network->ssid_len ? 1 : 0))) {
-		update_network(&ieee->current_network, network);
+		update_network(ieee, &ieee->current_network, network);
 		if ((ieee->current_network.mode == IEEE_N_24G ||
 		     ieee->current_network.mode == IEEE_G)
 		     && ieee->current_network.berp_info_valid) {
@@ -2610,7 +2612,7 @@ static inline void rtllib_process_probe_response(
 		    network->ssid_len) == 0) &&
 		    (ieee->state == RTLLIB_NOLINK))))
 			renew = 1;
-		update_network(target, network);
+		update_network(ieee, target, network);
 		if (renew && (ieee->softmac_features & IEEE_SOFTMAC_ASSOCIATE))
 			rtllib_softmac_new_net(ieee, network);
 	}
-- 
1.8.4.1


  parent reply	other threads:[~2015-05-09 21:20 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 21:18 [PATCH v3 00/33] staging: rtl8192e: Fix more checkpatch.pl warnings Mateusz Kulikowski
2015-05-09 21:18 ` [PATCH v3 01/33] staging: rtl8192e: Declare ethernet addresses as __aligned(2) Mateusz Kulikowski
2015-05-09 22:29   ` Joe Perches
2015-05-12 19:44     ` Mateusz Kulikowski
2015-05-12 19:53       ` Joe Perches
2015-05-09 21:18 ` [PATCH v3 02/33] staging: rtl8192e: Fix PREFER_ETHER_ADDR_COPY warnings Mateusz Kulikowski
2015-05-10 13:19   ` Greg KH
2015-05-12 19:52     ` Mateusz Kulikowski
2015-05-12 21:19       ` Greg KH
2015-05-14 20:22         ` Mateusz Kulikowski
2015-05-09 21:18 ` [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy() Mateusz Kulikowski
2015-05-10 13:20   ` Greg KH
2015-05-12 20:05     ` Mateusz Kulikowski
2015-05-11  8:26   ` Dan Carpenter
2015-05-12 20:00     ` Mateusz Kulikowski
2015-05-13  8:22       ` Dan Carpenter
2015-05-14 20:29         ` Mateusz Kulikowski
2015-05-14 23:14           ` Dan Carpenter
2015-05-17 20:38             ` Mateusz Kulikowski
2015-05-18  9:09               ` Dan Carpenter
2015-05-09 21:18 ` [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param() Mateusz Kulikowski
2015-05-10  7:49   ` Sudip Mukherjee
2015-05-12 21:01     ` Mateusz Kulikowski
2015-05-13  4:45       ` Sudip Mukherjee
2015-05-13  8:26       ` Dan Carpenter
2015-05-11 13:48   ` Dan Carpenter
2015-05-12 20:46     ` Mateusz Kulikowski
2015-05-09 21:18 ` [PATCH v3 05/33] staging: rtl8192e: Replace memcmp() with ether_addr_equal_unaligned() Mateusz Kulikowski
2015-05-09 21:18 ` [PATCH v3 06/33] staging: rtl8192e: Remove rtllib_crypt.[ch] Mateusz Kulikowski
2015-05-09 21:18 ` [PATCH v3 07/33] staging: rtl8192e: Replace RTLLIB_DEBUG(DL_ERR) with netdev_*() Mateusz Kulikowski
2015-05-10  7:53   ` Sudip Mukherjee
2015-05-12 20:43     ` Mateusz Kulikowski
2015-05-09 21:18 ` [PATCH v3 08/33] staging: rtl8192e: Remove RTLLIB_ERROR() and RTLLIB_WARNING() Mateusz Kulikowski
2015-05-09 21:18 ` [PATCH v3 09/33] staging: rtl8192e: Remove RTLLIB_DEBUG_WX() Mateusz Kulikowski
2015-05-09 21:18 ` [PATCH v3 10/33] staging: rtl8192e: Simplify rtllib_proces_probe_response() Mateusz Kulikowski
2015-05-09 21:18 ` [PATCH v3 11/33] staging: rtl8192e: Remove RTLLIB_DEBUG_SCAN() Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 12/33] staging: rtl8192e: Remove RTLLIB_DEBUG_(FRAG|EAP|DROP|STATE|TX|RX)() Mateusz Kulikowski
2015-05-09 21:19 ` Mateusz Kulikowski [this message]
2015-05-09 21:19 ` [PATCH v3 14/33] staging: rtl8192e: Remove RTLLIB_DEBUG_MGMT() Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 15/33] staging: rtl8192e: Remove RTLLIB_DEBUG_INFO() Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 16/33] staging: rtl8192e: Remove RTLLIB_DEBUG() Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 17/33] staging: rtl8192e: Remove RTLLIB_DEBUG_DATA() Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 18/33] staging: rtl8192e: Remove remains of RTLLIB_*_DEBUG() (including proc entry) Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 19/33] staging: rtl8192e: Remove assert() macro Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 20/33] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings Mateusz Kulikowski
2015-05-09 22:37   ` Joe Perches
2015-05-12 20:20     ` Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 21/33] staging: rtl8192e: Fix LONG_LINE warnings Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 22/33] staging: rtl8192e: Fix LONG_LING in rtllib_parse_info_param() Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 23/33] staging: rtl8192e: Remove unimplemented iwpriv handlers Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 24/33] staging: rtl8192e: Fix OOM_MESSAGE warnings Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 25/33] staging: rtl8192e: Remove unused rtl_crypto.h Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 26/33] staging: rtl8192e: Replace ?: with max_t Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 27/33] staging: rtl8192e: Replace ?: with min_t Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 28/33] staging: rtl8192e: Replace ?: with max Mateusz Kulikowski
2015-05-11 13:22   ` Dan Carpenter
2015-05-12 20:08     ` Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 29/33] staging: rtl8192e: Remove unneeded RT_TRACE(COMP_ERR,...) Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 30/33] staging: rtl8192e: rtl8192_phy_checkBBAndRF(): Don't check MAC Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 31/33] staging: rtl8192e: Replace RT_TRACE(COMP_ERR, ...) with netdev_* Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 32/33] staging: rtl8192e: Fix trivial LONG_LINE errors Mateusz Kulikowski
2015-05-09 21:19 ` [PATCH v3 33/33] staging: rtl8192e: rtl8192E_suspend(): Fix WOL reporting Mateusz Kulikowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431206361-13736-14-git-send-email-mateusz.kulikowski@gmail.com \
    --to=mateusz.kulikowski@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®