mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>
Subject: [PATCH 5/3] perf report: Check attr.inherit_stat bit for --show-threads
Date: Mon, 11 May 2015 22:49:31 +0900	[thread overview]
Message-ID: <1431352171-1057-1-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <554E3221.1010804@gmail.com>

Check the evsel->attr.inherit_stat bit and show warning message if it's
missing and -T/--threads option was given:

  $ perf report -T
  Error: perf.data file has no per-thread stat data.
         Did you run 'perf record' with -s option?

Suggested-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-report.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 6ac2c7a01a63..ac2dc057cbc5 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -848,6 +848,19 @@ repeat:
 		      stdout);
 	}
 
+	if (report.show_threads) {
+		struct perf_evsel *evsel;
+
+		evlist__for_each(session->evlist, evsel) {
+			if (!evsel->attr.inherit_stat) {
+				pr_err("Error: %s file has no per-thread stat data.\n"
+				       "       Did you run 'perf record' with -s option?\n",
+					input_name);
+				goto error;
+			}
+		}
+	}
+
 	/*
 	 * Only in the TUI browser we are doing integrated annotation,
 	 * so don't allocate extra space that won't be used in the stdio
-- 
2.4.0


  reply	other threads:[~2015-05-11 13:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 15:19 [PATCH 1/3] perf tools: Document relation of per-thread event count feature Namhyung Kim
2015-05-09 15:19 ` [PATCH 2/3] perf report: Force tty output if -T/--thread option is given Namhyung Kim
2015-05-10 17:16   ` Arnaldo Carvalho de Melo
2015-05-11 13:46     ` [PATCH 4/3] perf report: Show error message for incompatible UI request Namhyung Kim
2015-05-11 14:03       ` Arnaldo Carvalho de Melo
2015-05-11 15:37         ` Namhyung Kim
2015-05-15  6:43   ` [tip:perf/core] perf report: Force tty output if -T/ --thread option is given tip-bot for Namhyung Kim
2015-05-09 15:19 ` [PATCH 3/3] perf report: Do not restrict -T option by other options Namhyung Kim
2015-05-10 17:20   ` Arnaldo Carvalho de Melo
2015-05-11 13:43     ` Namhyung Kim
2015-05-11 13:44     ` [PATCH v2 " Namhyung Kim
2015-05-11 14:08       ` Arnaldo Carvalho de Melo
2015-05-15  6:45       ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-05-09 16:13 ` [PATCH 1/3] perf tools: Document relation of per-thread event count feature David Ahern
2015-05-11 13:49   ` Namhyung Kim [this message]
2015-05-11 15:35     ` [PATCH v2 5/3] perf report: Check attr.inherit_stat bit for --show-threads Namhyung Kim
2015-05-15  6:43 ` [tip:perf/core] perf tools: Document relation of per-thread event count feature tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431352171-1057-1-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®