mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jolsa@redhat.com, dsahern@gmail.com, acme@redhat.com,
	tglx@linutronix.de, a.p.zijlstra@chello.nl, namhyung@kernel.org,
	mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: [tip:perf/core] perf report: Do not restrict -T option by other options
Date: Thu, 14 May 2015 23:45:03 -0700	[thread overview]
Message-ID: <tip-021162cf02fcfa80cbae5f3b7304e9cb392962eb@git.kernel.org> (raw)
In-Reply-To: <1431351879-23798-1-git-send-email-namhyung@kernel.org>

Commit-ID:  021162cf02fcfa80cbae5f3b7304e9cb392962eb
Gitweb:     http://git.kernel.org/tip/021162cf02fcfa80cbae5f3b7304e9cb392962eb
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Mon, 11 May 2015 22:44:39 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 12 May 2015 09:59:51 -0300

perf report: Do not restrict -T option by other options

It seems there's no reason to suppress per-thread event stat by -T
option when -s or -p option is used.  Make it work with those options.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1431351879-23798-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-report.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 4d642db..92fca21 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -333,15 +333,14 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist,
 	}
 
 	if (sort_order == NULL &&
-	    parent_pattern == default_parent_pattern) {
+	    parent_pattern == default_parent_pattern)
 		fprintf(stdout, "#\n# (%s)\n#\n", help);
 
-		if (rep->show_threads) {
-			bool style = !strcmp(rep->pretty_printing_style, "raw");
-			perf_read_values_display(stdout, &rep->show_threads_values,
-						 style);
-			perf_read_values_destroy(&rep->show_threads_values);
-		}
+	if (rep->show_threads) {
+		bool style = !strcmp(rep->pretty_printing_style, "raw");
+		perf_read_values_display(stdout, &rep->show_threads_values,
+					 style);
+		perf_read_values_destroy(&rep->show_threads_values);
 	}
 
 	return 0;

  parent reply	other threads:[~2015-05-15  6:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 15:19 [PATCH 1/3] perf tools: Document relation of per-thread event count feature Namhyung Kim
2015-05-09 15:19 ` [PATCH 2/3] perf report: Force tty output if -T/--thread option is given Namhyung Kim
2015-05-10 17:16   ` Arnaldo Carvalho de Melo
2015-05-11 13:46     ` [PATCH 4/3] perf report: Show error message for incompatible UI request Namhyung Kim
2015-05-11 14:03       ` Arnaldo Carvalho de Melo
2015-05-11 15:37         ` Namhyung Kim
2015-05-15  6:43   ` [tip:perf/core] perf report: Force tty output if -T/ --thread option is given tip-bot for Namhyung Kim
2015-05-09 15:19 ` [PATCH 3/3] perf report: Do not restrict -T option by other options Namhyung Kim
2015-05-10 17:20   ` Arnaldo Carvalho de Melo
2015-05-11 13:43     ` Namhyung Kim
2015-05-11 13:44     ` [PATCH v2 " Namhyung Kim
2015-05-11 14:08       ` Arnaldo Carvalho de Melo
2015-05-15  6:45       ` tip-bot for Namhyung Kim [this message]
2015-05-09 16:13 ` [PATCH 1/3] perf tools: Document relation of per-thread event count feature David Ahern
2015-05-11 13:49   ` [PATCH 5/3] perf report: Check attr.inherit_stat bit for --show-threads Namhyung Kim
2015-05-11 15:35     ` [PATCH v2 " Namhyung Kim
2015-05-15  6:43 ` [tip:perf/core] perf tools: Document relation of per-thread event count feature tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-021162cf02fcfa80cbae5f3b7304e9cb392962eb@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome