mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: <linux-kernel@vger.kernel.org>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Tejun Heo <tj@kernel.org>
Subject: [PATCH 0/7 V2] workqueue: cleanup for attr management
Date: Tue, 12 May 2015 20:32:28 +0800	[thread overview]
Message-ID: <1431433955-3173-1-git-send-email-laijs@cn.fujitsu.com> (raw)

Hi,

This is the V2 version of the V1 pathset.  But it is just the updated
version of the patch1&2 of the V1 patchset.

[1/5 V1] is split into [1/7 V2] and [2/7 V2].
[2/5 V1] is split into [3,4,5,6,7/7 V2].

[1/7] extends the wq_pool_mutex lock region in the apply_workqueue_attrs().
	It is a basic patch for all the later patches except the [6/7 V2].
[2/7] simplifies wq_update_unbound_numa() since lock requirement is eased.

[3/7] introduces get_pwq_unlocked() for reusing existing pwqs
	It is also a basic patch for all the later patches except the [6/7 V2].
[4,5,6/7] apply the good code of wq_update_unbound_numa() to
	     apply_workqueue_attrs(): reuse the unchanged per-node/default pwq
	     and reuse the preallocated wq_update_unbound_numa_attrs_buf.

[2,3,4,5,6/7] try to make the per-node allocation are the same in
	wq_update_unbound_numa() and apply_workqueue_attrs(), but they
	are not exactly the same. wq_update_unbound_numa() directly returns
	when the pwq unchanged.

[7/7] adds get_node_unbound_pwq() which uses the per-node allocation
	behavior of the apply_workqueue_attrs().  So wq_update_unbound_numa()
	has some overhead introduced.  But cpu-hotplug path is cold path,
	it is Ok.

	It removes some comments without adding the corresponding ones back.

Other changed from V1:
	The unneeded comment about the stableness of the wq->unbound_attrs
	is removed in [2/7].

	alloc_node_unbound_pwq() is renamed to get_node_unbound_pwq().
	@use_dfl_when_fail is removed from get_node_unbound_pwq().
	get_node_unbound_pwq() is shorter under the help of get_pwq_unlocked().

	apply_wqattrs_cleanup() is not protected by wq_pool_mutex

	some comment revised as TJ's suguested.

Thanks,
Lai

Cc: Tejun Heo <tj@kernel.org>

Lai Jiangshan (7):
  workqueue: wq_pool_mutex protects the attrs-installation
  workqueue: simplify wq_update_unbound_numa()
  workqueue: introduce get_pwq_unlocked()
  workqueue: reuse the current per-node pwq when its attrs unchanged
  workqueue: reuse the current default pwq when its attrs unchanged
  workqueue: reuse wq_update_unbound_numa_attrs_buf as temporary attrs
  workqueue: add get_node_unbound_pwq()

 kernel/workqueue.c | 197 ++++++++++++++++++++++++++---------------------------
 1 file changed, 95 insertions(+), 102 deletions(-)

-- 
2.1.0
ge

             reply	other threads:[~2015-05-12 12:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 12:32 Lai Jiangshan [this message]
2015-05-12 12:32 ` [PATCH 1/7 V2] workqueue: wq_pool_mutex protects the attrs-installation Lai Jiangshan
2015-05-12 12:32 ` [PATCH 2/7 V2] workqueue: simplify wq_update_unbound_numa() Lai Jiangshan
2015-05-18 20:21   ` Tejun Heo
2015-05-12 12:32 ` [PATCH 3/7 V2] workqueue: introduce get_pwq_unlocked() Lai Jiangshan
2015-05-18 20:28   ` Tejun Heo
2015-05-18 20:41   ` Tejun Heo
2015-05-12 12:32 ` [PATCH 4/7 V2] workqueue: reuse the current per-node pwq when its attrs unchanged Lai Jiangshan
2015-05-18 20:34   ` Tejun Heo
2015-05-25  9:47   ` Lai Jiangshan
2015-05-26 18:51     ` Tejun Heo
2015-05-12 12:32 ` [PATCH 5/7 V2] workqueue: reuse the current default " Lai Jiangshan
2015-05-18 20:38   ` Tejun Heo
2015-05-12 12:32 ` [PATCH 6/7 V2] workqueue: reuse wq_update_unbound_numa_attrs_buf as temporary attrs Lai Jiangshan
2015-05-12 12:32 ` [PATCH 7/7 V2] workqueue: add get_node_unbound_pwq() Lai Jiangshan
2015-05-18  0:39 ` [PATCH 0/7 V2] workqueue: cleanup for attr management Lai Jiangshan
2015-05-18  1:26   ` Tejun Heo
2015-05-18  2:06     ` Lai Jiangshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431433955-3173-1-git-send-email-laijs@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®