mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
	josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
	rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
	dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com,
	bobby.prani@gmail.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 20/24] rcu: Make RCU able to tolerate undefined CONFIG_RCU_FANOUT
Date: Tue, 12 May 2015 15:30:50 -0700	[thread overview]
Message-ID: <1431469854-3826-20-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1431469854-3826-1-git-send-email-paulmck@linux.vnet.ibm.com>

From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>

This commit introduces an RCU_FANOUT C-preprocessor macro so that RCU will
build even when CONFIG_RCU_FANOUT is undefined.  The RCU_FANOUT macro is
set to the value of CONFIG_RCU_FANOUT when defined, otherwise it is set
to 32 for 32-bit systems and 64 for 64-bit systems.  This commit then
makes CONFIG_RCU_FANOUT depend on CONFIG_RCU_EXPERT, so that Kconfig
users won't be asked about CONFIG_RCU_FANOUT unless they want to be.

Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Pranith Kumar <bobby.prani@gmail.com>
---
 init/Kconfig             |  2 +-
 kernel/rcu/tree.c        |  4 ++--
 kernel/rcu/tree.h        | 17 ++++++++++++++---
 kernel/rcu/tree_plugin.h |  6 +++---
 4 files changed, 20 insertions(+), 9 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index ac5386937d37..fd2d4fb517ca 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -583,7 +583,7 @@ config RCU_FANOUT
 	int "Tree-based hierarchical RCU fanout value"
 	range 2 64 if 64BIT
 	range 2 32 if !64BIT
-	depends on TREE_RCU || PREEMPT_RCU
+	depends on (TREE_RCU || PREEMPT_RCU) && RCU_EXPERT
 	default 64 if 64BIT
 	default 32 if !64BIT
 	help
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 01719402fe8e..4b27a7c0926f 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3966,7 +3966,7 @@ static void __init rcu_init_levelspread(int *levelspread, const int *levelcnt)
 	if (rcu_fanout_exact) {
 		levelspread[rcu_num_lvls - 1] = rcu_fanout_leaf;
 		for (i = rcu_num_lvls - 2; i >= 0; i--)
-			levelspread[i] = CONFIG_RCU_FANOUT;
+			levelspread[i] = RCU_FANOUT;
 	} else {
 		int ccur;
 		int cprv;
@@ -4097,7 +4097,7 @@ static void __init rcu_init_geometry(void)
 	 */
 	rcu_capacity[0] = rcu_fanout_leaf;
 	for (i = 1; i < RCU_NUM_LVLS; i++)
-		rcu_capacity[i] = rcu_capacity[i - 1] * CONFIG_RCU_FANOUT;
+		rcu_capacity[i] = rcu_capacity[i - 1] * RCU_FANOUT;
 
 	/*
 	 * The tree must be able to accommodate the configured number of CPUs.
diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index 5f294267ed20..7ca17b646428 100644
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -35,10 +35,21 @@
  * In practice, this did work well going from three levels to four.
  * Of course, your mileage may vary.
  */
+
+#ifdef CONFIG_RCU_FANOUT
+#define RCU_FANOUT CONFIG_RCU_FANOUT
+#else /* #ifdef CONFIG_RCU_FANOUT */
+# ifdef CONFIG_64BIT
+# define RCU_FANOUT 64
+# else
+# define RCU_FANOUT 32
+# endif
+#endif /* #else #ifdef CONFIG_RCU_FANOUT */
+
 #define RCU_FANOUT_1	      (CONFIG_RCU_FANOUT_LEAF)
-#define RCU_FANOUT_2	      (RCU_FANOUT_1 * CONFIG_RCU_FANOUT)
-#define RCU_FANOUT_3	      (RCU_FANOUT_2 * CONFIG_RCU_FANOUT)
-#define RCU_FANOUT_4	      (RCU_FANOUT_3 * CONFIG_RCU_FANOUT)
+#define RCU_FANOUT_2	      (RCU_FANOUT_1 * RCU_FANOUT)
+#define RCU_FANOUT_3	      (RCU_FANOUT_2 * RCU_FANOUT)
+#define RCU_FANOUT_4	      (RCU_FANOUT_3 * RCU_FANOUT)
 
 #if NR_CPUS <= RCU_FANOUT_1
 #  define RCU_NUM_LVLS	      1
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 3eb1cda880c8..ca0f54cbba0e 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -60,10 +60,10 @@ static void __init rcu_bootup_announce_oddness(void)
 {
 	if (IS_ENABLED(CONFIG_RCU_TRACE))
 		pr_info("\tRCU debugfs-based tracing is enabled.\n");
-	if ((IS_ENABLED(CONFIG_64BIT) && CONFIG_RCU_FANOUT != 64) ||
-	    (!IS_ENABLED(CONFIG_64BIT) && CONFIG_RCU_FANOUT != 32))
+	if ((IS_ENABLED(CONFIG_64BIT) && RCU_FANOUT != 64) ||
+	    (!IS_ENABLED(CONFIG_64BIT) && RCU_FANOUT != 32))
 		pr_info("\tCONFIG_RCU_FANOUT set to non-default value of %d\n",
-		       CONFIG_RCU_FANOUT);
+		       RCU_FANOUT);
 	if (rcu_fanout_exact)
 		pr_info("\tHierarchical RCU autobalancing is disabled.\n");
 	if (IS_ENABLED(CONFIG_RCU_FAST_NO_HZ))
-- 
1.8.1.5


  parent reply	other threads:[~2015-05-12 22:33 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 22:30 [PATCH tip/core/rcu 0/24] Initialization/Kconfig updates for 4.2 Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 01/24] rcu: Control grace-period delays directly from value Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 02/24] rcu: Modulate grace-period slow init to normalize delay Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 03/24] rcu: Shut up spurious gcc uninitialized-variable warning Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 04/24] rcu: Panic if RCU tree can not accommodate all CPUs Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 05/24] rcu: Remove superfluous local variable in rcu_init_geometry() Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 06/24] rcu: Cleanup rcu_init_geometry() code and arithmetics Paul E. McKenney
2015-05-13  3:22     ` Steven Rostedt
2015-05-13 13:20       ` Paul E. McKenney
2015-05-14 21:15       ` Alexander Gordeev
2015-05-12 22:30   ` [PATCH tip/core/rcu 07/24] rcu: Simplify rcu_init_geometry() capacity arithmetics Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 08/24] rcu: Limit rcu_state::levelcnt[] to RCU_NUM_LVLS items Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 09/24] rcu: Limit rcu_capacity[] size " Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 10/24] rcu: Remove unnecessary fields from rcu_state structure Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 11/24] rcu: Limit count of static data to the number of RCU levels Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 12/24] rcu: Simplify arithmetic to calculate number of RCU nodes Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 13/24] rcu: Provide diagnostic option to slow down grace-period scans Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 14/24] rcu: Directly drive TASKS_RCU from Kconfig Paul E. McKenney
2015-05-13 13:31     ` Steven Rostedt
2015-05-13 17:14       ` Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 15/24] rcu: Directly drive RCU_USER_QS " Paul E. McKenney
2015-05-13  0:37     ` Frederic Weisbecker
2015-05-13 17:45       ` Paul E. McKenney
2015-05-14  0:27         ` Frederic Weisbecker
2015-05-14 21:12           ` Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 16/24] rcu: Convert CONFIG_RCU_FANOUT_EXACT to boot parameter Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 17/24] rcu: Enable diagnostic dump of rcu_node combining tree Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 18/24] rcu: Create RCU_EXPERT Kconfig and hide booleans behind it Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 19/24] rcu: Break dependency of RCU_FANOUT_LEAF on RCU_FANOUT Paul E. McKenney
2015-05-12 22:30   ` Paul E. McKenney [this message]
2015-05-12 22:30   ` [PATCH tip/core/rcu 21/24] rcu: Make RCU able to tolerate undefined CONFIG_RCU_FANOUT_LEAF Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 22/24] rcu: Make RCU able to tolerate undefined CONFIG_RCU_KTHREAD_PRIO Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 23/24] rcu: Remove prompt for RCU implementation Paul E. McKenney
2015-05-12 22:30   ` [PATCH tip/core/rcu 24/24] rcu: Conditionally compile RCU's eqs warnings Paul E. McKenney
2015-05-13 13:46     ` Steven Rostedt
2015-05-13 15:06       ` Paul E. McKenney
2015-06-29  9:39     ` Geert Uytterhoeven
2015-06-29 20:55       ` Paul E. McKenney
2015-06-29 20:58         ` Geert Uytterhoeven
2015-06-30 16:57           ` Paul E. McKenney
2015-05-13  2:59   ` [PATCH tip/core/rcu 01/24] rcu: Control grace-period delays directly from value Steven Rostedt
2015-05-13 17:15     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431469854-3826-20-git-send-email-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=bobby.prani@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dvhart@linux.intel.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome