From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com,
bobby.prani@gmail.com, Alexander Gordeev <agordeev@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 05/24] rcu: Remove superfluous local variable in rcu_init_geometry()
Date: Tue, 12 May 2015 15:30:35 -0700 [thread overview]
Message-ID: <1431469854-3826-5-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1431469854-3826-1-git-send-email-paulmck@linux.vnet.ibm.com>
From: Alexander Gordeev <agordeev@redhat.com>
Local variable 'n' mimics 'nr_cpu_ids' while the both are
used within one function. There is no reason for 'n' to
exist whatsoever.
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
kernel/rcu/tree.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index f374f2caaf25..99431ca4d395 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -4053,7 +4053,6 @@ static void __init rcu_init_geometry(void)
ulong d;
int i;
int j;
- int n = nr_cpu_ids;
int rcu_capacity[MAX_RCU_LVLS + 1];
/*
@@ -4096,7 +4095,7 @@ static void __init rcu_init_geometry(void)
* the rcu_node masks. Complain and fall back to the compile-
* time values if these limits are exceeded.
*/
- if (n > rcu_capacity[MAX_RCU_LVLS])
+ if (nr_cpu_ids > rcu_capacity[MAX_RCU_LVLS])
panic("rcu_init_geometry: rcu_capacity[] is too small");
else if (rcu_fanout_leaf < CONFIG_RCU_FANOUT_LEAF ||
rcu_fanout_leaf > sizeof(unsigned long) * 8) {
@@ -4106,10 +4105,11 @@ static void __init rcu_init_geometry(void)
/* Calculate the number of rcu_nodes at each level of the tree. */
for (i = 1; i <= MAX_RCU_LVLS; i++)
- if (n <= rcu_capacity[i]) {
- for (j = 0; j <= i; j++)
- num_rcu_lvl[j] =
- DIV_ROUND_UP(n, rcu_capacity[i - j]);
+ if (nr_cpu_ids <= rcu_capacity[i]) {
+ for (j = 0; j <= i; j++) {
+ int cap = rcu_capacity[i - j];
+ num_rcu_lvl[j] = DIV_ROUND_UP(nr_cpu_ids, cap);
+ }
rcu_num_lvls = i;
for (j = i + 1; j <= MAX_RCU_LVLS; j++)
num_rcu_lvl[j] = 0;
@@ -4120,7 +4120,7 @@ static void __init rcu_init_geometry(void)
rcu_num_nodes = 0;
for (i = 0; i <= MAX_RCU_LVLS; i++)
rcu_num_nodes += num_rcu_lvl[i];
- rcu_num_nodes -= n;
+ rcu_num_nodes -= nr_cpu_ids;
}
void __init rcu_init(void)
--
1.8.1.5
next prev parent reply other threads:[~2015-05-12 22:31 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 22:30 [PATCH tip/core/rcu 0/24] Initialization/Kconfig updates for 4.2 Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 01/24] rcu: Control grace-period delays directly from value Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 02/24] rcu: Modulate grace-period slow init to normalize delay Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 03/24] rcu: Shut up spurious gcc uninitialized-variable warning Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 04/24] rcu: Panic if RCU tree can not accommodate all CPUs Paul E. McKenney
2015-05-12 22:30 ` Paul E. McKenney [this message]
2015-05-12 22:30 ` [PATCH tip/core/rcu 06/24] rcu: Cleanup rcu_init_geometry() code and arithmetics Paul E. McKenney
2015-05-13 3:22 ` Steven Rostedt
2015-05-13 13:20 ` Paul E. McKenney
2015-05-14 21:15 ` Alexander Gordeev
2015-05-12 22:30 ` [PATCH tip/core/rcu 07/24] rcu: Simplify rcu_init_geometry() capacity arithmetics Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 08/24] rcu: Limit rcu_state::levelcnt[] to RCU_NUM_LVLS items Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 09/24] rcu: Limit rcu_capacity[] size " Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 10/24] rcu: Remove unnecessary fields from rcu_state structure Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 11/24] rcu: Limit count of static data to the number of RCU levels Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 12/24] rcu: Simplify arithmetic to calculate number of RCU nodes Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 13/24] rcu: Provide diagnostic option to slow down grace-period scans Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 14/24] rcu: Directly drive TASKS_RCU from Kconfig Paul E. McKenney
2015-05-13 13:31 ` Steven Rostedt
2015-05-13 17:14 ` Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 15/24] rcu: Directly drive RCU_USER_QS " Paul E. McKenney
2015-05-13 0:37 ` Frederic Weisbecker
2015-05-13 17:45 ` Paul E. McKenney
2015-05-14 0:27 ` Frederic Weisbecker
2015-05-14 21:12 ` Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 16/24] rcu: Convert CONFIG_RCU_FANOUT_EXACT to boot parameter Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 17/24] rcu: Enable diagnostic dump of rcu_node combining tree Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 18/24] rcu: Create RCU_EXPERT Kconfig and hide booleans behind it Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 19/24] rcu: Break dependency of RCU_FANOUT_LEAF on RCU_FANOUT Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 20/24] rcu: Make RCU able to tolerate undefined CONFIG_RCU_FANOUT Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 21/24] rcu: Make RCU able to tolerate undefined CONFIG_RCU_FANOUT_LEAF Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 22/24] rcu: Make RCU able to tolerate undefined CONFIG_RCU_KTHREAD_PRIO Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 23/24] rcu: Remove prompt for RCU implementation Paul E. McKenney
2015-05-12 22:30 ` [PATCH tip/core/rcu 24/24] rcu: Conditionally compile RCU's eqs warnings Paul E. McKenney
2015-05-13 13:46 ` Steven Rostedt
2015-05-13 15:06 ` Paul E. McKenney
2015-06-29 9:39 ` Geert Uytterhoeven
2015-06-29 20:55 ` Paul E. McKenney
2015-06-29 20:58 ` Geert Uytterhoeven
2015-06-30 16:57 ` Paul E. McKenney
2015-05-13 2:59 ` [PATCH tip/core/rcu 01/24] rcu: Control grace-period delays directly from value Steven Rostedt
2015-05-13 17:15 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431469854-3826-5-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=agordeev@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome