From: Joe Perches <joe@perches.com>
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-kernel@vger.kernel.org, Paul Bolle <pebolle@tiscali.nl>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCHiv5 1/1] RTC:driver for Cortina's SOC
Date: Fri, 15 May 2015 08:58:24 -0700 [thread overview]
Message-ID: <1431705504.15709.8.camel@perches.com> (raw)
In-Reply-To: <1431703736-18162-2-git-send-email-ulli.kroll@googlemail.com>
On Fri, 2015-05-15 at 17:28 +0200, Hans Ulli Kroll wrote:
> Driver for the on chip RTC found on Cortina's SoC Gemini.
Trivia:
> diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c
[]
> +static int gemini_rtc_probe(struct platform_device *pdev)
> +{
> + struct gemini_rtc *rtc;
> + struct device *dev = &pdev->dev;
> + struct resource *res;
> + int ret;
> +
> + rtc = kzalloc(sizeof(*rtc), GFP_KERNEL);
this could/should be devm_kzalloc
prev parent reply other threads:[~2015-05-15 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 15:28 [PATCHv5] " Hans Ulli Kroll
2015-05-15 15:28 ` [PATCHiv5 1/1] " Hans Ulli Kroll
2015-05-15 15:58 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431705504.15709.8.camel@perches.com \
--to=joe@perches.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome