* [PATCH] staging: unisys: remove braces from single statement blocks
@ 2015-05-17 22:46 Isaac Assegai
2015-05-24 20:32 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Isaac Assegai @ 2015-05-17 22:46 UTC (permalink / raw)
To: gregkh; +Cc: sparmaintainer, devel, linux-kernel, Isaac Assegai
Remove the braces to satisfy this checkpatch warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
---
drivers/staging/unisys/virthba/virthba.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virthba/virthba.c
index d9001cc..9892c63 100644
--- a/drivers/staging/unisys/virthba/virthba.c
+++ b/drivers/staging/unisys/virthba/virthba.c
@@ -868,9 +868,8 @@ virthba_queue_command_lck(struct scsi_cmnd *scsicmd,
/* The following code does NOT make that assumption. */
/* convert buffer to phys information */
if (scsi_sg_count(scsicmd) == 0) {
- if (scsi_bufflen(scsicmd) > 0) {
+ if (scsi_bufflen(scsicmd) > 0)
BUG_ON(scsi_sg_count(scsicmd) == 0);
- }
} else {
/* buffer is scatterlist - copy it out */
sgl = scsi_sglist(scsicmd);
@@ -1068,9 +1067,8 @@ do_scsi_nolinuxstat(struct uiscmdrsp *cmdrsp, struct scsi_cmnd *scsicmd)
if (atomic_read(&vdisk->ios_threshold) > 0) {
atomic_dec(&vdisk->ios_threshold);
- if (atomic_read(&vdisk->ios_threshold) == 0) {
+ if (atomic_read(&vdisk->ios_threshold) == 0)
atomic_set(&vdisk->error_count, 0);
- }
}
}
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: unisys: remove braces from single statement blocks
2015-05-17 22:46 [PATCH] staging: unisys: remove braces from single statement blocks Isaac Assegai
@ 2015-05-24 20:32 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-05-24 20:32 UTC (permalink / raw)
To: Isaac Assegai; +Cc: sparmaintainer, devel, linux-kernel
On Sun, May 17, 2015 at 03:46:36PM -0700, Isaac Assegai wrote:
> Remove the braces to satisfy this checkpatch warning:
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
> ---
> drivers/staging/unisys/virthba/virthba.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Doesn't apply to my tree :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-24 20:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-17 22:46 [PATCH] staging: unisys: remove braces from single statement blocks Isaac Assegai
2015-05-24 20:32 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome