mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
	dan.carpenter@oracle.com, joe@perches.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 04/35] staging: rtl8192e: Mark unaligned memcpy()
Date: Thu, 21 May 2015 17:53:17 +0200	[thread overview]
Message-ID: <1432223628-1664-5-git-send-email-mateusz.kulikowski@gmail.com> (raw)
In-Reply-To: <1432223628-1664-1-git-send-email-mateusz.kulikowski@gmail.com>

Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
checkpatch.pl warning.
It will prevent accidential "Fix" to ether_addr_copy().

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index ebb328d..65e4d13 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -488,15 +488,19 @@ void rtllib_indicate_packets(struct rtllib_device *ieee, struct rtllib_rxb **prx
 				 * and replace EtherType
 				 */
 				skb_pull(sub_skb, SNAP_SIZE);
-				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, ETH_ALEN);
-				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, ETH_ALEN);
+				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src,
+				       ETH_ALEN); /* Must be unaligned */
+				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst,
+				       ETH_ALEN); /* Must be unaligned */
 			} else {
 				u16 len;
 			/* Leave Ethernet header part of hdr and full payload */
 				len = sub_skb->len;
 				memcpy(skb_push(sub_skb, 2), &len, 2);
-				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, ETH_ALEN);
-				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, ETH_ALEN);
+				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src,
+				       ETH_ALEN); /* Must be unaligned */
+				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst,
+				       ETH_ALEN); /* Must be unaligned */
 			}
 
 			/* Indicate the packets to upper layer */
@@ -781,15 +785,15 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
 
 		rxb->subframes[0] = sub_skb;
 
-		memcpy(rxb->src, src, ETH_ALEN);
-		memcpy(rxb->dst, dst, ETH_ALEN);
+		memcpy(rxb->src, src, ETH_ALEN); /* Must stay unaligned */
+		memcpy(rxb->dst, dst, ETH_ALEN); /* Must stay unaligned */
 		rxb->subframes[0]->dev = ieee->dev;
 		return 1;
 	}
 
 	rxb->nr_subframes = 0;
-	memcpy(rxb->src, src, ETH_ALEN);
-	memcpy(rxb->dst, dst, ETH_ALEN);
+	memcpy(rxb->src, src, ETH_ALEN); /* Must stay unaligned */
+	memcpy(rxb->dst, dst, ETH_ALEN); /* Must stay unaligned */
 	while (skb->len > ETHERNET_HEADER_SIZE) {
 		/* Offset 12 denote 2 mac address */
 		nSubframe_Length = *((u16 *)(skb->data + 12));
-- 
1.8.4.1


  parent reply	other threads:[~2015-05-21 16:05 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 15:53 [PATCH v4 00/35] staging: rtl8192e: Fix more checkpatch.pl warnings Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 01/35] staging: rtl8192e: accept const MAC address Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 02/35] staging: rtl8192e: Declare ethernet addresses as __aligned(2) Mateusz Kulikowski
2015-05-25 13:53   ` Dan Carpenter
2015-05-26 20:25     ` Mateusz Kulikowski
2015-05-26 21:04       ` Joe Perches
2015-05-27  0:22       ` Dan Carpenter
2015-05-21 15:53 ` [PATCH v4 03/35] staging: rtl8192e: Fix PREFER_ETHER_ADDR_COPY warnings Mateusz Kulikowski
2015-05-21 15:53 ` Mateusz Kulikowski [this message]
2015-05-25 13:55   ` [PATCH v4 04/35] staging: rtl8192e: Mark unaligned memcpy() Dan Carpenter
2015-05-21 15:53 ` [PATCH v4 05/35] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 06/35] staging: rtl8192e: Replace memcmp() with ether_addr_equal_unaligned() Mateusz Kulikowski
2015-05-25 14:03   ` Dan Carpenter
2015-05-25 17:37     ` Joe Perches
2015-05-26 19:55       ` Mateusz Kulikowski
2015-05-26 19:24     ` Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 07/35] staging: rtl8192e: Remove rtllib_crypt.[ch] Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 08/35] staging: rtl8192e: Replace RTLLIB_DEBUG(DL_ERR) with netdev_*() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 09/35] staging: rtl8192e: Remove RTLLIB_ERROR() and RTLLIB_WARNING() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 10/35] staging: rtl8192e: Remove RTLLIB_DEBUG_WX() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 11/35] staging: rtl8192e: Simplify rtllib_process_probe_response() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 12/35] staging: rtl8192e: Remove RTLLIB_DEBUG_SCAN() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 13/35] staging: rtl8192e: Remove RTLLIB_DEBUG_(FRAG|EAP|DROP|STATE|TX|RX)() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 14/35] staging: rtl8192e: Remove RTLLIB_DEBUG_QOS() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 15/35] staging: rtl8192e: Remove RTLLIB_DEBUG_MGMT() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 16/35] staging: rtl8192e: Remove RTLLIB_DEBUG_INFO() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 17/35] staging: rtl8192e: Remove RTLLIB_DEBUG() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 18/35] staging: rtl8192e: Remove RTLLIB_DEBUG_DATA() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 19/35] staging: rtl8192e: Remove remains of RTLLIB_*_DEBUG() (including proc entry) Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 20/35] staging: rtl8192e: Remove assert() macro Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 21/35] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 22/35] staging: rtl8192e: Fix LONG_LINE warnings Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 23/35] staging: rtl8192e: Fix LONG_LING in rtllib_parse_info_param() Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 24/35] staging: rtl8192e: Remove unimplemented iwpriv handlers Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 25/35] staging: rtl8192e: Fix OOM_MESSAGE warnings Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 26/35] staging: rtl8192e: Remove unused rtl_crypto.h Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 27/35] staging: rtl8192e: Replace ?: with max_t Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 28/35] staging: rtl8192e: Replace ?: with min_t Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 29/35] staging: rtl8192e: Replace ?: with max Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 30/35] staging: rtl8192e: Remove unneeded RT_TRACE(COMP_ERR,...) Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 31/35] staging: rtl8192e: rtl8192_phy_checkBBAndRF(): Don't check MAC Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 32/35] staging: rtl8192e: Replace RT_TRACE(COMP_ERR, ...) with netdev_* Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 33/35] staging: rtl8192e: Fix trivial LONG_LINE errors Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 34/35] staging: rtl8192e: rtl8192E_suspend(): Fix WOL reporting Mateusz Kulikowski
2015-05-21 15:53 ` [PATCH v4 35/35] staging: rtl8192e: Fix SPACING error Mateusz Kulikowski
2015-05-31  3:03 ` [PATCH v4 00/35] staging: rtl8192e: Fix more checkpatch.pl warnings Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432223628-1664-5-git-send-email-mateusz.kulikowski@gmail.com \
    --to=mateusz.kulikowski@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®