From: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
To: <linux-kernel@vger.kernel.org>, <linux-mips@linux-mips.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
<devicetree@vger.kernel.org>
Cc: Andrew Bresticker <abrestic@chromium.org>,
James Hartley <james.hartley@imgtec.com>,
James Hogan <james.hogan@imgtec.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
<Damien.Horsley@imgtec.com>, <Govindraj.Raja@imgtec.com>,
Ezequiel Garcia <ezequiel.garcia@imgtec.com>
Subject: [PATCH 1/7] clocksource: mips-gic: Enable the clock before using it
Date: Thu, 21 May 2015 18:37:34 -0300 [thread overview]
Message-ID: <1432244260-14908-2-git-send-email-ezequiel.garcia@imgtec.com> (raw)
In-Reply-To: <1432244260-14908-1-git-send-email-ezequiel.garcia@imgtec.com>
For the clock to be used (e.g. get its rate through clk_get_rate)
it should be prepared and enabled first.
Also, while the clock is enabled the driver must hold a reference to it,
so let's remove the call to clk_put.
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
---
drivers/clocksource/mips-gic-timer.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c
index b81ed1a..913585d 100644
--- a/drivers/clocksource/mips-gic-timer.c
+++ b/drivers/clocksource/mips-gic-timer.c
@@ -158,8 +158,13 @@ static void __init gic_clocksource_of_init(struct device_node *node)
clk = of_clk_get(node, 0);
if (!IS_ERR(clk)) {
+ if (clk_prepare_enable(clk) < 0) {
+ pr_err("GIC failed to enable clock\n");
+ clk_put(clk);
+ return;
+ }
+
gic_frequency = clk_get_rate(clk);
- clk_put(clk);
} else if (of_property_read_u32(node, "clock-frequency",
&gic_frequency)) {
pr_err("GIC frequency not specified.\n");
--
2.3.3
next prev parent reply other threads:[~2015-05-21 21:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 21:37 [PATCH 0/7] Clocksource changes for Pistachio CPUFreq Ezequiel Garcia
2015-05-21 21:37 ` Ezequiel Garcia [this message]
2015-05-21 22:17 ` [PATCH 1/7] clocksource: mips-gic: Enable the clock before using it Andrew Bresticker
2015-05-21 21:37 ` [PATCH 2/7] clocksource: mips-gic: Add missing error returns checks Ezequiel Garcia
2015-05-21 22:18 ` Andrew Bresticker
2015-05-21 21:37 ` [PATCH 3/7] clocksource: mips-gic: Split clocksource and clockevent initialization Ezequiel Garcia
2015-05-21 22:24 ` Andrew Bresticker
2015-05-21 22:25 ` Ezequiel Garcia
2015-05-22 16:53 ` Andrew Bresticker
2015-05-21 21:37 ` [PATCH 4/7] clocksource: mips-gic: Update clockevent frequency on clock rate changes Ezequiel Garcia
2015-05-21 22:32 ` Andrew Bresticker
2015-05-21 22:30 ` Ezequiel Garcia
2015-05-21 21:41 ` [PATCH 5/7] clocksource: Add Pistachio SoC general purpose timer binding document Ezequiel Garcia
2015-05-21 23:41 ` Andrew Bresticker
2015-05-21 21:41 ` [PATCH 6/7] clocksource: Add Pistachio clocksource-only driver Ezequiel Garcia
2015-05-21 22:00 ` Thomas Gleixner
2015-05-21 22:02 ` Ezequiel Garcia
2015-05-21 22:09 ` Thomas Gleixner
2015-05-22 16:48 ` Andrew Bresticker
2015-05-26 14:16 ` Ezequiel Garcia
2015-05-21 21:43 ` [PATCH 7/7] mips: pistachio: Allow to enable the external timer based clocksource Ezequiel Garcia
2015-05-22 16:50 ` Andrew Bresticker
2015-05-22 16:58 ` James Hartley
2015-05-22 18:08 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432244260-14908-2-git-send-email-ezequiel.garcia@imgtec.com \
--to=ezequiel.garcia@imgtec.com \
--cc=Damien.Horsley@imgtec.com \
--cc=Govindraj.Raja@imgtec.com \
--cc=abrestic@chromium.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.hartley@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®