From: He Kuang <hekuang@huawei.com>
To: <wangnan0@huawei.com>, <paulus@samba.org>,
<a.p.zijlstra@chello.nl>, <mingo@redhat.com>, <acme@kernel.org>,
<namhyung@kernel.org>, <jolsa@kernel.org>, <ast@plumgrid.com>,
<masami.hiramatsu.pt@hitachi.com>, <dsahern@gmail.com>,
<brendan.d.gregg@gmail.com>, <daniel@iogearbox.net>
Cc: <lizefan@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: [RFC PATCH v2 11/15] perf bpf: Synthesize vars to generate bpf prologue
Date: Sun, 24 May 2015 08:28:07 +0000 [thread overview]
Message-ID: <1432456091-73384-12-git-send-email-hekuang@huawei.com> (raw)
In-Reply-To: <1432456091-73384-1-git-send-email-hekuang@huawei.com>
After gethered all vars represented in trace_probe_arg, we can now use
functions in libbpf to generate the args prologue.
Signed-off-by: He Kuang <hekuang@huawei.com>
---
tools/perf/util/probe-finder.c | 83 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 81 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 6785eab..455ff0f 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -1242,6 +1242,67 @@ end:
return ret;
}
+/*
+ * Convert args to bpf prologue
+ * 1) First pass for calculating the new program length:
+ * synthesize_probe_bpf(arg, nargs, NULL, &new_len);
+ *
+ * 2) 2nd pass do the actually convert
+ * new_prog = malloc(sizeof(struct bpf_insn) * new_len);
+ * synthesize_probe_bpf(arg, nargs, new_prog, &new_len);
+ */
+static int synthesize_probe_bpf(struct probe_trace_arg *arg,
+ int nargs,
+ char *new_prog,
+ int *new_len)
+{
+ int i;
+ char *new_insn = new_prog;
+
+ if (nargs == 0) {
+ *new_len = 0;
+ return 0;
+ }
+
+ new_insn += bpf_prologue_begin(new_prog);
+ /* Find each argument */
+ for (i = 0; i < nargs; i++) {
+ struct probe_trace_arg_ref *ref = arg[i].ref;
+ unsigned int regn = arg[i].regn;
+
+ /* Print argument value */
+ if (arg[i].value[0] == '@' && ref) {
+ /* TODO parse other arguments */
+ pr_debug("%d%+ld", regn, ref->offset);
+ } else {
+ int depth = 0;
+
+ new_insn += bpf_prologue_arg_deref(
+ get_arch_reg_offset(regn),
+ i + 1,
+ depth++,
+ new_prog ? new_insn : NULL,
+ !ref);
+
+ while (ref) {
+ new_insn += bpf_prologue_arg_deref(
+ ref->offset,
+ i + 1,
+ depth++,
+ new_prog ? new_insn : NULL,
+ !ref->next);
+ ref = ref->next;
+ }
+ }
+ }
+
+ new_insn += bpf_prologue_end(new_prog ? new_insn : NULL,
+ nargs);
+ *new_len = new_insn - new_prog;
+
+ return 0;
+}
+
/* Add a found probe point into trace event list */
static int add_probe_trace_event(Dwarf_Die *sc_die, struct probe_finder *pf)
{
@@ -1335,6 +1396,8 @@ int debuginfo__find_bpf_prologue(struct debuginfo *dbg,
.pf = {.pev = pev, .callback = generate_bpf_prologue},
.mod = dbg->mod, .max_tevs = BPF_MAX_TEVS};
struct probe_trace_event *tevs;
+ struct probe_trace_event *tev;
+ char *new_prog;
int ret;
/* Allocate result tevs array */
@@ -1347,9 +1410,25 @@ int debuginfo__find_bpf_prologue(struct debuginfo *dbg,
ret = debuginfo__find_probes(dbg, &tf.pf);
- *result = NULL;
- *count = 0;
+ tev = &tevs[0];
+
+ synthesize_probe_bpf(tev->args, tev->nargs, NULL, count);
+ if (*count == 0)
+ goto end;
+
+ new_prog = malloc(*count);
+ if (!new_prog) {
+ ret = -ENOMEM;
+ goto end;
+ }
+ synthesize_probe_bpf(tev->args, tev->nargs, new_prog, count);
+
+ /* assign result to tvar */
+ *result = (char *)new_prog;
+
+end:
+ /* release tevs */
free(tevs);
return ret;
}
--
1.8.5.2
next prev parent reply other threads:[~2015-05-24 8:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-24 8:27 [RFC PATCH v2 00/15] perf bpf: Probing with local variable He Kuang
2015-05-24 8:27 ` [RFC PATCH v2 01/15] perf tools: Add lib/bpf to cscope target list He Kuang
2015-05-24 8:27 ` [RFC PATCH v2 02/15] perf bpf: Support custom vmlinux path He Kuang
2015-05-24 8:27 ` [RFC PATCH v2 03/15] perf bpf: Save pt_regs info from debuginfo He Kuang
2015-05-24 13:31 ` Masami Hiramatsu
2015-05-25 7:38 ` He Kuang
2015-05-24 8:28 ` [RFC PATCH v2 04/15] perf tools: Add functions to get calling regs He Kuang
2015-05-24 8:28 ` [RFC PATCH v2 05/15] perf tools: Add pt_regs offsets and calling regs for x86 He Kuang
2015-05-24 8:28 ` [RFC PATCH v2 06/15] bpf tools: Add headers for generating bpf bytecode He Kuang
2015-05-24 8:28 ` [RFC PATCH v2 07/15] bpf tools: Convert arglist to bpf prologue He Kuang
2015-05-24 8:28 ` [RFC PATCH v2 08/15] bpf tools: Fetch calling regs to bpf arglist He Kuang
2015-05-24 8:28 ` [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo He Kuang
2015-05-24 8:49 ` Masami Hiramatsu
2015-05-25 8:33 ` He Kuang
2015-05-25 12:22 ` Masami Hiramatsu
2015-05-25 12:46 ` Arnaldo Carvalho de Melo
2015-05-25 13:06 ` Masami Hiramatsu
2015-05-26 17:50 ` Alexei Starovoitov
2015-05-27 2:27 ` He Kuang
2015-05-27 11:43 ` Masami Hiramatsu
2015-05-27 15:30 ` Alexei Starovoitov
2015-05-28 13:01 ` He Kuang
2015-05-28 18:10 ` Alexei Starovoitov
2015-05-29 6:30 ` He Kuang
2015-05-29 23:55 ` Masami Hiramatsu
2015-05-30 1:27 ` Alexei Starovoitov
2015-05-30 7:01 ` Masami Hiramatsu
2015-05-24 8:28 ` [RFC PATCH v2 10/15] perf bpf: Process debuginfo for generating bpf prologue He Kuang
2015-05-24 8:28 ` He Kuang [this message]
2015-05-24 8:28 ` [RFC PATCH v2 12/15] perf bpf: Generate bpf prologue without debuginfo He Kuang
2015-05-24 8:28 ` [RFC PATCH v2 13/15] perf bpf: Combine bpf prologue and bpf prog He Kuang
2015-05-24 8:28 ` [RFC PATCH v2 14/15] samples/bpf: Add sample for testing bpf fetch args He Kuang
2015-05-24 8:28 ` [RFC PATCH v2 15/15] samples/bpf: Add sample for no-debuginfo case He Kuang
2015-05-26 17:53 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432456091-73384-12-git-send-email-hekuang@huawei.com \
--to=hekuang@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ast@plumgrid.com \
--cc=brendan.d.gregg@gmail.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®