mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vishnu Pratap Singh <vishnu.ps@samsung.com>
To: paul.gortmaker@windriver.com, snitzer@redhat.com,
	dehrenberg@chromium.org, pavel@ucw.cz, akpm@linux-foundation.org,
	mszeredi@suse.cz, linux-kernel@vger.kernel.org
Cc: cpgs@samsung.com, Vishnu Pratap Singh <vishnu.ps@samsung.com>
Subject: [PATCH] init/do_mounts: Add create_dev() failure log
Date: Mon, 25 May 2015 10:47:50 +0530	[thread overview]
Message-ID: <1432531070-4262-1-git-send-email-vishnu.ps@samsung.com> (raw)
In-Reply-To: <130285@samsung.com>

if create_dev() function fails to create the root mount device (/dev/root),
then it goes to panic as root device not found but there is no check/log
present in case of failure, So i have added the log in case it fails to create
the root device. It will help in debugging.

Signed-off-by: Vishnu Pratap Singh <vishnu.ps@samsung.com>
---
 init/do_mounts.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/init/do_mounts.c b/init/do_mounts.c
index 8369ffa..a68aaf6 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -532,7 +532,8 @@ void __init mount_root(void)
 	}
 #endif
 #ifdef CONFIG_BLOCK
-	create_dev("/dev/root", ROOT_DEV);
+	if(create_dev("/dev/root", ROOT_DEV) < 0)
+		printk(KERN_ERR "Failed to create %s device !!\n", "/dev/root");
 	mount_block_root("/dev/root", root_mountflags);
 #endif
 }
-- 
1.7.9.5


       reply	other threads:[~2015-05-25  5:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <130285@samsung.com>
2015-05-25  5:17 ` Vishnu Pratap Singh [this message]
2015-05-25 12:59   ` Pavel Machek
2015-05-25 13:49   ` Vishnu Pratap Singh
2015-05-26  6:25     ` Pavel Machek
2015-05-26  6:26   ` [PATCHv2] " Vishnu Pratap Singh
2015-05-26  8:32     ` Pavel Machek
2015-05-27 23:27     ` Andrew Morton
2015-05-22 12:37 [PATCH] " Vishnu Pratap Singh
2015-05-22 16:48 ` Randy Dunlap
2015-05-22 19:44   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432531070-4262-1-git-send-email-vishnu.ps@samsung.com \
    --to=vishnu.ps@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=cpgs@samsung.com \
    --cc=dehrenberg@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mszeredi@suse.cz \
    --cc=paul.gortmaker@windriver.com \
    --cc=pavel@ucw.cz \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®