From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: "Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Sagi Grimberg <sagig@mellanox.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member
Date: Tue, 26 May 2015 22:13:02 -0700 [thread overview]
Message-ID: <1432703582.26863.33.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <55646A9E.5050401@sandisk.com>
On Tue, 2015-05-26 at 14:44 +0200, Bart Van Assche wrote:
> On 05/26/15 08:57, Nicholas A. Bellinger wrote:
> > - Add various rcu_dereference and lockless_dereference RCU notation
>
> Hello Nic,
>
> Feedback from an RCU expert (which I'm not) would be appreciated here.
> But my understanding is that lockless_dereference(p) should be used for
> a pointer p that has *not* been annotated as an RCU pointer. I think in
> the for-next branch of the target repository that this macro is used to
> access RCU-annotated pointers. Is that why sparse complains about how
> lockless_dereference() is used in the target tree ?
>
Was curious about this myself.. Thanks for raising the question!
The intention of lockless_dereference() in both this and preceding
series is for __rcu protected pointers that are accessed outside of
rcu_read_lock() protection, and who's lifetime is controlled by a:
- struct kref
- struct percpu_ref
- struct config_group symlink
- RCU updater path with some manner of mutex or spinlock held
This is supposed to be following Paul's comment in rcupdate.h:
* Similar to rcu_dereference(), but for situations where the pointed-to
* object's lifetime is managed by something other than RCU. That
* "something other" might be reference counting or simple immortality.
Paul, would you be to kind to clarify the intention for us..?
Thank you,
--nab
next prev parent reply other threads:[~2015-05-27 5:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 6:57 Nicholas A. Bellinger
2015-05-26 6:57 ` [PATCH-v2 1/4] target: Subsume se_port + t10_alua_tg_pt_gp_member into se_lun Nicholas A. Bellinger
2015-05-26 6:57 ` [PATCH-v2 2/4] target: Drop lun_sep_lock for se_lun->lun_se_dev RCU usage Nicholas A. Bellinger
2015-05-26 14:30 ` Bart Van Assche
2015-05-27 5:29 ` Nicholas A. Bellinger
2015-05-27 21:04 ` Paul E. McKenney
2015-05-28 6:02 ` Nicholas A. Bellinger
2015-05-28 15:57 ` Paul E. McKenney
2015-05-31 5:24 ` Nicholas A. Bellinger
2015-06-01 18:00 ` Paul E. McKenney
2015-05-26 6:57 ` [PATCH-v2 3/4] target: Drop se_lun->lun_active for existing percpu lun_ref Nicholas A. Bellinger
2015-05-26 6:57 ` [PATCH-v2 4/4] target: Drop unnecessary core_tpg_register TFO parameter Nicholas A. Bellinger
2015-05-26 9:43 ` [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member Hannes Reinecke
2015-05-26 12:44 ` Bart Van Assche
2015-05-27 5:13 ` Nicholas A. Bellinger [this message]
2015-05-27 20:36 ` Paul E. McKenney
2015-05-28 5:41 ` Nicholas A. Bellinger
2015-05-28 15:48 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432703582.26863.33.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@daterainc.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®