mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
	dan.carpenter@oracle.com, joe@perches.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 02/11] staging: rtl8192e: Remove dead code: cmpk_handle_query_config_rx()
Date: Tue,  2 Jun 2015 22:48:06 +0200	[thread overview]
Message-ID: <1433278095-13988-3-git-send-email-mateusz.kulikowski@gmail.com> (raw)
In-Reply-To: <1433278095-13988-1-git-send-email-mateusz.kulikowski@gmail.com>

Remove cmpk_handle_query_config_rx function. It is called
once, does some calculation, but generates no output -
it has neither return value, nor modify its parameters.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
index ecdd2e5..53676a6 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
@@ -198,23 +198,6 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg)
 
 }
 
-static	void cmpk_handle_query_config_rx(struct net_device *dev, u8 *pmsg)
-{
-	cmpk_query_cfg_t	rx_query_cfg;
-
-
-	rx_query_cfg.cfg_action = (pmsg[4] & 0x80000000)>>31;
-	rx_query_cfg.cfg_type = (pmsg[4] & 0x60) >> 5;
-	rx_query_cfg.cfg_size = (pmsg[4] & 0x18) >> 3;
-	rx_query_cfg.cfg_page = (pmsg[6] & 0x0F) >> 0;
-	rx_query_cfg.cfg_offset	 = pmsg[7];
-	rx_query_cfg.value = (pmsg[8] << 24) | (pmsg[9] << 16) |
-			     (pmsg[10] << 8) | (pmsg[11] << 0);
-	rx_query_cfg.mask = (pmsg[12] << 24) | (pmsg[13] << 16) |
-			    (pmsg[14] << 8) | (pmsg[15] << 0);
-
-}
-
 static void cmpk_count_tx_status(struct net_device *dev,
 				 struct cmpk_tx_status *pstx_status)
 {
@@ -346,7 +329,6 @@ u32 cmpk_message_handle_rx(struct net_device *dev,
 		case BOTH_QUERY_CONFIG:
 			RT_TRACE(COMP_CMDPKT,
 				 "---->cmpk_message_handle_rx():BOTH_QUERY_CONFIG\n");
-			cmpk_handle_query_config_rx(dev, pcmd_buff);
 			cmd_length = CMPK_BOTH_QUERY_CONFIG_SIZE;
 			break;
 		case RX_TX_STATUS:
-- 
1.8.4.1


  parent reply	other threads:[~2015-06-02 20:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 20:48 [PATCH 00/11] staging: rtl8192e: Remove dead code Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 01/11] " Mateusz Kulikowski
2015-06-02 20:48 ` Mateusz Kulikowski [this message]
2015-06-02 20:48 ` [PATCH 03/11] staging: rtl8192e: Remove dead code: cmpk_message_handle_rx() Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 04/11] staging: rtl8192e: Remove dead code: read/write_cam Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 05/11] staging: rtl8192e: Remove unused macros/structures in rtl_core.h Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 06/11] staging: rtl8192e: Remove dead code: rtl_dm.[ch] Mateusz Kulikowski
2015-06-04 13:52   ` Dan Carpenter
2015-06-07 19:34     ` Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode Mateusz Kulikowski
2015-06-03  7:26   ` Sudip Mukherjee
2015-06-03 18:21     ` Mateusz Kulikowski
2015-06-04  5:18       ` Sudip Mukherjee
2015-06-04  5:50         ` Mateusz Kulikowski
2015-06-04  6:06           ` Sudip Mukherjee
2015-06-07 19:28             ` Mateusz Kulikowski
2015-06-04 13:53         ` Dan Carpenter
2015-06-02 20:48 ` [PATCH 08/11] staging: rtl8192e: Remove dead code: rt_stats Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 09/11] staging: rtl8192e: Remove dead code: undefined arrays Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 10/11] staging: rtl8192e: Remove dead code: r8192_priv members Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 11/11] staging: rtl8192e: Remove dead code: mp_adapter Mateusz Kulikowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433278095-13988-3-git-send-email-mateusz.kulikowski@gmail.com \
    --to=mateusz.kulikowski@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®