From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
dan.carpenter@oracle.com, joe@perches.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode
Date: Tue, 2 Jun 2015 22:48:11 +0200 [thread overview]
Message-ID: <1433278095-13988-8-git-send-email-mateusz.kulikowski@gmail.com> (raw)
In-Reply-To: <1433278095-13988-1-git-send-email-mateusz.kulikowski@gmail.com>
dig_t::dbg_mode is initialized to one value and checked only once in code.
This patch throws it away, and deletes always-true condition.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 5 +----
drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 24 ------------------------
2 files changed, 1 insertion(+), 28 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index d869629..95a7c8e 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -1311,7 +1311,6 @@ static void dm_dig_init(struct net_device *dev)
dm_digtable.dig_algorithm = DIG_ALGO_BY_RSSI;
- dm_digtable.dbg_mode = DM_DBG_OFF;
dm_digtable.dig_algorithm_switch = 0;
dm_digtable.dig_state = DM_STA_DIG_MAX;
@@ -1391,8 +1390,7 @@ static void dm_ctrl_initgain_byrssi_by_driverrssi(
dm_digtable.CurSTAConnectState = DIG_STA_DISCONNECT;
- if (dm_digtable.dbg_mode == DM_DBG_OFF)
- dm_digtable.rssi_val = priv->undecorated_smoothed_pwdb;
+ dm_digtable.rssi_val = priv->undecorated_smoothed_pwdb;
dm_initial_gain(dev);
dm_pd_th(dev);
dm_cs_ratio(dev);
@@ -1949,7 +1947,6 @@ static void dm_init_rxpath_selection(struct net_device *dev)
DM_RxPathSelTable.cck_method = CCK_Rx_Version_2;
else
DM_RxPathSelTable.cck_method = CCK_Rx_Version_1;
- DM_RxPathSelTable.DbgMode = DM_DBG_OFF;
DM_RxPathSelTable.disabledRF = 0;
for (i = 0; i < 4; i++) {
DM_RxPathSelTable.rf_rssi[i] = 50;
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
index b0d9367..c4ecafb 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
@@ -87,7 +87,6 @@
struct dig_t {
u8 dig_enable_flag;
u8 dig_algorithm;
- u8 dbg_mode;
u8 dig_algorithm_switch;
long rssi_low_thresh;
@@ -130,23 +129,6 @@ enum dm_ratr_sta {
DM_RATR_STA_MAX
};
-enum dm_dig_op_sta {
- DIG_TYPE_THRESH_HIGH = 0,
- DIG_TYPE_THRESH_LOW = 1,
- DIG_TYPE_THRESH_HIGHPWR_HIGH = 2,
- DIG_TYPE_THRESH_HIGHPWR_LOW = 3,
- DIG_TYPE_DBG_MODE = 4,
- DIG_TYPE_RSSI = 5,
- DIG_TYPE_ALGORITHM = 6,
- DIG_TYPE_BACKOFF = 7,
- DIG_TYPE_PWDB_FACTOR = 8,
- DIG_TYPE_RX_GAIN_MIN = 9,
- DIG_TYPE_RX_GAIN_MAX = 10,
- DIG_TYPE_ENABLE = 20,
- DIG_TYPE_DISABLE = 30,
- DIG_OP_TYPE_MAX
-};
-
enum dm_dig_alg {
DIG_ALGO_BY_FALSE_ALARM = 0,
DIG_ALGO_BY_RSSI = 1,
@@ -201,12 +183,6 @@ enum dm_cck_rx_path_method {
};
-enum dm_dbg {
- DM_DBG_OFF = 0,
- DM_DBG_ON = 1,
- DM_DBG_MAX
-};
-
struct dcmd_txcmd {
u32 Op;
u32 Length;
--
1.8.4.1
next prev parent reply other threads:[~2015-06-02 20:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 20:48 [PATCH 00/11] staging: rtl8192e: Remove dead code Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 01/11] " Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 02/11] staging: rtl8192e: Remove dead code: cmpk_handle_query_config_rx() Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 03/11] staging: rtl8192e: Remove dead code: cmpk_message_handle_rx() Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 04/11] staging: rtl8192e: Remove dead code: read/write_cam Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 05/11] staging: rtl8192e: Remove unused macros/structures in rtl_core.h Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 06/11] staging: rtl8192e: Remove dead code: rtl_dm.[ch] Mateusz Kulikowski
2015-06-04 13:52 ` Dan Carpenter
2015-06-07 19:34 ` Mateusz Kulikowski
2015-06-02 20:48 ` Mateusz Kulikowski [this message]
2015-06-03 7:26 ` [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode Sudip Mukherjee
2015-06-03 18:21 ` Mateusz Kulikowski
2015-06-04 5:18 ` Sudip Mukherjee
2015-06-04 5:50 ` Mateusz Kulikowski
2015-06-04 6:06 ` Sudip Mukherjee
2015-06-07 19:28 ` Mateusz Kulikowski
2015-06-04 13:53 ` Dan Carpenter
2015-06-02 20:48 ` [PATCH 08/11] staging: rtl8192e: Remove dead code: rt_stats Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 09/11] staging: rtl8192e: Remove dead code: undefined arrays Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 10/11] staging: rtl8192e: Remove dead code: r8192_priv members Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 11/11] staging: rtl8192e: Remove dead code: mp_adapter Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433278095-13988-8-git-send-email-mateusz.kulikowski@gmail.com \
--to=mateusz.kulikowski@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®