mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] perf/x86/intel/pt: Fix a refactoring glitch
@ 2015-06-04 13:31 Alexander Shishkin
  0 siblings, 0 replies; only message in thread
From: Alexander Shishkin @ 2015-06-04 13:31 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar
  Cc: linux-kernel, Paul Mackerras, adrian.hunter, x86, hpa, acme,
	Alexander Shishkin

Commit 066450be41 ("perf/x86/intel/pt: Clean up the control flow in
pt_pmu_hw_init()") changed attribute initialization so that only the
first attribute gets initialized using sysfs_attr_init(), which upsets
lockdep.

This patch fixes the glitch so that all allocated attributes are properly
initialized thus fixing the lockdep warning reported by Tvrtko and Imre.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Reported-by: Imre Deak <imre.deak@intel.com>
---
 arch/x86/kernel/cpu/perf_event_intel_pt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c
index ccdda1311e..7ef69b2c46 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_pt.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c
@@ -197,7 +197,7 @@ static int __init pt_pmu_hw_init(void)
 
 		de_attr->attr.attr.name = pt_caps[i].name;
 
-		sysfs_attr_init(&de_attrs->attr.attr);
+		sysfs_attr_init(&de_attr->attr.attr);
 
 		de_attr->attr.attr.mode		= S_IRUGO | S_IWUSR;
 		de_attr->attr.store		= pt_cap_store;
-- 
2.1.4


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-06-04 13:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-04 13:31 [PATCH] perf/x86/intel/pt: Fix a refactoring glitch Alexander Shishkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®