mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: "Borislav Petkov" <bp@suse.de>,
	"Andy Lutomirski" <luto@amacapital.net>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Len Brown" <lenb@kernel.org>,
	"John Stultz" <john.stultz@linaro.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Aaron Lu <aaron.lu@intel.com>,
	Suravee Suthikulanit <suravee.suthikulpanit@amd.com>,
	Tony Li <tony.li@amd.com>, Ken Xue <ken.xue@amd.com>,
	Huang Rui <ray.huang@amd.com>
Subject: [PATCH v2 0/4] x86, mwaitt: introduce AMD mwaitt support
Date: Tue, 9 Jun 2015 11:13:37 +0800	[thread overview]
Message-ID: <1433819621-15093-1-git-send-email-ray.huang@amd.com> (raw)

Hi,

This patch set introduces a new instruction support on AMD Carrizo (Family
15h, Model 60h-6fh). It adds mwaitx delay function with a configurable
timer.

Andy and Boris provide a suggestion which use mwaitx on delay method.

Some discussions of the background, please see:
http://marc.info/?l=linux-kernel&m=143202042530498&w=2
http://marc.info/?l=linux-kernel&m=143161327003541&w=2
http://marc.info/?l=linux-kernel&m=143222815331016&w=2

They are rebased on tip/master.

Changes from v1 -> v2
- Remove mwaitx idle implementation since some disputes without power
  improvement.
- Add a patch which implement another use case on delay.
- Introduce a kernel parameter (delay) to make delay method configurable.


I already do some testing with mwaitx on udelay.

Test scenario: 

glb_loops = usec_to_tsc(delay_usec)
rdtsc -> read TSC counters as start
mwaitx_delay(glb_loops)
rdtsc -> read TSC counters as end
diff = end - start

Compared the real TSC counts (diff), that means the loops of counter goes.
And glb_loops is the input value of the EBX, that is the expect loops which
user configures. Below is 10000 us of mwaitx delay, we could see about 1200
(diff - glb_loops) delayed with mwaitx.

[ 2369.008651] start=4401974718758, end=4401992576888, diff=17858130, glb_loops=17856939

Thanks,
Rui

Huang Rui (4):
  x86, mwaitt: add monitorx and mwaitx instruction
  x86, mwaitt: make delay method configurable
  x86, mwaitt: introduce mwaix delay with a configurable timer
  x86, mwaitt: add documents of delay option

 Documentation/kernel-parameters.txt |    7 ++++++
 arch/x86/include/asm/cpufeature.h   |    1 +
 arch/x86/include/asm/delay.h        |    8 ++++++
 arch/x86/include/asm/mwait.h        |   26 ++++++++++++++++++++
 arch/x86/kernel/setup.c             |   22 +++++++++++++++++
 arch/x86/lib/delay.c                |   46 +++++++++++++++++++++++++++++++++--
 6 files changed, 108 insertions(+), 2 deletions(-)

-- 
1.7.9.5


             reply	other threads:[~2015-06-09  3:30 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09  3:13 Huang Rui [this message]
2015-06-09  3:13 ` [PATCH v2 1/4] x86, mwaitt: add monitorx and mwaitx instruction Huang Rui
2015-06-09  8:23   ` Peter Zijlstra
2015-06-09  9:48     ` Huang Rui
2015-06-09 10:05       ` Borislav Petkov
2015-06-09 16:44         ` Andy Lutomirski
2015-06-09 17:06           ` Borislav Petkov
2015-06-10  2:40             ` Huang Rui
2015-06-09  3:13 ` [PATCH v2 2/4] x86, mwaitt: make delay method configurable Huang Rui
2015-06-09  9:05   ` Borislav Petkov
2015-06-09  9:31     ` Peter Zijlstra
2015-06-09 10:03     ` Huang Rui
2015-06-09 10:08       ` Peter Zijlstra
2015-06-09 10:15         ` Huang Rui
2015-06-09 10:08       ` Borislav Petkov
2015-06-09  3:13 ` [PATCH v2 3/4] x86, mwaitt: introduce mwaix delay with a configurable timer Huang Rui
2015-06-09  8:31   ` Peter Zijlstra
2015-06-09 10:10     ` Huang Rui
2015-06-09  9:29   ` Peter Zijlstra
2015-06-09 10:59     ` Huang Rui
2015-06-09 16:46     ` Andy Lutomirski
2015-06-09 17:13       ` Peter Zijlstra
2015-06-09 17:55         ` Andy Lutomirski
2015-06-09 18:43           ` Borislav Petkov
2015-06-09 18:55             ` Andy Lutomirski
2015-06-12  8:42       ` Borislav Petkov
2015-06-12 23:15         ` Andy Lutomirski
2015-06-13  8:48           ` Borislav Petkov
2015-06-09  3:13 ` [PATCH v2 4/4] x86, mwaitt: add documents of delay option Huang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433819621-15093-1-git-send-email-ray.huang@amd.com \
    --to=ray.huang@amd.com \
    --cc=aaron.lu@intel.com \
    --cc=bp@suse.de \
    --cc=fengguang.wu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=ken.xue@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tglx@linutronix.de \
    --cc=tony.li@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®