From: Borislav Petkov <bp@suse.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"John Stultz" <john.stultz@linaro.org>,
"Aaron Lu" <aaron.lu@intel.com>, "Tony Li" <tony.li@amd.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Suravee Suthikulanit" <suravee.suthikulpanit@amd.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Fengguang Wu" <fengguang.wu@intel.com>,
"Len Brown" <lenb@kernel.org>, "Ken Xue" <ken.xue@amd.com>,
"Huang Rui" <ray.huang@amd.com>, "X86 ML" <x86@kernel.org>
Subject: Re: [PATCH v2 3/4] x86, mwaitt: introduce mwaix delay with a configurable timer
Date: Fri, 12 Jun 2015 10:42:51 +0200 [thread overview]
Message-ID: <20150612084251.GB9257@pd.tnic> (raw)
In-Reply-To: <CALCETrXjtZkmg1xRc8=U9i0-mqS_ftqcWuPeMYLdvONiv_fUTQ@mail.gmail.com>
On Tue, Jun 09, 2015 at 09:46:52AM -0700, Andy Lutomirski wrote:
> I don't like this hack. The compiler is entirely within is rights to
> poke addr's cacheline (i.e. the stack) between the two instructions.
> I'd suggest either making the thing a full cacheline long or using a
> single asm statement.
How about this:
/*
* This should be a memory location in a cache line which is
* unlikely to be touched by other processors. The actual
* content is immaterial as it is not actually modified in any way.
*/
mwait_ptr = ¤t_thread_info()->flags;
and then
__monitor(mwait_ptr, 0, 0);
We already do this in mwait_play_dead().
However, am I even correct in assuming that ->flags won't really be
touched as we're doing delay() and nothing pokes into current anyway?
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-06-12 8:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 3:13 [PATCH v2 0/4] x86, mwaitt: introduce AMD mwaitt support Huang Rui
2015-06-09 3:13 ` [PATCH v2 1/4] x86, mwaitt: add monitorx and mwaitx instruction Huang Rui
2015-06-09 8:23 ` Peter Zijlstra
2015-06-09 9:48 ` Huang Rui
2015-06-09 10:05 ` Borislav Petkov
2015-06-09 16:44 ` Andy Lutomirski
2015-06-09 17:06 ` Borislav Petkov
2015-06-10 2:40 ` Huang Rui
2015-06-09 3:13 ` [PATCH v2 2/4] x86, mwaitt: make delay method configurable Huang Rui
2015-06-09 9:05 ` Borislav Petkov
2015-06-09 9:31 ` Peter Zijlstra
2015-06-09 10:03 ` Huang Rui
2015-06-09 10:08 ` Peter Zijlstra
2015-06-09 10:15 ` Huang Rui
2015-06-09 10:08 ` Borislav Petkov
2015-06-09 3:13 ` [PATCH v2 3/4] x86, mwaitt: introduce mwaix delay with a configurable timer Huang Rui
2015-06-09 8:31 ` Peter Zijlstra
2015-06-09 10:10 ` Huang Rui
2015-06-09 9:29 ` Peter Zijlstra
2015-06-09 10:59 ` Huang Rui
2015-06-09 16:46 ` Andy Lutomirski
2015-06-09 17:13 ` Peter Zijlstra
2015-06-09 17:55 ` Andy Lutomirski
2015-06-09 18:43 ` Borislav Petkov
2015-06-09 18:55 ` Andy Lutomirski
2015-06-12 8:42 ` Borislav Petkov [this message]
2015-06-12 23:15 ` Andy Lutomirski
2015-06-13 8:48 ` Borislav Petkov
2015-06-09 3:13 ` [PATCH v2 4/4] x86, mwaitt: add documents of delay option Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612084251.GB9257@pd.tnic \
--to=bp@suse.de \
--cc=aaron.lu@intel.com \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=john.stultz@linaro.org \
--cc=ken.xue@amd.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=peterz@infradead.org \
--cc=ray.huang@amd.com \
--cc=rjw@rjwysocki.net \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=tony.li@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®