From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-mml@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>,
Andrew Morton <akpm@linux-foundation.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
Brian Gerst <brgerst@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Waiman Long <Waiman.Long@hp.com>
Subject: [PATCH 09/12] x86/mm/pat/32: Remove pgd_list use from the PAT code
Date: Thu, 11 Jun 2015 16:07:14 +0200 [thread overview]
Message-ID: <1434031637-9091-10-git-send-email-mingo@kernel.org> (raw)
In-Reply-To: <1434031637-9091-1-git-send-email-mingo@kernel.org>
The 32-bit x86 PAT code uses __set_pmd_pte() to update pmds.
This uses pgd_list currently, but we don't need the global
list as we can walk the task list under RCU.
(This code already holds the pgd_lock.)
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Waiman Long <Waiman.Long@hp.com>
Cc: linux-mm@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/mm/pageattr.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index 997fc97e9072..93c134fdb398 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -438,18 +438,31 @@ static void __set_pmd_pte(pte_t *kpte, unsigned long address, pte_t pte)
set_pte_atomic(kpte, pte);
#ifdef CONFIG_X86_32
if (!SHARED_KERNEL_PMD) {
- struct page *page;
+ struct task_struct *g, *p;
- list_for_each_entry(page, &pgd_list, lru) {
+ rcu_read_lock();
+
+ for_each_process_thread(g, p) {
+ spinlock_t *pgt_lock;
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
- pgd = (pgd_t *)page_address(page) + pgd_index(address);
+ if (!p->mm)
+ continue;
+
+ pgt_lock = &p->mm->page_table_lock;
+ spin_lock(pgt_lock);
+
+ pgd = p->mm->pgd + pgd_index(address);
pud = pud_offset(pgd, address);
pmd = pmd_offset(pud, address);
set_pte_atomic((pte_t *)pmd, pte);
+
+ spin_unlock(pgt_lock);
}
+
+ rcu_read_unlock();
}
#endif
}
--
2.1.4
next prev parent reply other threads:[~2015-06-11 14:09 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 14:07 [RFC PATCH 00/12] x86/mm: Implement lockless pgd_alloc()/pgd_free() Ingo Molnar
2015-06-11 14:07 ` [PATCH 01/12] x86/mm/pat: Don't free PGD entries on memory unmap Ingo Molnar
2015-06-11 14:07 ` [PATCH 02/12] x86/mm/hotplug: Remove pgd_list use from the memory hotplug code Ingo Molnar
2015-06-12 22:22 ` Oleg Nesterov
2015-06-12 22:48 ` Waiman Long
2015-06-13 7:46 ` Ingo Molnar
2015-06-12 23:15 ` Oleg Nesterov
2015-06-13 7:48 ` Ingo Molnar
2015-06-11 14:07 ` [PATCH 03/12] x86/mm/hotplug: Don't remove PGD entries in remove_pagetable() Ingo Molnar
2015-06-11 14:07 ` [PATCH 04/12] x86/mm/hotplug: Simplify sync_global_pgds() Ingo Molnar
2015-06-12 22:28 ` Oleg Nesterov
2015-06-13 7:51 ` Ingo Molnar
2015-06-11 14:07 ` [PATCH 05/12] mm: Introduce arch_pgd_init_late() Ingo Molnar
2015-06-11 18:23 ` Andrew Morton
2015-06-12 8:16 ` Ingo Molnar
2015-06-12 21:12 ` Oleg Nesterov
2015-06-13 6:54 ` Ingo Molnar
2015-06-11 14:07 ` [PATCH 06/12] x86/mm: Enable and use the arch_pgd_init_late() method Ingo Molnar
2015-06-11 20:04 ` Boris Ostrovsky
2015-06-12 8:19 ` Ingo Molnar
2015-06-12 22:50 ` Oleg Nesterov
2015-06-12 22:57 ` Oleg Nesterov
2015-06-13 6:49 ` Ingo Molnar
2015-06-13 6:47 ` Ingo Molnar
2015-06-13 6:52 ` Ingo Molnar
2015-06-13 17:45 ` Oleg Nesterov
2015-06-14 8:13 ` Ingo Molnar
2015-06-14 20:54 ` Oleg Nesterov
2015-06-14 22:10 ` Oleg Nesterov
2015-06-11 14:07 ` [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code Ingo Molnar
2015-06-11 20:37 ` Linus Torvalds
2015-06-11 20:41 ` Linus Torvalds
2015-06-12 7:23 ` Ingo Molnar
[not found] ` <CA+55aFxXM=DN32JqNmJ=JoMum5OPnsRohCry-=2T=LabX2hzVQ@mail.gmail.com>
2015-06-12 8:04 ` Ingo Molnar
2015-06-12 20:38 ` Oleg Nesterov
2015-06-12 20:53 ` Oleg Nesterov
2015-06-12 22:30 ` Boris Ostrovsky
2015-06-12 23:36 ` Oleg Nesterov
2015-06-13 7:26 ` Ingo Molnar
2015-06-13 18:00 ` Oleg Nesterov
2015-06-11 14:07 ` [PATCH 08/12] x86/mm: Remove pgd_list use from vmalloc_sync_all() Ingo Molnar
2015-06-11 15:04 ` Andy Lutomirski
2015-06-11 15:49 ` Ingo Molnar
2015-06-11 16:10 ` Andy Lutomirski
2015-06-11 14:07 ` Ingo Molnar [this message]
2015-06-11 14:07 ` [PATCH 10/12] x86/mm: Make pgd_alloc()/pgd_free() lockless Ingo Molnar
2015-06-11 14:07 ` [PATCH 11/12] x86/mm: Remove pgd_list leftovers Ingo Molnar
2015-06-11 14:07 ` [PATCH 12/12] x86/mm: Simplify pgd_alloc() Ingo Molnar
2015-06-11 14:13 ` [RFC PATCH 00/12] x86/mm: Implement lockless pgd_alloc()/pgd_free() Ingo Molnar
2015-06-11 16:46 ` H. Peter Anvin
2015-06-13 9:49 [PATCH 00/12, v2] " Ingo Molnar
2015-06-13 9:49 ` [PATCH 09/12] x86/mm/pat/32: Remove pgd_list use from the PAT code Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434031637-9091-10-git-send-email-mingo@kernel.org \
--to=mingo@kernel.org \
--cc=Waiman.Long@hp.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mml@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome