* [PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250
@ 2015-06-12 9:03 Hyungwon Hwang
2015-06-12 9:03 ` [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel Hyungwon Hwang
2015-06-12 9:19 ` [PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250 Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Hyungwon Hwang @ 2015-06-12 9:03 UTC (permalink / raw)
To: dri-devel, linux-samsung-soc, linux-kernel, inki.dae
Cc: sw0312.kim, jy0922.shim, Hyungwon Hwang
Exynos mipi phy driver needs syscon node to be probed successfully.
Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
---
arch/arm/boot/dts/exynos3250.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index e3bfb11..f8c02dd 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -140,6 +140,7 @@
compatible = "samsung,s5pv210-mipi-video-phy";
reg = <0x10020710 8>;
#phy-cells = <1>;
+ syscon = <&pmu_system_controller>;
};
pd_cam: cam-power-domain@10023C00 {
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel
2015-06-12 9:03 [PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250 Hyungwon Hwang
@ 2015-06-12 9:03 ` Hyungwon Hwang
2015-06-12 9:23 ` Krzysztof Kozlowski
2015-06-12 9:19 ` [PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250 Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Hyungwon Hwang @ 2015-06-12 9:03 UTC (permalink / raw)
To: dri-devel, linux-samsung-soc, linux-kernel, inki.dae
Cc: sw0312.kim, jy0922.shim, Hyungwon Hwang
Because of recent update, proper clock-frequency becomes mandatory
for validating the mode of panel. This clock-frequency must be set
appropriately for getting required frame rate.
Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
---
arch/arm/boot/dts/exynos3250-rinato.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 0b99068..75aba40 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -181,7 +181,7 @@
display-timings {
timing-0 {
- clock-frequency = <0>;
+ clock-frequency = <4600000>;
hactive = <320>;
vactive = <320>;
hfront-porch = <1>;
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel
2015-06-12 9:03 ` [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel Hyungwon Hwang
@ 2015-06-12 9:23 ` Krzysztof Kozlowski
2015-06-12 9:27 ` Hyungwon Hwang
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-12 9:23 UTC (permalink / raw)
To: Hyungwon Hwang
Cc: dri-devel, linux-samsung-soc, linux-kernel, Inki Dae, sw0312.kim,
jy0922.shim
2015-06-12 18:03 GMT+09:00 Hyungwon Hwang <human.hwang@samsung.com>:
> Because of recent update, proper clock-frequency becomes mandatory
> for validating the mode of panel. This clock-frequency must be set
> appropriately for getting required frame rate.
>
> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Is it a bugfix? The property is mandatory right now?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel
2015-06-12 9:23 ` Krzysztof Kozlowski
@ 2015-06-12 9:27 ` Hyungwon Hwang
2015-06-12 9:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Hyungwon Hwang @ 2015-06-12 9:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: dri-devel, linux-samsung-soc, linux-kernel, Inki Dae, sw0312.kim,
jy0922.shim
On Fri, 12 Jun 2015 18:23:18 +0900
Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-06-12 18:03 GMT+09:00 Hyungwon Hwang <human.hwang@samsung.com>:
> > Because of recent update, proper clock-frequency becomes mandatory
> > for validating the mode of panel. This clock-frequency must be set
> > appropriately for getting required frame rate.
> >
> > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Is it a bugfix? The property is mandatory right now?
With recent kernel, yes. It is mandatory for the mode to be become
available.
Best regards,
Hyungwon Hwang
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel
2015-06-12 9:27 ` Hyungwon Hwang
@ 2015-06-12 9:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-12 9:36 UTC (permalink / raw)
To: Hyungwon Hwang
Cc: Krzysztof Kozlowski, dri-devel, linux-samsung-soc, linux-kernel,
Inki Dae, sw0312.kim, jy0922.shim
2015-06-12 18:27 GMT+09:00 Hyungwon Hwang <human.hwang@samsung.com>:
> On Fri, 12 Jun 2015 18:23:18 +0900
> Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>
>> 2015-06-12 18:03 GMT+09:00 Hyungwon Hwang <human.hwang@samsung.com>:
>> > Because of recent update, proper clock-frequency becomes mandatory
>> > for validating the mode of panel. This clock-frequency must be set
>> > appropriately for getting required frame rate.
>> >
>> > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>>
>> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> Is it a bugfix? The property is mandatory right now?
>
> With recent kernel, yes. It is mandatory for the mode to be become
> available.
So it looks like bugfix. Can you resend the patch with:
1. cc-stable and fixes tags,
2. observable bug/issue/error (error from dmesg would be enough)?
It looks quite similar to 242ddf0429
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250
2015-06-12 9:03 [PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250 Hyungwon Hwang
2015-06-12 9:03 ` [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel Hyungwon Hwang
@ 2015-06-12 9:19 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-12 9:19 UTC (permalink / raw)
To: Hyungwon Hwang
Cc: dri-devel, linux-samsung-soc, linux-kernel, Inki Dae, sw0312.kim,
jy0922.shim, Beata
2015-06-12 18:03 GMT+09:00 Hyungwon Hwang <human.hwang@samsung.com>:
> Exynos mipi phy driver needs syscon node to be probed successfully.
>
> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 1 +
> 1 file changed, 1 insertion(+)
Thanks for the patch but actually Beata Michalska (+CC) sent it also
before [0]. The only thing stopping from applying this was 'reg' field
which should be removed. However I am still waiting for that resubmit.
[0] http://linux-arm-kernel.infradead.narkive.com/tGUK806c/patch-arm-dts-update-video-phy-node-with-syscon-phandle-for-exynos3250
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-12 9:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-12 9:03 [PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250 Hyungwon Hwang
2015-06-12 9:03 ` [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel Hyungwon Hwang
2015-06-12 9:23 ` Krzysztof Kozlowski
2015-06-12 9:27 ` Hyungwon Hwang
2015-06-12 9:36 ` Krzysztof Kozlowski
2015-06-12 9:19 ` [PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250 Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®