From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
jgross@suse.com
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use
Date: Fri, 15 Feb 2019 10:03:59 -0500 [thread overview]
Message-ID: <143411a8-385d-2cce-9211-22ba7db25a15@oracle.com> (raw)
In-Reply-To: <20190214142321.1138-1-andr2000@gmail.com>
On 2/14/19 9:23 AM, Oleksandr Andrushchenko wrote:
>
> /* DMA buffer export support. */
> @@ -311,6 +317,7 @@ static void dmabuf_exp_release(struct kref *kref)
>
> dmabuf_exp_wait_obj_signal(gntdev_dmabuf->priv, gntdev_dmabuf);
> list_del(&gntdev_dmabuf->next);
> + fput(gntdev_dmabuf->priv->filp);
> kfree(gntdev_dmabuf);
> }
>
> @@ -423,6 +430,7 @@ static int dmabuf_exp_from_pages(struct gntdev_dmabuf_export_args *args)
> mutex_lock(&args->dmabuf_priv->lock);
> list_add(&gntdev_dmabuf->next, &args->dmabuf_priv->exp_list);
> mutex_unlock(&args->dmabuf_priv->lock);
> + get_file(gntdev_dmabuf->priv->filp);
Not fget()?
-boris
next prev parent reply other threads:[~2019-02-15 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 14:23 Oleksandr Andrushchenko
2019-02-14 14:23 ` [Xen-devel][PATCH 2/2] xen/gntdev: Check and release imported dma-bufs on close Oleksandr Andrushchenko
2019-02-15 15:06 ` Boris Ostrovsky
2019-02-17 10:40 ` Juergen Gross
2019-02-15 15:03 ` Boris Ostrovsky [this message]
2019-02-15 15:07 ` [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use Oleksandr Andrushchenko
2019-02-15 15:28 ` Boris Ostrovsky
2019-02-15 15:35 ` Oleksandr Andrushchenko
2019-02-15 16:29 ` Juergen Gross
2019-02-17 10:39 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=143411a8-385d-2cce-9211-22ba7db25a15@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andr2000@gmail.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®