From: Juergen Gross <jgross@suse.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
boris.ostrovsky@oracle.com
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use
Date: Sun, 17 Feb 2019 11:39:41 +0100 [thread overview]
Message-ID: <302ff90b-32a9-58dd-ae8f-1b55813fed74@suse.com> (raw)
In-Reply-To: <20190214142321.1138-1-andr2000@gmail.com>
On 14/02/2019 15:23, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> If there are exported DMA buffers which are still in use and
> grant device is closed by either normal user-space close or by
> a signal this leads to the grant device context to be destroyed,
> thus making it not possible to correctly destroy those exported
> buffers when they are returned back to gntdev and makes the module
> crash:
>
> [ 339.617540] [<ffff00000854c0d8>] dmabuf_exp_ops_release+0x40/0xa8
> [ 339.617560] [<ffff00000867a6e8>] dma_buf_release+0x60/0x190
> [ 339.617577] [<ffff0000082211f0>] __fput+0x88/0x1d0
> [ 339.617589] [<ffff000008221394>] ____fput+0xc/0x18
> [ 339.617607] [<ffff0000080ed4e4>] task_work_run+0x9c/0xc0
> [ 339.617622] [<ffff000008089714>] do_notify_resume+0xfc/0x108
>
> Fix this by referencing gntdev on each DMA buffer export and
> unreferencing on buffer release.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Applied to xen/tip.git for-linus-5.1
Juergen
prev parent reply other threads:[~2019-02-17 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 14:23 Oleksandr Andrushchenko
2019-02-14 14:23 ` [Xen-devel][PATCH 2/2] xen/gntdev: Check and release imported dma-bufs on close Oleksandr Andrushchenko
2019-02-15 15:06 ` Boris Ostrovsky
2019-02-17 10:40 ` Juergen Gross
2019-02-15 15:03 ` [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use Boris Ostrovsky
2019-02-15 15:07 ` Oleksandr Andrushchenko
2019-02-15 15:28 ` Boris Ostrovsky
2019-02-15 15:35 ` Oleksandr Andrushchenko
2019-02-15 16:29 ` Juergen Gross
2019-02-17 10:39 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=302ff90b-32a9-58dd-ae8f-1b55813fed74@suse.com \
--to=jgross@suse.com \
--cc=andr2000@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®