mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomas Winkler <tomas.winkler@intel.com>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	Tomas Winkler <tomas.winkler@intel.com>
Subject: [char-misc-next 06/17] mei: bus: add kdoc for device attribute functions
Date: Sat, 13 Jun 2015 22:11:38 +0300	[thread overview]
Message-ID: <1434222709-10966-7-git-send-email-tomas.winkler@intel.com> (raw)
In-Reply-To: <1434222709-10966-1-git-send-email-tomas.winkler@intel.com>

1. Rename uevent handler to mei_cl_device_uevent
2. Add kdoc for uevent and mod alias functions

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 drivers/misc/mei/bus.c | 43 +++++++++++++++++++++++++++++++++++++++----
 1 file changed, 39 insertions(+), 4 deletions(-)

diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index b14662787d7e..201019c5f766 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -462,8 +462,17 @@ static int mei_cl_device_remove(struct device *dev)
 	return cldrv->remove(cldev);
 }
 
+/**
+ * name_show - client device name sysfs entry
+ *
+ * @dev: device
+ * @a: device attribute
+ * @buf: a buffer to fill
+ *
+ * Return: bytes to read or < 0 on error
+ */
 static ssize_t name_show(struct device *dev, struct device_attribute *a,
-			     char *buf)
+			 char *buf)
 {
 	struct mei_cl_device *cldev = to_mei_cl_device(dev);
 	size_t len;
@@ -474,8 +483,17 @@ static ssize_t name_show(struct device *dev, struct device_attribute *a,
 }
 static DEVICE_ATTR_RO(name);
 
+/**
+ * uuid_show - client uuid sysfs entry
+ *
+ * @dev: device
+ * @a: device attribute
+ * @buf: a buffer to fill
+ *
+ * Return: bytes to read or < 0 on error
+ */
 static ssize_t uuid_show(struct device *dev, struct device_attribute *a,
-			     char *buf)
+			 char *buf)
 {
 	struct mei_cl_device *cldev = to_mei_cl_device(dev);
 	const uuid_le *uuid = mei_me_cl_uuid(cldev->me_cl);
@@ -487,6 +505,15 @@ static ssize_t uuid_show(struct device *dev, struct device_attribute *a,
 }
 static DEVICE_ATTR_RO(uuid);
 
+/**
+ * modalias_show - modalias sysfs entry
+ *
+ * @dev: device
+ * @a: device attribute
+ * @buf: a buffer to fill
+ *
+ * Return: bytes to read or < 0 on error
+ */
 static ssize_t modalias_show(struct device *dev, struct device_attribute *a,
 			     char *buf)
 {
@@ -509,7 +536,15 @@ static struct attribute *mei_cl_dev_attrs[] = {
 };
 ATTRIBUTE_GROUPS(mei_cl_dev);
 
-static int mei_cl_uevent(struct device *dev, struct kobj_uevent_env *env)
+/**
+ * mei_cl_device_uevent - me client bus uevent handler
+ *
+ * @dev: device
+ * @env: uevent kobject
+ *
+ * Return: 0 on success -ENOMEM on when add_uevent_var fails
+ */
+static int mei_cl_device_uevent(struct device *dev, struct kobj_uevent_env *env)
 {
 	struct mei_cl_device *cldev = to_mei_cl_device(dev);
 	const uuid_le *uuid = mei_me_cl_uuid(cldev->me_cl);
@@ -533,7 +568,7 @@ static struct bus_type mei_cl_bus_type = {
 	.match		= mei_cl_device_match,
 	.probe		= mei_cl_device_probe,
 	.remove		= mei_cl_device_remove,
-	.uevent		= mei_cl_uevent,
+	.uevent		= mei_cl_device_uevent,
 };
 
 static void mei_cl_dev_release(struct device *dev)
-- 
2.4.2


  parent reply	other threads:[~2015-06-13 19:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-13 19:11 [char-misc-next 00/17] revamp mei bus Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 01/17] MAINTAINERS: mei: add mei_cl_bus.h to maintained file list Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 02/17] mei: bus: fix drivers and devices names confusion Tomas Winkler
2015-06-13 21:21   ` Greg KH
2015-06-14  6:30     ` Winkler, Tomas
2015-06-13 19:11 ` [char-misc-next 03/17] mei: bus: rename device_list to simple devices Tomas Winkler
2015-06-13 21:21   ` Greg KH
2015-06-13 19:11 ` [char-misc-next 04/17] mei: bus: rename nfc.c to bus-fixup.c Tomas Winkler
2015-06-13 21:22   ` Greg KH
2015-06-13 19:11 ` [char-misc-next 05/17] mei: bus: move driver api functions at the start of the file Tomas Winkler
2015-06-13 21:22   ` Greg KH
2015-06-13 19:11 ` Tomas Winkler [this message]
2015-06-13 21:23   ` [char-misc-next 06/17] mei: bus: add kdoc for device attribute functions Greg KH
2015-06-13 19:11 ` [char-misc-next 07/17] mei: bus: don't enable events implicitly in device enable Tomas Winkler
2015-06-13 21:24   ` Greg KH
2015-06-13 19:11 ` [char-misc-next 08/17] mei: bus: report if event registration failed Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 09/17] mei: bus: simplify device matching Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 10/17] mei: bus: revamp probe and remove functions Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 11/17] mei: bus: add reference to bus device in struct mei_cl_client Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 12/17] mei: bus: add me client device list infrastructure Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 13/17] mei: bus: enable running fixup routines before device registration Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 14/17] mei: bus: blacklist clients by number of connections and nfc info client Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 15/17] mei: bus: simplify how we build nfc bus name Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 16/17] mei: bus: also unregister the driver when removing the device Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 17/17] mei: bus: link client devices instead of host clients Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434222709-10966-7-git-send-email-tomas.winkler@intel.com \
    --to=tomas.winkler@intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®