From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next 02/17] mei: bus: fix drivers and devices names confusion
Date: Sat, 13 Jun 2015 14:21:16 -0700 [thread overview]
Message-ID: <20150613212116.GA13609@kroah.com> (raw)
In-Reply-To: <1434222709-10966-3-git-send-email-tomas.winkler@intel.com>
On Sat, Jun 13, 2015 at 10:11:34PM +0300, Tomas Winkler wrote:
> the variables of type mei_cl_device are now cldev
> the variables of type mei_cl_driver are now cldrv
You are saying what you did, but not why you are doing it. Renaming
variables for no good reason means I have to reject this patch, sorry.
> the variables of type mei_device are now bus in the
> bus layer context
What do you mean by this?
greg k-h
next prev parent reply other threads:[~2015-06-13 21:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 19:11 [char-misc-next 00/17] revamp mei bus Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 01/17] MAINTAINERS: mei: add mei_cl_bus.h to maintained file list Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 02/17] mei: bus: fix drivers and devices names confusion Tomas Winkler
2015-06-13 21:21 ` Greg KH [this message]
2015-06-14 6:30 ` Winkler, Tomas
2015-06-13 19:11 ` [char-misc-next 03/17] mei: bus: rename device_list to simple devices Tomas Winkler
2015-06-13 21:21 ` Greg KH
2015-06-13 19:11 ` [char-misc-next 04/17] mei: bus: rename nfc.c to bus-fixup.c Tomas Winkler
2015-06-13 21:22 ` Greg KH
2015-06-13 19:11 ` [char-misc-next 05/17] mei: bus: move driver api functions at the start of the file Tomas Winkler
2015-06-13 21:22 ` Greg KH
2015-06-13 19:11 ` [char-misc-next 06/17] mei: bus: add kdoc for device attribute functions Tomas Winkler
2015-06-13 21:23 ` Greg KH
2015-06-13 19:11 ` [char-misc-next 07/17] mei: bus: don't enable events implicitly in device enable Tomas Winkler
2015-06-13 21:24 ` Greg KH
2015-06-13 19:11 ` [char-misc-next 08/17] mei: bus: report if event registration failed Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 09/17] mei: bus: simplify device matching Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 10/17] mei: bus: revamp probe and remove functions Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 11/17] mei: bus: add reference to bus device in struct mei_cl_client Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 12/17] mei: bus: add me client device list infrastructure Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 13/17] mei: bus: enable running fixup routines before device registration Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 14/17] mei: bus: blacklist clients by number of connections and nfc info client Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 15/17] mei: bus: simplify how we build nfc bus name Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 16/17] mei: bus: also unregister the driver when removing the device Tomas Winkler
2015-06-13 19:11 ` [char-misc-next 17/17] mei: bus: link client devices instead of host clients Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150613212116.GA13609@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®