mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8192u: ieee80211: Fix incorrect type in assignment
@ 2015-06-14 22:59 Gaston Gonzalez
  0 siblings, 0 replies; only message in thread
From: Gaston Gonzalez @ 2015-06-14 22:59 UTC (permalink / raw)
  To: gregkh
  Cc: cristina.opriceana, gdonald, hamohammed.sa, mahfouz.saif.elyazal,
	paul.gortmaker, devel, linux-kernel, gascoar

Added le16_to_cpu() conversion fixing the following warning in assignment detected by sparse: 

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30: warning: invalid assignment: +=
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30:    left side has type unsigned long
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30:    right side has type restricted __le16

Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
---
 I wonder if this is the best approach, making payload_size u16 in ieee80211.h would fix this plus other three sparse warnings. Could we make payload_size u16 or it must be definitely le16?

 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index 5fbade4..1b11acb 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -2154,7 +2154,7 @@ void ieee80211_softmac_xmit(struct ieee80211_txb *txb, struct ieee80211_device *
 	ieee80211_sta_wakeup(ieee, 0);
 
 	/* update the tx status */
-	ieee->stats.tx_bytes += txb->payload_size;
+	ieee->stats.tx_bytes += le16_to_cpu(txb->payload_size);
 	ieee->stats.tx_packets++;
 	tcb_desc = (cb_desc *)(txb->fragments[0]->cb + MAX_DEV_ADDR_SIZE);
 	if (tcb_desc->bMulticast) {
-- 
2.4.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-06-14 23:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-14 22:59 [PATCH] staging: rtl8192u: ieee80211: Fix incorrect type in assignment Gaston Gonzalez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®