mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, dmatlack@google.com,
	Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: [PATCH v2 00/15] vMTRR bugfix and optimization
Date: Mon, 15 Jun 2015 16:55:20 +0800	[thread overview]
Message-ID: <1434358535-19923-1-git-send-email-guangrong.xiao@linux.intel.com> (raw)

Changlog:
- let's fix the bugs for noncoherent_dma guests first

- these changes are from Paolo's review
  1) use inline functions instead of union definition for 'struct kvm_mtrr'
  2) improve code style
  3) fix fixed_msr_to_range_index which does not return the actual value
  4) introduce kvm_set_var_mtrr() to make the code more clearer
  5) improve mtrr_for_each_mem_type() APIs and clean it up
  6) drop @unit_size in 'struct fixed_mtrr_segment'

- these changes are from David Matlack's review
  1) improve comment
  2) fix fixed_mtrr_range_end_addr that did not count entries correctly
  

There are some bugs in current code if noncoherent_dma is detected:
- KVM still uses hugepage even if the 4K pages in that ranges span between
  on different memory types and uses the cache type of first page to do memory
  mapping
  
- CR0.CD is not checked so that guest memory is not UC as it expected  

This patchset fixes these bugs and also do optimization and cleanups.

Xiao Guangrong (15):
  KVM: x86: fix CR0.CD virtualization
  KVM: x86: move MTRR related code to a separate file
  KVM: MTRR: handle MSR_MTRRcap in kvm_mtrr_get_msr
  KVM: MTRR: remove mtrr_state.have_fixed
  KVM: MTRR: exactly define the size of variable MTRRs
  KVM: MTRR: clean up mtrr default type
  KVM: MTRR: do not split 64 bits MSR content
  KVM: MTRR: improve kvm_mtrr_get_guest_memory_type
  KVM: MTRR: introduce fixed_mtrr_segment table
  KVM: MTRR: introduce var_mtrr_range
  KVM: MTRR: sort variable MTRRs
  KVM: MTRR: introduce fixed_mtrr_addr_* functions
  KVM: MTRR: introduce mtrr_for_each_mem_type
  KVM: MTRR: simplify kvm_mtrr_get_guest_memory_type
  KVM: MTRR: do not map huage page for non-consistent range

 arch/x86/include/asm/kvm_host.h |  17 +-
 arch/x86/kvm/Makefile           |   2 +-
 arch/x86/kvm/mmu.c              | 123 ++-----
 arch/x86/kvm/mtrr.c             | 708 ++++++++++++++++++++++++++++++++++++++++
 arch/x86/kvm/vmx.c              |  32 +-
 arch/x86/kvm/x86.c              | 223 +------------
 arch/x86/kvm/x86.h              |   6 +
 7 files changed, 778 insertions(+), 333 deletions(-)
 create mode 100644 arch/x86/kvm/mtrr.c

-- 
2.1.0


             reply	other threads:[~2015-06-15  9:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15  8:55 Xiao Guangrong [this message]
2015-06-15  8:55 ` [PATCH v2 01/15] KVM: x86: fix CR0.CD virtualization Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 02/15] KVM: x86: move MTRR related code to a separate file Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 03/15] KVM: MTRR: handle MSR_MTRRcap in kvm_mtrr_get_msr Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 04/15] KVM: MTRR: remove mtrr_state.have_fixed Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 05/15] KVM: MTRR: exactly define the size of variable MTRRs Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 06/15] KVM: MTRR: clean up mtrr default type Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 07/15] KVM: MTRR: do not split 64 bits MSR content Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 08/15] KVM: MTRR: improve kvm_mtrr_get_guest_memory_type Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 09/15] KVM: MTRR: introduce fixed_mtrr_segment table Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 10/15] KVM: MTRR: introduce var_mtrr_range Xiao Guangrong
2015-06-17 15:38   ` Paolo Bonzini
2015-06-15  8:55 ` [PATCH v2 11/15] KVM: MTRR: sort variable MTRRs Xiao Guangrong
2015-06-17 15:40   ` Paolo Bonzini
2015-06-17 16:11   ` Paolo Bonzini
2015-06-22 11:24     ` Paolo Bonzini
2015-06-23  2:29       ` Xiao Guangrong
2015-06-23  8:00         ` Paolo Bonzini
2015-06-23  8:27           ` Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 12/15] KVM: MTRR: introduce fixed_mtrr_addr_* functions Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 13/15] KVM: MTRR: introduce mtrr_for_each_mem_type Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 14/15] KVM: MTRR: simplify kvm_mtrr_get_guest_memory_type Xiao Guangrong
2015-06-15  8:55 ` [PATCH v2 15/15] KVM: MTRR: do not map huage page for non-consistent range Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434358535-19923-1-git-send-email-guangrong.xiao@linux.intel.com \
    --to=guangrong.xiao@linux.intel.com \
    --cc=dmatlack@google.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®