From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, dmatlack@google.com,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: [PATCH v2 01/15] KVM: x86: fix CR0.CD virtualization
Date: Mon, 15 Jun 2015 16:55:21 +0800 [thread overview]
Message-ID: <1434358535-19923-2-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1434358535-19923-1-git-send-email-guangrong.xiao@linux.intel.com>
Currently, CR0.CD is not checked when we virtualize memory cache type for
noncoherent_dma guests, this patch fixes it by :
- setting UC for all memory if CR0.CD = 1
- zapping all the last sptes in MMU if CR0.CD is changed
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
arch/x86/kvm/vmx.c | 32 ++++++++++++++++++++++----------
arch/x86/kvm/x86.c | 4 ++++
2 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 06a186b..2764381 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -8628,7 +8628,8 @@ static int get_ept_level(void)
static u64 vmx_get_mt_mask(struct kvm_vcpu *vcpu, gfn_t gfn, bool is_mmio)
{
- u64 ret;
+ u8 cache;
+ u64 ipat = 0;
/* For VT-d and EPT combination
* 1. MMIO: always map as UC
@@ -8641,16 +8642,27 @@ static u64 vmx_get_mt_mask(struct kvm_vcpu *vcpu, gfn_t gfn, bool is_mmio)
* 3. EPT without VT-d: always map as WB and set IPAT=1 to keep
* consistent with host MTRR
*/
- if (is_mmio)
- ret = MTRR_TYPE_UNCACHABLE << VMX_EPT_MT_EPTE_SHIFT;
- else if (kvm_arch_has_noncoherent_dma(vcpu->kvm))
- ret = kvm_get_guest_memory_type(vcpu, gfn) <<
- VMX_EPT_MT_EPTE_SHIFT;
- else
- ret = (MTRR_TYPE_WRBACK << VMX_EPT_MT_EPTE_SHIFT)
- | VMX_EPT_IPAT_BIT;
+ if (is_mmio) {
+ cache = MTRR_TYPE_UNCACHABLE;
+ goto exit;
+ }
- return ret;
+ if (!kvm_arch_has_noncoherent_dma(vcpu->kvm)) {
+ ipat = VMX_EPT_IPAT_BIT;
+ cache = MTRR_TYPE_WRBACK;
+ goto exit;
+ }
+
+ if (kvm_read_cr0(vcpu) & X86_CR0_CD) {
+ ipat = VMX_EPT_IPAT_BIT;
+ cache = MTRR_TYPE_UNCACHABLE;
+ goto exit;
+ }
+
+ cache = kvm_get_guest_memory_type(vcpu, gfn);
+
+exit:
+ return (cache << VMX_EPT_MT_EPTE_SHIFT) | ipat;
}
static int vmx_get_lpage_level(void)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 43f0df7..43fdb10 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -621,6 +621,10 @@ int kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
if ((cr0 ^ old_cr0) & update_bits)
kvm_mmu_reset_context(vcpu);
+
+ if ((cr0 ^ old_cr0) & X86_CR0_CD)
+ kvm_zap_gfn_range(vcpu->kvm, 0, ~0ULL);
+
return 0;
}
EXPORT_SYMBOL_GPL(kvm_set_cr0);
--
2.1.0
next prev parent reply other threads:[~2015-06-15 9:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 8:55 [PATCH v2 00/15] vMTRR bugfix and optimization Xiao Guangrong
2015-06-15 8:55 ` Xiao Guangrong [this message]
2015-06-15 8:55 ` [PATCH v2 02/15] KVM: x86: move MTRR related code to a separate file Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 03/15] KVM: MTRR: handle MSR_MTRRcap in kvm_mtrr_get_msr Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 04/15] KVM: MTRR: remove mtrr_state.have_fixed Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 05/15] KVM: MTRR: exactly define the size of variable MTRRs Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 06/15] KVM: MTRR: clean up mtrr default type Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 07/15] KVM: MTRR: do not split 64 bits MSR content Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 08/15] KVM: MTRR: improve kvm_mtrr_get_guest_memory_type Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 09/15] KVM: MTRR: introduce fixed_mtrr_segment table Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 10/15] KVM: MTRR: introduce var_mtrr_range Xiao Guangrong
2015-06-17 15:38 ` Paolo Bonzini
2015-06-15 8:55 ` [PATCH v2 11/15] KVM: MTRR: sort variable MTRRs Xiao Guangrong
2015-06-17 15:40 ` Paolo Bonzini
2015-06-17 16:11 ` Paolo Bonzini
2015-06-22 11:24 ` Paolo Bonzini
2015-06-23 2:29 ` Xiao Guangrong
2015-06-23 8:00 ` Paolo Bonzini
2015-06-23 8:27 ` Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 12/15] KVM: MTRR: introduce fixed_mtrr_addr_* functions Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 13/15] KVM: MTRR: introduce mtrr_for_each_mem_type Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 14/15] KVM: MTRR: simplify kvm_mtrr_get_guest_memory_type Xiao Guangrong
2015-06-15 8:55 ` [PATCH v2 15/15] KVM: MTRR: do not map huage page for non-consistent range Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434358535-19923-2-git-send-email-guangrong.xiao@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dmatlack@google.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®