From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 15/15] staging: rtl8192e: Remove rtllib_device::agregation
Date: Mon, 15 Jun 2015 21:06:10 +0200 [thread overview]
Message-ID: <1434395170-13903-16-git-send-email-mateusz.kulikowski@gmail.com> (raw)
In-Reply-To: <1434395170-13903-1-git-send-email-mateusz.kulikowski@gmail.com>
Variable is always true; Resolve condition where it is used
(and change indentation of conditional expression).
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
drivers/staging/rtl8192e/rtllib.h | 1 -
drivers/staging/rtl8192e/rtllib_rx.c | 52 ++++++++++++++-----------------
drivers/staging/rtl8192e/rtllib_softmac.c | 1 -
3 files changed, 24 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 74c2a28..fd38c6d 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1758,7 +1758,6 @@ struct rtllib_device {
u8 AsocRetryCount;
struct sk_buff_head skb_waitQ[MAX_QUEUE_SIZE];
struct sk_buff_head skb_aggQ[MAX_QUEUE_SIZE];
- bool aggregation;
bool bdynamic_txpower_enable;
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 48a188a..da862c3 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -1883,38 +1883,34 @@ static void rtllib_parse_mife_generic(struct rtllib_device *ieee,
}
}
- if (ieee->aggregation) {
- if (network->bssht.bdSupportHT) {
- if (info_element->len >= 4 &&
- info_element->data[0] == 0x00 &&
- info_element->data[1] == 0xe0 &&
- info_element->data[2] == 0x4c &&
- info_element->data[3] == 0x02) {
- ht_realtek_agg_len = min_t(u8,
- info_element->len,
- MAX_IE_LEN);
- memcpy(ht_realtek_agg_buf,
- info_element->data,
- info_element->len);
- }
- if (ht_realtek_agg_len >= 5) {
- network->realtek_cap_exit = true;
- network->bssht.bdRT2RTAggregation = true;
-
- if ((ht_realtek_agg_buf[4] == 1) &&
- (ht_realtek_agg_buf[5] & 0x02))
- network->bssht.bdRT2RTLongSlotTime = true;
-
- if ((ht_realtek_agg_buf[4] == 1) &&
- (ht_realtek_agg_buf[5] & RT_HT_CAP_USE_92SE))
- network->bssht.RT2RT_HT_Mode |= RT_HT_CAP_USE_92SE;
- }
+ if (network->bssht.bdSupportHT) {
+ if (info_element->len >= 4 &&
+ info_element->data[0] == 0x00 &&
+ info_element->data[1] == 0xe0 &&
+ info_element->data[2] == 0x4c &&
+ info_element->data[3] == 0x02) {
+ ht_realtek_agg_len = min_t(u8, info_element->len,
+ MAX_IE_LEN);
+ memcpy(ht_realtek_agg_buf, info_element->data,
+ info_element->len);
}
if (ht_realtek_agg_len >= 5) {
- if ((ht_realtek_agg_buf[5] & RT_HT_CAP_USE_SOFTAP))
- network->bssht.RT2RT_HT_Mode |= RT_HT_CAP_USE_SOFTAP;
+ network->realtek_cap_exit = true;
+ network->bssht.bdRT2RTAggregation = true;
+
+ if ((ht_realtek_agg_buf[4] == 1) &&
+ (ht_realtek_agg_buf[5] & 0x02))
+ network->bssht.bdRT2RTLongSlotTime = true;
+
+ if ((ht_realtek_agg_buf[4] == 1) &&
+ (ht_realtek_agg_buf[5] & RT_HT_CAP_USE_92SE))
+ network->bssht.RT2RT_HT_Mode |= RT_HT_CAP_USE_92SE;
}
}
+ if (ht_realtek_agg_len >= 5) {
+ if ((ht_realtek_agg_buf[5] & RT_HT_CAP_USE_SOFTAP))
+ network->bssht.RT2RT_HT_Mode |= RT_HT_CAP_USE_SOFTAP;
+ }
if ((info_element->len >= 3 &&
info_element->data[0] == 0x00 &&
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 3f4a932..444fac7 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -3017,7 +3017,6 @@ void rtllib_softmac_init(struct rtllib_device *ieee)
ieee->is_set_key = false;
init_mgmt_queue(ieee);
- ieee->aggregation = true;
ieee->tx_pending.txb = NULL;
_setup_timer(&ieee->associate_timer,
--
1.8.4.1
prev parent reply other threads:[~2015-06-15 19:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 19:05 [PATCH v2 00/15] staging: rtl8192e: Remove unused code Mateusz Kulikowski
2015-06-15 19:05 ` [PATCH v2 01/15] staging: rtl8192e: Remove unused code in rtl819x_HT.h Mateusz Kulikowski
2015-06-15 19:05 ` [PATCH v2 02/15] staging: rtl8192e: Remove unused code in rtllib.h Mateusz Kulikowski
2015-06-15 19:05 ` [PATCH v2 03/15] staging: rtl8192e: Remove rt_hi_throughput::ChnkOp Mateusz Kulikowski
2015-06-15 19:05 ` [PATCH v2 04/15] staging: rtl8192e: Remove ENABLE_LOCK_DEBUG reference Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 05/15] staging: rtl8192e: Remove rtllib_stop_queue() Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 06/15] staging: rtl8192e: Remove rtllib_wake_queue() Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 07/15] staging: rtl8192e: Remove rtllib_is_shortslot() Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 08/15] staging: rtl8192e: Remove rtllib_wx_get_encode_ext() Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 09/15] staging: rtl8192e: Remove rtllib_device::get_nic_desc_num() Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 10/15] staging: rtl8192e: Remove WIRELESS_EXT checks Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 11/15] staging: rtl8192e: Remove rtllib_network::last_associate Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 12/15] staging: rtl8192e: Remove rt_pwr_save_ctrl members Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 13/15] staging: rtl8192e: Remove unused rtllib_device members Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 14/15] staging: rtl8192e: Remove softmac_hint11d_wq queue Mateusz Kulikowski
2015-06-15 19:06 ` Mateusz Kulikowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434395170-13903-16-git-send-email-mateusz.kulikowski@gmail.com \
--to=mateusz.kulikowski@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®