From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 06/15] staging: rtl8192e: Remove rtllib_wake_queue()
Date: Mon, 15 Jun 2015 21:06:01 +0200 [thread overview]
Message-ID: <1434395170-13903-7-git-send-email-mateusz.kulikowski@gmail.com> (raw)
In-Reply-To: <1434395170-13903-1-git-send-email-mateusz.kulikowski@gmail.com>
This function was declared but never unused.
Also remove dequeue_mgmt() and rtllib_resume_tx() that are
no longer used.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
drivers/staging/rtl8192e/rtllib.h | 1 -
drivers/staging/rtl8192e/rtllib_softmac.c | 80 -------------------------------
2 files changed, 81 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 2931733..b4eb24e 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -2219,7 +2219,6 @@ extern void rtllib_softmac_start_protocol(struct rtllib_device *ieee,
u8 mesh_flag);
extern void rtllib_reset_queue(struct rtllib_device *ieee);
-extern void rtllib_wake_queue(struct rtllib_device *ieee);
extern void rtllib_wake_all_queues(struct rtllib_device *ieee);
extern void rtllib_stop_all_queues(struct rtllib_device *ieee);
extern struct sk_buff *rtllib_get_beacon(struct rtllib_device *ieee);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 95e739e..a123772 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -147,21 +147,6 @@ static void enqueue_mgmt(struct rtllib_device *ieee, struct sk_buff *skb)
}
-static struct sk_buff *dequeue_mgmt(struct rtllib_device *ieee)
-{
- struct sk_buff *ret;
-
- if (ieee->mgmt_queue_tail == ieee->mgmt_queue_head)
- return NULL;
-
- ret = ieee->mgmt_queue_ring[ieee->mgmt_queue_tail];
-
- ieee->mgmt_queue_tail =
- (ieee->mgmt_queue_tail+1) % MGMT_QUEUE_NUM;
-
- return ret;
-}
-
static void init_mgmt_queue(struct rtllib_device *ieee)
{
ieee->mgmt_queue_tail = ieee->mgmt_queue_head = 0;
@@ -2532,30 +2517,6 @@ void rtllib_softmac_xmit(struct rtllib_txb *txb, struct rtllib_device *ieee)
}
-/* called with ieee->lock acquired */
-static void rtllib_resume_tx(struct rtllib_device *ieee)
-{
- int i;
-
- for (i = ieee->tx_pending.frag; i < ieee->tx_pending.txb->nr_frags;
- i++) {
-
- if (ieee->queue_stop) {
- ieee->tx_pending.frag = i;
- return;
- }
-
- ieee->softmac_data_hard_start_xmit(
- ieee->tx_pending.txb->fragments[i],
- ieee->dev, ieee->rate);
- ieee->stats.tx_packets++;
- }
-
- rtllib_txb_free(ieee->tx_pending.txb);
- ieee->tx_pending.txb = NULL;
-}
-
-
void rtllib_reset_queue(struct rtllib_device *ieee)
{
unsigned long flags;
@@ -2572,47 +2533,6 @@ void rtllib_reset_queue(struct rtllib_device *ieee)
}
EXPORT_SYMBOL(rtllib_reset_queue);
-void rtllib_wake_queue(struct rtllib_device *ieee)
-{
-
- unsigned long flags;
- struct sk_buff *skb;
- struct rtllib_hdr_3addr *header;
-
- spin_lock_irqsave(&ieee->lock, flags);
- if (!ieee->queue_stop)
- goto exit;
-
- ieee->queue_stop = 0;
-
- if (ieee->softmac_features & IEEE_SOFTMAC_SINGLE_QUEUE) {
- while (!ieee->queue_stop && (skb = dequeue_mgmt(ieee))) {
-
- header = (struct rtllib_hdr_3addr *) skb->data;
-
- header->seq_ctl = cpu_to_le16(ieee->seq_ctrl[0] << 4);
-
- if (ieee->seq_ctrl[0] == 0xFFF)
- ieee->seq_ctrl[0] = 0;
- else
- ieee->seq_ctrl[0]++;
-
- ieee->softmac_data_hard_start_xmit(skb, ieee->dev,
- ieee->basic_rate);
- }
- }
- if (!ieee->queue_stop && ieee->tx_pending.txb)
- rtllib_resume_tx(ieee);
-
- if (!ieee->queue_stop && netif_queue_stopped(ieee->dev)) {
- ieee->softmac_stats.swtxawake++;
- netif_wake_queue(ieee->dev);
- }
-
-exit:
- spin_unlock_irqrestore(&ieee->lock, flags);
-}
-
void rtllib_stop_all_queues(struct rtllib_device *ieee)
{
unsigned int i;
--
1.8.4.1
next prev parent reply other threads:[~2015-06-15 19:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 19:05 [PATCH v2 00/15] staging: rtl8192e: Remove unused code Mateusz Kulikowski
2015-06-15 19:05 ` [PATCH v2 01/15] staging: rtl8192e: Remove unused code in rtl819x_HT.h Mateusz Kulikowski
2015-06-15 19:05 ` [PATCH v2 02/15] staging: rtl8192e: Remove unused code in rtllib.h Mateusz Kulikowski
2015-06-15 19:05 ` [PATCH v2 03/15] staging: rtl8192e: Remove rt_hi_throughput::ChnkOp Mateusz Kulikowski
2015-06-15 19:05 ` [PATCH v2 04/15] staging: rtl8192e: Remove ENABLE_LOCK_DEBUG reference Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 05/15] staging: rtl8192e: Remove rtllib_stop_queue() Mateusz Kulikowski
2015-06-15 19:06 ` Mateusz Kulikowski [this message]
2015-06-15 19:06 ` [PATCH v2 07/15] staging: rtl8192e: Remove rtllib_is_shortslot() Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 08/15] staging: rtl8192e: Remove rtllib_wx_get_encode_ext() Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 09/15] staging: rtl8192e: Remove rtllib_device::get_nic_desc_num() Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 10/15] staging: rtl8192e: Remove WIRELESS_EXT checks Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 11/15] staging: rtl8192e: Remove rtllib_network::last_associate Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 12/15] staging: rtl8192e: Remove rt_pwr_save_ctrl members Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 13/15] staging: rtl8192e: Remove unused rtllib_device members Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 14/15] staging: rtl8192e: Remove softmac_hint11d_wq queue Mateusz Kulikowski
2015-06-15 19:06 ` [PATCH v2 15/15] staging: rtl8192e: Remove rtllib_device::agregation Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434395170-13903-7-git-send-email-mateusz.kulikowski@gmail.com \
--to=mateusz.kulikowski@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®