* [PATCH] Staging: rts5208: fix CHANGE_LINK_STATE value
@ 2015-06-19 15:12 Fabio Falzoi
2015-06-19 15:17 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Falzoi @ 2015-06-19 15:12 UTC (permalink / raw)
To: gregkh; +Cc: micky_ching, joe, dan.carpenter, devel, linux-kernel, Fabio Falzoi
Fix CHANGE_LINK_STATE value when card_exist is true.
This bug was introduced in a9b693cd77d70fb93dad8cbce667a49cd9b87352
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
index d6fb6cd..0df3b9d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -1337,7 +1337,7 @@ static void rtsx_delink_stage1(struct rtsx_chip *chip, int enter_L1,
rtsx_write_register(chip, HOST_SLEEP_STATE, 0x03, 1);
if (chip->card_exist)
- val = 0x03;
+ val = 0x02;
else
val = 0x0A;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: rts5208: fix CHANGE_LINK_STATE value
2015-06-19 15:12 [PATCH] Staging: rts5208: fix CHANGE_LINK_STATE value Fabio Falzoi
@ 2015-06-19 15:17 ` Joe Perches
2015-06-19 15:44 ` [PATCH v2] " Fabio Falzoi
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2015-06-19 15:17 UTC (permalink / raw)
To: Fabio Falzoi; +Cc: gregkh, micky_ching, dan.carpenter, devel, linux-kernel
On Fri, 2015-06-19 at 17:12 +0200, Fabio Falzoi wrote:
> Fix CHANGE_LINK_STATE value when card_exist is true.
> This bug was introduced in a9b693cd77d70fb93dad8cbce667a49cd9b87352
Please use just 12 byte of the SHA-1 and add the title:
Something like:
This bug was introduced in commit a9b693cd77d7 ("Staging:
rts5208: helper function to manage delink states")
Maybe add a "Fixes: " line instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] Staging: rts5208: fix CHANGE_LINK_STATE value
2015-06-19 15:17 ` Joe Perches
@ 2015-06-19 15:44 ` Fabio Falzoi
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Falzoi @ 2015-06-19 15:44 UTC (permalink / raw)
To: gregkh; +Cc: joe, dan.carpente, devel, linux-kernel, Fabio Falzoi
Fix CHANGE_LINK_STATE value when card_exist is true.
Fixes: a9b693cd77d7 ("Staging: rts5208: helper function to manage delink states")
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
index d6fb6cd..0df3b9d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -1337,7 +1337,7 @@ static void rtsx_delink_stage1(struct rtsx_chip *chip, int enter_L1,
rtsx_write_register(chip, HOST_SLEEP_STATE, 0x03, 1);
if (chip->card_exist)
- val = 0x03;
+ val = 0x02;
else
val = 0x0A;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-19 15:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-19 15:12 [PATCH] Staging: rts5208: fix CHANGE_LINK_STATE value Fabio Falzoi
2015-06-19 15:17 ` Joe Perches
2015-06-19 15:44 ` [PATCH v2] " Fabio Falzoi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome