* [PATCH 1/2] perf tools: Print a newline when dumping PERF_RECORD_FINISHED_ROUND
@ 2015-06-23 7:52 Adrian Hunter
2015-06-23 7:52 ` [PATCH 2/2] perf tools: Print a newline before dumping Aggregated stats Adrian Hunter
2015-06-25 7:57 ` [tip:perf/core] perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND tip-bot for Adrian Hunter
0 siblings, 2 replies; 4+ messages in thread
From: Adrian Hunter @ 2015-06-23 7:52 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: linux-kernel, Jiri Olsa
With 'perf report -D' the PERF_RECORD_FINISHED_ROUND
event was printed without a newline, resulting in:
0x91a18 [0x8]: PERF_RECORD_FINISHED_ROUNDAggregated stats
Other events print their details, but PERF_RECORD_FINISHED_ROUND
doesn't have any so just add a print for a newline.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/util/session.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index aa482c10469d..aac1c4cee1e8 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -686,6 +686,8 @@ static int process_finished_round(struct perf_tool *tool __maybe_unused,
union perf_event *event __maybe_unused,
struct ordered_events *oe)
{
+ if (dump_trace)
+ fprintf(stdout, "\n");
return ordered_events__flush(oe, OE_FLUSH__ROUND);
}
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] perf tools: Print a newline before dumping Aggregated stats
2015-06-23 7:52 [PATCH 1/2] perf tools: Print a newline when dumping PERF_RECORD_FINISHED_ROUND Adrian Hunter
@ 2015-06-23 7:52 ` Adrian Hunter
2015-06-25 7:57 ` [tip:perf/core] " tip-bot for Adrian Hunter
2015-06-25 7:57 ` [tip:perf/core] perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND tip-bot for Adrian Hunter
1 sibling, 1 reply; 4+ messages in thread
From: Adrian Hunter @ 2015-06-23 7:52 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: linux-kernel, Jiri Olsa
When dumping events with 'perf report -D' the event print
always starts with a newline (see dump_event()). Do the
same with the "Aggregated stats" print so that it is not
jammed up against the last event print.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/util/session.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index aac1c4cee1e8..b5549b58bb2b 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1728,7 +1728,7 @@ size_t perf_session__fprintf_nr_events(struct perf_session *session, FILE *fp)
if (perf_header__has_feat(&session->header, HEADER_AUXTRACE))
msg = " (excludes AUX area (e.g. instruction trace) decoded / synthesized events)";
- ret = fprintf(fp, "Aggregated stats:%s\n", msg);
+ ret = fprintf(fp, "\nAggregated stats:%s\n", msg);
ret += events_stats__fprintf(&session->evlist->stats, fp);
return ret;
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/core] perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND
2015-06-23 7:52 [PATCH 1/2] perf tools: Print a newline when dumping PERF_RECORD_FINISHED_ROUND Adrian Hunter
2015-06-23 7:52 ` [PATCH 2/2] perf tools: Print a newline before dumping Aggregated stats Adrian Hunter
@ 2015-06-25 7:57 ` tip-bot for Adrian Hunter
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Adrian Hunter @ 2015-06-25 7:57 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, hpa, mingo, acme, jolsa, adrian.hunter, linux-kernel
Commit-ID: 5531e16227cc18bc13b028a052a609a233b49c07
Gitweb: http://git.kernel.org/tip/5531e16227cc18bc13b028a052a609a233b49c07
Author: Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Tue, 23 Jun 2015 10:52:48 +0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 23 Jun 2015 18:21:43 -0300
perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND
With 'perf report -D' the PERF_RECORD_FINISHED_ROUND event was printed
without a newline, resulting in:
0x91a18 [0x8]: PERF_RECORD_FINISHED_ROUNDAggregated stats
Other events print their details, but PERF_RECORD_FINISHED_ROUND doesn't
have any so just add a print for a newline.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1435045969-15999-1-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/session.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index aa482c1..aac1c4c 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -686,6 +686,8 @@ static int process_finished_round(struct perf_tool *tool __maybe_unused,
union perf_event *event __maybe_unused,
struct ordered_events *oe)
{
+ if (dump_trace)
+ fprintf(stdout, "\n");
return ordered_events__flush(oe, OE_FLUSH__ROUND);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/core] perf tools: Print a newline before dumping Aggregated stats
2015-06-23 7:52 ` [PATCH 2/2] perf tools: Print a newline before dumping Aggregated stats Adrian Hunter
@ 2015-06-25 7:57 ` tip-bot for Adrian Hunter
0 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Adrian Hunter @ 2015-06-25 7:57 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, linux-kernel, adrian.hunter, jolsa, tglx, hpa, acme
Commit-ID: fe692ac86adbbbbf9745909aafe0c87fd7fc6368
Gitweb: http://git.kernel.org/tip/fe692ac86adbbbbf9745909aafe0c87fd7fc6368
Author: Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Tue, 23 Jun 2015 10:52:49 +0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 23 Jun 2015 18:21:43 -0300
perf tools: Print a newline before dumping Aggregated stats
When dumping events with 'perf report -D' the event print always starts
with a newline (see dump_event()).
Do the same with the "Aggregated stats" print so that it is not jammed
up against the last event print.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1435045969-15999-2-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/session.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index aac1c4c..b5549b5 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1728,7 +1728,7 @@ size_t perf_session__fprintf_nr_events(struct perf_session *session, FILE *fp)
if (perf_header__has_feat(&session->header, HEADER_AUXTRACE))
msg = " (excludes AUX area (e.g. instruction trace) decoded / synthesized events)";
- ret = fprintf(fp, "Aggregated stats:%s\n", msg);
+ ret = fprintf(fp, "\nAggregated stats:%s\n", msg);
ret += events_stats__fprintf(&session->evlist->stats, fp);
return ret;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-25 7:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-23 7:52 [PATCH 1/2] perf tools: Print a newline when dumping PERF_RECORD_FINISHED_ROUND Adrian Hunter
2015-06-23 7:52 ` [PATCH 2/2] perf tools: Print a newline before dumping Aggregated stats Adrian Hunter
2015-06-25 7:57 ` [tip:perf/core] " tip-bot for Adrian Hunter
2015-06-25 7:57 ` [tip:perf/core] perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND tip-bot for Adrian Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®