From: Joe Perches <joe@perches.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Kan Liang <kan.liang@intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH perf/core] perf tools: Add missing break for PERF_RECORD_ITRACE_START
Date: Mon, 29 Jun 2015 04:23:29 -0700 [thread overview]
Message-ID: <1435577009.9587.53.camel@perches.com> (raw)
In-Reply-To: <1435576340-19346-1-git-send-email-jolsa@kernel.org>
On Mon, 2015-06-29 at 13:12 +0200, Jiri Olsa wrote:
> Missing switch break since introduction of new event:
> c4937a91ea56 perf tools: handle PERF_RECORD_LOST_SAMPLES
[]
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
[]
> @@ -1448,7 +1448,7 @@ int machine__process_event(struct machine *machine, union perf_event *event,
> case PERF_RECORD_AUX:
> ret = machine__process_aux_event(machine, event); break;
> case PERF_RECORD_ITRACE_START:
> - ret = machine__process_itrace_start_event(machine, event);
> + ret = machine__process_itrace_start_event(machine, event); break;
> case PERF_RECORD_LOST_SAMPLES:
> ret = machine__process_lost_samples_event(machine, event, sample); break;
> break;
trivia: There's a duplicate/unreachable break;
on the PERF_RECORD_LOST_SAMPLES case
prev parent reply other threads:[~2015-06-29 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 11:12 Jiri Olsa
2015-06-29 11:17 ` Adrian Hunter
2015-06-29 11:27 ` [PATCHv2 " Jiri Olsa
2015-06-29 20:17 ` Arnaldo Carvalho de Melo
2015-07-03 7:47 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2015-06-29 11:47 ` [PATCH perf/core] " Peter Zijlstra
2015-06-29 13:05 ` Arnaldo Carvalho de Melo
2015-06-29 11:23 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435577009.9587.53.camel@perches.com \
--to=joe@perches.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome