mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Kan Liang <kan.liang@intel.com>,
	lkml <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCHv2 perf/core] perf tools: Add missing break for PERF_RECORD_ITRACE_START
Date: Mon, 29 Jun 2015 17:17:56 -0300	[thread overview]
Message-ID: <20150629201756.GE1225@kernel.org> (raw)
In-Reply-To: <20150629112745.GA21507@krava.brq.redhat.com>

Em Mon, Jun 29, 2015 at 01:27:45PM +0200, Jiri Olsa escreveu:
> On Mon, Jun 29, 2015 at 02:17:18PM +0300, Adrian Hunter wrote:
> > But now you have break; break;
> 
> hum, I did not see the PERF_RECORD_LOST_SAMPLES has 2 breaks already,
> anyway the one for PERF_RECORD_ITRACE_START is missing
> 
> > Isn't putting 'break' on the end of the line making things harder to read?
> 
> I guess, but looks like we dont have firm style in this..
> attaching v2 with the extra break removal

Thanks, applied.

- Arnaldo

  reply	other threads:[~2015-06-29 20:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 11:12 [PATCH " Jiri Olsa
2015-06-29 11:17 ` Adrian Hunter
2015-06-29 11:27   ` [PATCHv2 " Jiri Olsa
2015-06-29 20:17     ` Arnaldo Carvalho de Melo [this message]
2015-07-03  7:47     ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2015-06-29 11:47   ` [PATCH perf/core] " Peter Zijlstra
2015-06-29 13:05     ` Arnaldo Carvalho de Melo
2015-06-29 11:23 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150629201756.GE1225@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome