* [PATCH v3 1/3] ALSA: hda/realtek: cs35l41: Add internal speaker support for ASUS UM3402 with missing DSD
2024-02-13 23:37 [PATCH v3 0/3] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
@ 2024-02-13 23:38 ` lagiraudiere
2024-02-13 23:42 ` [PATCH v3 2/3] ALSA: hda/realtek: cs35l41: Fix device ID / model name Jean-Loïc Charroud
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: lagiraudiere @ 2024-02-13 23:38 UTC (permalink / raw)
To: Jean-Loïc Charroud
Cc: Takashi Iwai, Jaroslav Kysela, Stefan Binding, linux-sound,
linux-kernel, patches
Add the values for the missing DSD properties to the cs35l41 config table.
Signed-off-by: Jean-Loïc Charroud <lagiraudiere+linux@free.fr>
---
sound/pci/hda/cs35l41_hda_property.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 923c0813fa08..d8cd62ef6afc 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -102,6 +102,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
{ "10431D1F", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
{ "10431DA2", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "10431E02", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
+ { "10431E12", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
{ "10431EE2", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
{ "10431F12", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
{ "10431F1F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },
@@ -485,6 +486,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
{ "CSC3551", "10431D1F", generic_dsd_config },
{ "CSC3551", "10431DA2", generic_dsd_config },
{ "CSC3551", "10431E02", generic_dsd_config },
+ { "CSC3551", "10431E12", generic_dsd_config },
{ "CSC3551", "10431EE2", generic_dsd_config },
{ "CSC3551", "10431F12", generic_dsd_config },
{ "CSC3551", "10431F1F", generic_dsd_config },
--
2.40.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 2/3] ALSA: hda/realtek: cs35l41: Fix device ID / model name
2024-02-13 23:37 [PATCH v3 0/3] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
2024-02-13 23:38 ` [PATCH v3 1/3] ALSA: hda/realtek: cs35l41: Add " lagiraudiere
@ 2024-02-13 23:42 ` Jean-Loïc Charroud
2024-02-13 23:44 ` [PATCH v3 3/3] ALSA: hda/realtek: cs35l41: Fix order and duplicates in quirks table Jean-Loïc Charroud
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jean-Loïc Charroud @ 2024-02-13 23:42 UTC (permalink / raw)
To: Takashi Iwai, Jaroslav Kysela, Stefan Binding
Cc: linux-sound, linux-kernel, patches
The patch 51d976079976c800ef19ed1b542602fcf63f0edb ("ALSA: hda/realtek:
Add quirks for ASUS Zenbook 2022 Models") modified the entry 1043:1e2e
from "ASUS UM3402" to "ASUS UM6702RA/RC" and added another entry for
"ASUS UM3402" with 104e:1ee2.
The first entry was correct, while the new one corresponds to model
"ASUS UM6702RA/RC"
Fix the model names for both devices.
Signed-off-by: Jean-Loïc Charroud <lagiraudiere+linux@free.fr>
---
sound/pci/hda/patch_realtek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 7aa88ed04bde..fe81a628d7c8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9939,11 +9939,11 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x16a3, "ASUS UX3402VA", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x1f62, "ASUS UX7602ZM", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA502),
- SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM6702RA/RC", ALC287_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS),
SND_PCI_QUIRK(0x1043, 0x1e5e, "ASUS ROG Strix G513", ALC294_FIXUP_ASUS_G513_PINS),
SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401),
- SND_PCI_QUIRK(0x1043, 0x1ee2, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x1043, 0x1ee2, "ASUS UM6702RA/RC", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1043, 0x1c52, "ASUS Zephyrus G15 2022", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1f12, "ASUS UM5302", ALC287_FIXUP_CS35L41_I2C_2),
--
2.40.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 3/3] ALSA: hda/realtek: cs35l41: Fix order and duplicates in quirks table
2024-02-13 23:37 [PATCH v3 0/3] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
2024-02-13 23:38 ` [PATCH v3 1/3] ALSA: hda/realtek: cs35l41: Add " lagiraudiere
2024-02-13 23:42 ` [PATCH v3 2/3] ALSA: hda/realtek: cs35l41: Fix device ID / model name Jean-Loïc Charroud
@ 2024-02-13 23:44 ` Jean-Loïc Charroud
2024-02-13 23:51 ` [PATCH v3 2/3] ALSA: hda/realtek: cs35l41: Fix device ID / model name Jean-Loïc Charroud
2024-02-14 9:16 ` [PATCH v3 0/3] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Takashi Iwai
4 siblings, 0 replies; 6+ messages in thread
From: Jean-Loïc Charroud @ 2024-02-13 23:44 UTC (permalink / raw)
To: Takashi Iwai, Jaroslav Kysela, Stefan Binding
Cc: linux-sound, linux-kernel, patches
Move entry {0x1043, 0x16a3, "ASUS UX3402VA"} following device ID order.
Remove duplicate entry for device {0x1043, 0x1f62, "ASUS UX7602ZM"}.
Signed-off-by: Jean-Loïc Charroud <lagiraudiere+linux@free.fr>
---
sound/pci/hda/patch_realtek.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fe81a628d7c8..16cb19eee589 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9893,6 +9893,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
SND_PCI_QUIRK(0x1043, 0x1663, "ASUS GU603ZI/ZJ/ZQ/ZU/ZV", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x1043, 0x16a3, "ASUS UX3402VA", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x16d3, "ASUS UX5304VA", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
@@ -9936,8 +9937,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420", ALC256_FIXUP_ASUS_HPE),
SND_PCI_QUIRK(0x1043, 0x1da2, "ASUS UP6502ZA/ZD", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402ZA", ALC245_FIXUP_CS35L41_SPI_2),
- SND_PCI_QUIRK(0x1043, 0x16a3, "ASUS UX3402VA", ALC245_FIXUP_CS35L41_SPI_2),
- SND_PCI_QUIRK(0x1043, 0x1f62, "ASUS UX7602ZM", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA502),
SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS),
--
2.40.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 2/3] ALSA: hda/realtek: cs35l41: Fix device ID / model name
2024-02-13 23:37 [PATCH v3 0/3] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
` (2 preceding siblings ...)
2024-02-13 23:44 ` [PATCH v3 3/3] ALSA: hda/realtek: cs35l41: Fix order and duplicates in quirks table Jean-Loïc Charroud
@ 2024-02-13 23:51 ` Jean-Loïc Charroud
2024-02-14 9:16 ` [PATCH v3 0/3] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Takashi Iwai
4 siblings, 0 replies; 6+ messages in thread
From: Jean-Loïc Charroud @ 2024-02-13 23:51 UTC (permalink / raw)
To: Takashi Iwai, Jaroslav Kysela, Stefan Binding
Cc: linux-sound, linux-kernel, patches
The patch 51d976079976c800ef19ed1b542602fcf63f0edb ("ALSA: hda/realtek:
Add quirks for ASUS Zenbook 2022 Models") modified the entry 1043:1e2e
from "ASUS UM3402" to "ASUS UM6702RA/RC" and added another entry for
"ASUS UM3402" with 104e:1ee2.
The first entry was correct, while the new one corresponds to model
"ASUS UM6702RA/RC"
Fix the model names for both devices.
Signed-off-by: Jean-Loïc Charroud <lagiraudiere+linux@free.fr>
---
sound/pci/hda/patch_realtek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 7aa88ed04bde..fe81a628d7c8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9939,11 +9939,11 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x16a3, "ASUS UX3402VA", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x1f62, "ASUS UX7602ZM", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA502),
- SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM6702RA/RC", ALC287_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS),
SND_PCI_QUIRK(0x1043, 0x1e5e, "ASUS ROG Strix G513", ALC294_FIXUP_ASUS_G513_PINS),
SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401),
- SND_PCI_QUIRK(0x1043, 0x1ee2, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x1043, 0x1ee2, "ASUS UM6702RA/RC", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1043, 0x1c52, "ASUS Zephyrus G15 2022", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1f12, "ASUS UM5302", ALC287_FIXUP_CS35L41_I2C_2),
--
2.40.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 0/3] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD
2024-02-13 23:37 [PATCH v3 0/3] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
` (3 preceding siblings ...)
2024-02-13 23:51 ` [PATCH v3 2/3] ALSA: hda/realtek: cs35l41: Fix device ID / model name Jean-Loïc Charroud
@ 2024-02-14 9:16 ` Takashi Iwai
4 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2024-02-14 9:16 UTC (permalink / raw)
To: Jean-Loïc Charroud
Cc: Takashi Iwai, Jaroslav Kysela, Stefan Binding, linux-sound,
linux-kernel, patches
On Wed, 14 Feb 2024 00:37:23 +0100,
Jean-Loïc Charroud wrote:
>
> This patch set adds the missing DSD properties, to make the internal speaker works for the "ASUS UM3402" and does some cleanup.
>
> Following feedback, I've divided the initial patch into three independent parts and adjusted the explanations:
> - Patch 1 : Add internal speaker support for ASUS UM3402 with missing DSD
> - Patch 2 : Fix device ID / model name (no functional changes)
> - Patch 3 : Fix order and duplicates entry in quirks table (cleanup, no functional changes)
>
> Thank you Takashi for your guidance
> I hope everything is in good shape now.
Thanks! It's almost fine and I corrected minor things in my side
(e.g. adding Fixes tags), now applied all to for-linus branch.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread