From: Philipp Trommler <philipp.trommler@mailbox.tu-dresden.de>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Thomas Ilsche <thomas.ilsche@tu-dresden.de>,
Joseph Schuchart <joseph.schuchart@tu-dresden.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] perf: Fixed indentation errors in Core.py
Date: Tue, 30 Jun 2015 11:16:44 +0200 [thread overview]
Message-ID: <1435655804.18320.15.camel@mailbox.tu-dresden.de> (raw)
In-Reply-To: <1433494892-11682-1-git-send-email-philipp.trommler@mailbox.tu-dresden.de>
Hi!
This is just a short reminder for the patch I sent a few weeks ago. As
it's just a really small change I'd like to ask if someone could review
it, so either I have the chance to fix errors or it can be applied.
Thanks in advance,
Philipp Trommler.
Am Freitag, den 05.06.2015, 11:01 +0200 schrieb Philipp Trommler:
> Those errors prevented the script from running. Just changed some
> tabs to
> spaces.
>
> Signed-off-by: Philipp Trommler <
> philipp.trommler@mailbox.tu-dresden.de>
> ---
> .../python/Perf-Trace-Util/lib/Perf/Trace/Core.py | 28 +++++++++++-
> ----------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/tools/perf/scripts/python/Perf-Trace
> -Util/lib/Perf/Trace/Core.py b/tools/perf/scripts/python/Perf-Trace
> -Util/lib/Perf/Trace/Core.py
> index 38dfb72..b4a3857 100644
> --- a/tools/perf/scripts/python/Perf-Trace
> -Util/lib/Perf/Trace/Core.py
> +++ b/tools/perf/scripts/python/Perf-Trace
> -Util/lib/Perf/Trace/Core.py
> @@ -31,7 +31,7 @@ def flag_str(event_name, field_name, value):
> string = ""
>
> if flag_fields[event_name][field_name]:
> - print_delim = 0
> + print_delim = 0
> keys = flag_fields[event_name][field_name]['values'].keys()
> keys.sort()
> for idx in keys:
> @@ -55,10 +55,10 @@ def symbol_str(event_name, field_name, value):
> keys.sort()
> for idx in keys:
> if not value and not idx:
> - string =
> symbolic_fields[event_name][field_name]['values'][idx]
> + string =
> symbolic_fields[event_name][field_name]['values'][idx]
> break
> - if (value == idx):
> - string =
> symbolic_fields[event_name][field_name]['values'][idx]
> + if (value == idx):
> + string =
> symbolic_fields[event_name][field_name]['values'][idx]
> break
>
> return string
> @@ -77,16 +77,16 @@ def trace_flag_str(value):
> keys = trace_flags.keys()
>
> for idx in keys:
> - if not value and not idx:
> - string += "NONE"
> - break
> -
> - if idx and (value & idx) == idx:
> - if print_delim:
> - string += " | ";
> - string += trace_flags[idx]
> - print_delim = 1
> - value &= ~idx
> + if not value and not idx:
> + string += "NONE"
> + break
> +
> + if idx and (value & idx) == idx:
> + if print_delim:
> + string += " | ";
> + string += trace_flags[idx]
> + print_delim = 1
> + value &= ~idx
>
> return string
>
> --
> 2.4.2
prev parent reply other threads:[~2015-06-30 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 9:01 Philipp Trommler
2015-06-30 9:16 ` Philipp Trommler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435655804.18320.15.camel@mailbox.tu-dresden.de \
--to=philipp.trommler@mailbox.tu-dresden.de \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=joseph.schuchart@tu-dresden.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=thomas.ilsche@tu-dresden.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®